consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Reuse partial to render a banner

Browse Source
This commit is contained in:
Javi Martín
2019-11-10 23:10:23 +01:00
parent 55d339572c
commit 6cb3047da2
5 changed files with 11 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/assets/javascripts/banners.js
View File

@@ -4,23 +4,23 @@
initialize: function() {
$("[data-js-banner-title]").on({
change: function() {
$("#js-banner-title").text($(this).val());
$(".banner h2").text($(this).val());
}
});
$("[data-js-banner-description]").on({
change: function() {
$("#js-banner-description").text($(this).val());
$(".banner h3").text($(this).val());
}
});
$("[name='banner[background_color]']").on({
change: function() {
$("#js-banner-background").css("background-color", $(this).val());
$(".banner").css("background-color", $(this).val());
}
});
$("[name='banner[font_color]']").on({
change: function() {
$("#js-banner-title").css("color", $(this).val());
$("#js-banner-description").css("color", $(this).val());
$(".banner h2").css("color", $(this).val());
$(".banner h3").css("color", $(this).val());
}
});
}

12
app/views/admin/banners/_form.html.erb
View File

@@ -84,15 +84,9 @@
<div class="actions small-12 medium-3 column">
<%= f.submit(class: "button expanded", value: t("admin.banners.edit.form.submit_button")) %>
</div>
</div>
<div id="js-banner-background" class="banner clear"
style="background-color:<%= @banner.background_color %>">
<%= link_to @banner.target_url do %>
<h2 id="js-banner-title" style="color:<%= @banner.font_color %>"><%= @banner.title %></h2>
<h3 id="js-banner-description" style="color:<%= @banner.font_color %>">
<%= @banner.description %>
</h3>
<% end %>
</div>
<div class="row">
<%= render "shared/banner", banner: @banner %>
</div>
<% end %>

7
app/views/admin/banners/index.html.erb
View File

@@ -35,12 +35,7 @@
<tr>
<td colspan="3">
<span class="help-text"><%= t("admin.banners.index.preview") %></span>
<div class="banner" style="background-color:<%= banner.background_color %>">
<%= link_to banner.target_url do %>
<h2 style="color:<%= banner.font_color %>"><%= banner.title %></h2>
<h3 style="color:<%= banner.font_color %>"><%= banner.description %></h3>
<% end %>
</div>
<%= render "shared/banner", banner: banner %>
</td>
</tr>
</tbody>

2
app/views/shared/_banner.html.erb
View File

@@ -1,4 +1,4 @@
<% banner = @banners.sample %>
<% banner ||= @banners.sample %>
<div class="banner" style="background-color:<%= banner.background_color %>;">
<%= link_to banner.target_url do %>
<h2 style="color:<%= banner.font_color %>;"><%= banner.title %></h2>

2
spec/features/admin/banners_spec.rb
View File

@@ -164,7 +164,7 @@ describe "Admin banners magement" do
page.find("body").click
within("div#js-banner-background") do
within(".banner") do
expect(page).to have_selector("h2", text: "Modified title")
expect(page).to have_selector("h3", text: "Edited text")
end