consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove useless label false parameter in select_tag

Browse Source 
`select_tag` creates just a select with no label, so there's no need to
specify `label: false`.
This commit is contained in:
Javi Martín
2019-10-03 04:09:43 +02:00
parent 4f5de5be3b
commit 5fe56a62f1
5 changed files with 11 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
app/views/admin/budget_investments/_search_form.html.erb
View File

@@ -35,33 +35,28 @@
<div class="small-12 medium-3 column">
<%= select_tag :administrator_id,
options_for_select(admin_select_options, params[:administrator_id]),
{ prompt: t("admin.budget_investments.index.administrator_filter_all"),
label: false } %>
{ prompt: t("admin.budget_investments.index.administrator_filter_all") } %>
</div>
<div class="small-12 medium-3 column">
<%= select_tag :valuator_or_group_id,
options_for_select(valuator_or_group_select_options, params[:valuator_or_group_id]),
{ prompt: t("admin.budget_investments.index.valuator_filter_all"),
label: false } %>
{ prompt: t("admin.budget_investments.index.valuator_filter_all") } %>
</div>
<div class="small-12 medium-3 column">
<%= select_tag :heading_id,
options_for_select(budget_heading_select_options(@budget), params[:heading_id]),
{ prompt: t("admin.budget_investments.index.heading_filter_all"),
label: false } %>
{ prompt: t("admin.budget_investments.index.heading_filter_all") } %>
</div>
<div class="small-12 medium-3 column">
<%= select_tag :tag_name,
options_for_select(investment_tags_select_options(@budget), params[:tag_name]),
{ prompt: t("admin.budget_investments.index.tags_filter_all"),
label: false } %>
{ prompt: t("admin.budget_investments.index.tags_filter_all") } %>
</div>
<div class="small-12 medium-3 column">
<%= select_tag :milestone_tag_name,
options_for_select(investment_milestone_tags_select_options(@budget), params[:milestone_tag_name]),
{ prompt: t("admin.budget_investments.index.milestone_tags_filter_all"),
label: false } %>
{ prompt: t("admin.budget_investments.index.milestone_tags_filter_all") } %>
</div>
<div class="small-12 medium-6 column">

6
app/views/admin/poll/shifts/_form.html.erb
View File

@@ -23,13 +23,11 @@
<label><%= t("admin.poll_shifts.new.date") %></label>
<%= select "shift[date]", "vote_collection_date",
options_for_select(shift_vote_collection_dates(@booth, @voting_polls)),
{ prompt: @voting_polls.present? ? t("admin.poll_shifts.new.select_date") : t("admin.poll_shifts.new.no_voting_days"),
label: false },
{ prompt: @voting_polls.present? ? t("admin.poll_shifts.new.select_date") : t("admin.poll_shifts.new.no_voting_days") },
class: "js-shift-vote-collection-dates" %>
<%= select "shift[date]", "recount_scrutiny_date",
options_for_select(shift_recount_scrutiny_dates(@booth, @recount_polls)),
{ prompt: t("admin.poll_shifts.new.select_date"),
label: false },
{ prompt: t("admin.poll_shifts.new.select_date") },
class: "js-shift-recount-scrutiny-dates",
hidden: "hidden" %>
</div>

4
app/views/admin/site_customization/content_blocks/_form_heading_content_block.html.erb
View File

@@ -13,11 +13,11 @@
<div class="small-12 medium-6 column">
<%= label_tag :name %>
<%= select_tag :name, options_for_select(valid_blocks, @selected_content_block), label: false %>
<%= select_tag :name, options_for_select(valid_blocks, @selected_content_block) %>
</div>
<div class="small-12 medium-6 column">
<%= label_tag :locale %>
<%= select_tag :locale, options_for_select(I18n.available_locales, @content_block.locale.to_sym), label: false %>
<%= select_tag :locale, options_for_select(I18n.available_locales, @content_block.locale.to_sym) %>
</div>
<div class="small-12 column">
<%= label_tag :body %>

2
app/views/officing/ballot_sheets/new.html.erb
View File

@@ -5,7 +5,7 @@
<label><%= t("officing.poll_budgets.new.booth") %></label>
<%= select_tag :officer_assignment_id,
booths_for_officer_select_options(@officer_assignments),
{ prompt: t("officing.poll_budgets.new.select_booth"), label: false } %>
{ prompt: t("officing.poll_budgets.new.select_booth") } %>
<label><%= t("officing.poll_budgets.new.csv_data") %></label>
<%= text_area_tag :data, nil, rows: 10 %>

3
app/views/officing/results/new.html.erb
View File

@@ -7,8 +7,7 @@
<label><%= t("officing.results.new.booth") %></label>
<%= select_tag :officer_assignment_id,
booths_for_officer_select_options(@officer_assignments),
{ prompt: t("officing.results.new.select_booth"),
label: false } %>
{ prompt: t("officing.results.new.select_booth") } %>
</div>
</div>