consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Unify code applying the colors of a process

Browse Source 
We had some duplication because the `css_for_process_header` was using
an instance variable, and so it couldn't be called from a partial where
this instance variable wasn't available.

Using a local variable and passing it as a parameter (as we should
always do) solves the issue and lets us simplify the code.
This commit is contained in:
Javi Martín
2025-02-20 18:30:57 +01:00
parent a1352de9eb
commit 53ff81dfdf
4 changed files with 16 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
spec/helpers/legislation_helper_spec.rb
View File

@@ -9,23 +9,23 @@ describe LegislationHelper do
describe "banner colors presence" do
it "background and font color exist" do
@process = build(:legislation_process, background_color: "#944949", font_color: "#ffffff")
expect(banner_color?).to be true
process = build(:legislation_process, background_color: "#944949", font_color: "#ffffff")
expect(banner_color?(process)).to be true
end
it "background color exist and font color not exist" do
@process = build(:legislation_process, background_color: "#944949", font_color: "")
expect(banner_color?).to be false
process = build(:legislation_process, background_color: "#944949", font_color: "")
expect(banner_color?(process)).to be false
end
it "background color not exist and font color exist" do
@process = build(:legislation_process, background_color: "", font_color: "#944949")
expect(banner_color?).to be false
process = build(:legislation_process, background_color: "", font_color: "#944949")
expect(banner_color?(process)).to be false
end
it "background and font color not exist" do
@process = build(:legislation_process, background_color: "", font_color: "")
expect(banner_color?).to be false
process = build(:legislation_process, background_color: "", font_color: "")
expect(banner_color?(process)).to be false
end
end
end