consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Unify code applying the colors of a process

Browse Source 
We had some duplication because the `css_for_process_header` was using
an instance variable, and so it couldn't be called from a partial where
this instance variable wasn't available.

Using a local variable and passing it as a parameter (as we should
always do) solves the issue and lets us simplify the code.
This commit is contained in:
Javi Martín
2025-02-20 18:30:57 +01:00
parent a1352de9eb
commit 53ff81dfdf
4 changed files with 16 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/helpers/legislation_helper.rb
View File

@@ -18,13 +18,13 @@ module LegislationHelper
}
end
def banner_color?
@process.background_color.present? && @process.font_color.present?
def banner_color?(process)
process.background_color.present? && process.font_color.present?
end
def css_for_process_header
if banner_color?
"background: #{@process.background_color};color: #{@process.font_color};"
def css_for_process_header(process)
if banner_color?(process)
"background: #{process.background_color};color: #{process.font_color};"
end
end
end

4
app/views/legislation/processes/_header.html.erb
View File

@@ -1,8 +1,8 @@
<div class="legislation-hero jumbo" style="<%= css_for_process_header %>">
<div class="legislation-hero jumbo" style="<%= css_for_process_header(@process) %>">
<div class="row">
<div class="small-12 medium-9 column">
<% if banner_color? %>
<% if banner_color?(@process) %>
<%= link_to t("shared.back"),
legislation_processes_path,
class: "icon-angle-left",

5
app/views/legislation/processes/_header_full.html.erb
View File

@@ -12,10 +12,7 @@
<%= markdown @process.additional_info if @process.additional_info %>
</div>
<button type="button" class="button" data-toggle="additional_info"
<% if banner_color? %>
style="background:<%= process.font_color %>; color:<%= process.background_color %>;"
<% end %>>
<button type="button" class="button" data-toggle="additional_info" style="<%= css_for_process_header(process) %>">
<%= t("legislation.processes.header.additional_info") %>
</button>
<% end %>

16
spec/helpers/legislation_helper_spec.rb
View File

@@ -9,23 +9,23 @@ describe LegislationHelper do
describe "banner colors presence" do
it "background and font color exist" do
@process = build(:legislation_process, background_color: "#944949", font_color: "#ffffff")
expect(banner_color?).to be true
process = build(:legislation_process, background_color: "#944949", font_color: "#ffffff")
expect(banner_color?(process)).to be true
end
it "background color exist and font color not exist" do
@process = build(:legislation_process, background_color: "#944949", font_color: "")
expect(banner_color?).to be false
process = build(:legislation_process, background_color: "#944949", font_color: "")
expect(banner_color?(process)).to be false
end
it "background color not exist and font color exist" do
@process = build(:legislation_process, background_color: "", font_color: "#944949")
expect(banner_color?).to be false
process = build(:legislation_process, background_color: "", font_color: "#944949")
expect(banner_color?(process)).to be false
end
it "background and font color not exist" do
@process = build(:legislation_process, background_color: "", font_color: "")
expect(banner_color?).to be false
process = build(:legislation_process, background_color: "", font_color: "")
expect(banner_color?(process)).to be false
end
end
end