consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unused sort_by_most_commented scope from Debate

Browse Source 
The "sort_by_most_commented" scope in Debate is no longer used anywhere in
the code. Its last use was removed in commit b89f39bfef ("Removes
unused orders from debates controller")
This commit is contained in:
taitus
2025-10-24 14:10:47 +02:00
parent 8938b781c3
commit 4183734468
4 changed files with 0 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/models/debate.rb
View File

@@ -38,7 +38,6 @@ class Debate < ApplicationRecord
scope :sort_by_hot_score, -> { reorder(hot_score: :desc) }
scope :sort_by_confidence_score, -> { reorder(confidence_score: :desc) }
scope :sort_by_created_at, -> { reorder(created_at: :desc) }
scope :sort_by_most_commented, -> { reorder(comments_count: :desc) }
scope :sort_by_relevance, -> { all }
scope :sort_by_flags, -> { order(flags_count: :desc, updated_at: :desc) }
scope :sort_by_recommendations, -> { order(cached_votes_total: :desc) }

1
config/locales/en/general.yml
View File

@@ -88,7 +88,6 @@ en:
confidence_score: highest rated
created_at: newest
hot_score: most active
most_commented: most commented
relevance: relevance
recommendations: recommendations
recommendations:

1
config/locales/es/general.yml
View File

@@ -88,7 +88,6 @@ es:
confidence_score: Mejor valorados
created_at: Nuevos
hot_score: Más activos
most_commented: Más comentados
relevance: Más relevantes
recommendations: Recomendaciones
recommendations:

14
spec/models/debate_spec.rb
View File

@@ -650,20 +650,6 @@ describe Debate do
expect(results).to eq [newest, recent, oldest]
end
it "is able to reorder by most commented after searching" do
least_commented = create(:debate, title: "stop corruption", cached_votes_up: 1, comments_count: 1)
most_commented = create(:debate, title: "stop corruption", cached_votes_up: 2, comments_count: 100)
some_comments = create(:debate, title: "stop corruption", cached_votes_up: 3, comments_count: 10)
results = Debate.search("stop corruption")
expect(results).to eq [some_comments, most_commented, least_commented]
results = results.sort_by_most_commented
expect(results).to eq [most_commented, some_comments, least_commented]
end
end
context "no results" do