Use describe on feature tests

The `type: :feature` is automatically detected by RSpec because these
tests are inside the `spec/features` folder. Using `feature` re-adds a
`type: :feature` to these files, which will result in a conflict when we
upgrade to Rails 5.1's system tests.

Because of this change, we also need to change `background` to `before`
or else these tests will fail.
This commit is contained in:
Javi Martín
2019-04-29 11:52:36 +02:00
parent 234a5108a4
commit 307cf24846
169 changed files with 416 additions and 420 deletions

View File

@@ -1,6 +1,6 @@
require "rails_helper"
feature "Home" do
describe "Home" do
context "For not logged users" do
@@ -22,9 +22,9 @@ feature "Home" do
context "For signed in users" do
feature "Recommended" do
describe "Recommended" do
background do
before do
Setting["feature.user.recommendations"] = true
user = create(:user)
proposal = create(:proposal, tag_list: "Sport")
@@ -111,7 +111,7 @@ feature "Home" do
end
feature "IE alert" do
describe "IE alert" do
scenario "IE visitors are presented with an alert until they close it", :page_driver do
# Selenium API does not include page request/response inspection methods
# so we must use Capybara::RackTest driver to set the browser's headers