diff --git a/spec/features/account_spec.rb b/spec/features/account_spec.rb index 38e9f5c11..aba01aa47 100644 --- a/spec/features/account_spec.rb +++ b/spec/features/account_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Account" do +describe "Account" do - background do + before do @user = create(:user, username: "Manuela Colau") login_as(@user) end @@ -177,7 +177,7 @@ feature "Account" do context "Recommendations" do - background do + before do Setting["feature.user.recommendations"] = true Setting["feature.user.recommendations_on_debates"] = true Setting["feature.user.recommendations_on_proposals"] = true diff --git a/spec/features/admin/activity_spec.rb b/spec/features/admin/activity_spec.rb index 94e6ef8f3..113062427 100644 --- a/spec/features/admin/activity_spec.rb +++ b/spec/features/admin/activity_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin activity" do +describe "Admin activity" do - background do + before do @admin = create(:administrator) login_as(@admin.user) end diff --git a/spec/features/admin/admin_notifications_spec.rb b/spec/features/admin/admin_notifications_spec.rb index 19910172d..75f142f62 100644 --- a/spec/features/admin/admin_notifications_spec.rb +++ b/spec/features/admin/admin_notifications_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin Notifications" do +describe "Admin Notifications" do - background do + before do admin = create(:administrator) login_as(admin.user) create(:budget) diff --git a/spec/features/admin/administrators_spec.rb b/spec/features/admin/administrators_spec.rb index c69d217da..a782e39d3 100644 --- a/spec/features/admin/administrators_spec.rb +++ b/spec/features/admin/administrators_spec.rb @@ -1,11 +1,11 @@ require "rails_helper" -feature "Admin administrators" do +describe "Admin administrators" do let!(:admin) { create(:administrator) } let!(:user) { create(:user, username: "Jose Luis Balbin") } let!(:user_administrator) { create(:administrator) } - background do + before do login_as(admin.user) visit admin_administrators_path end @@ -58,7 +58,7 @@ feature "Admin administrators" do username: "Tony Soprano", email: "tony@soprano.com")) } - background do + before do visit admin_administrators_path end diff --git a/spec/features/admin/banners_spec.rb b/spec/features/admin/banners_spec.rb index b1dd8278a..5c7a3e066 100644 --- a/spec/features/admin/banners_spec.rb +++ b/spec/features/admin/banners_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin banners magement" do +describe "Admin banners magement" do - background do + before do login_as(create(:administrator).user) end @@ -12,7 +12,7 @@ feature "Admin banners magement" do %w[title description] context "Index" do - background do + before do @banner1 = create(:banner, title: "Banner number one", description: "This is the text of banner number one and is not active yet", target_url: "http://www.url.com", diff --git a/spec/features/admin/budget_groups_spec.rb b/spec/features/admin/budget_groups_spec.rb index 14f76c319..e0b7e3132 100644 --- a/spec/features/admin/budget_groups_spec.rb +++ b/spec/features/admin/budget_groups_spec.rb @@ -1,10 +1,10 @@ require "rails_helper" -feature "Admin budget groups" do +describe "Admin budget groups" do let(:budget) { create(:budget, phase: "drafting") } - background do + before do admin = create(:administrator) login_as(admin.user) end @@ -16,7 +16,7 @@ feature "Admin budget groups" do context "Feature flag" do - background do + before do Setting["process.budgets"] = nil end diff --git a/spec/features/admin/budget_headings_spec.rb b/spec/features/admin/budget_headings_spec.rb index dac63ba04..b4fd06db7 100644 --- a/spec/features/admin/budget_headings_spec.rb +++ b/spec/features/admin/budget_headings_spec.rb @@ -1,11 +1,11 @@ require "rails_helper" -feature "Admin budget headings" do +describe "Admin budget headings" do let(:budget) { create(:budget, phase: "drafting") } let(:group) { create(:budget_group, budget: budget) } - background do + before do admin = create(:administrator) login_as(admin.user) end @@ -17,7 +17,7 @@ feature "Admin budget headings" do context "Feature flag" do - background do + before do Setting["process.budgets"] = nil end diff --git a/spec/features/admin/budget_investment_milestones_spec.rb b/spec/features/admin/budget_investment_milestones_spec.rb index 091285951..e08547542 100644 --- a/spec/features/admin/budget_investment_milestones_spec.rb +++ b/spec/features/admin/budget_investment_milestones_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Admin budget investment milestones" do +describe "Admin budget investment milestones" do it_behaves_like "translatable", "milestone", diff --git a/spec/features/admin/budget_investments_spec.rb b/spec/features/admin/budget_investments_spec.rb index 2fb83ef52..8dd9743d3 100644 --- a/spec/features/admin/budget_investments_spec.rb +++ b/spec/features/admin/budget_investments_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Admin budget investments" do +describe "Admin budget investments" do let(:budget) { create(:budget) } let(:administrator) do @@ -11,14 +11,14 @@ feature "Admin budget investments" do :budget_investment, "admin_budget_budget_investment_path" - background do + before do @admin = create(:administrator) login_as(@admin.user) end context "Feature flag" do - background do + before do Setting["process.budgets"] = nil end @@ -788,7 +788,7 @@ feature "Admin budget investments" do create(:budget_investment, title: "Some other investment", budget: budget) end - background do + before do create(:budget_investment, title: "Some investment", budget: budget) end @@ -820,7 +820,7 @@ feature "Admin budget investments" do end context "Sorting" do - background do + before do create(:budget_investment, title: "B First Investment", budget: budget, cached_votes_up: 50) create(:budget_investment, title: "A Second Investment", budget: budget, cached_votes_up: 25) create(:budget_investment, title: "C Third Investment", budget: budget, cached_votes_up: 10) @@ -1477,8 +1477,8 @@ feature "Admin budget investments" do end end - feature "Pagination" do - background { selected_bi.update(cached_votes_up: 50) } + describe "Pagination" do + before { selected_bi.update(cached_votes_up: 50) } scenario "After unselecting an investment", :js do create_list(:budget_investment, 30, budget: budget) diff --git a/spec/features/admin/budget_phases_spec.rb b/spec/features/admin/budget_phases_spec.rb index b19cafdcd..81f178470 100644 --- a/spec/features/admin/budget_phases_spec.rb +++ b/spec/features/admin/budget_phases_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Admin budget phases" do +describe "Admin budget phases" do let(:budget) { create(:budget) } context "Edit" do diff --git a/spec/features/admin/budgets_spec.rb b/spec/features/admin/budgets_spec.rb index 772330b7b..e7c99cfb4 100644 --- a/spec/features/admin/budgets_spec.rb +++ b/spec/features/admin/budgets_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin budgets" do +describe "Admin budgets" do - background do + before do admin = create(:administrator) login_as(admin.user) end @@ -14,7 +14,7 @@ feature "Admin budgets" do context "Feature flag" do - background do + before do Setting["process.budgets"] = nil end @@ -226,7 +226,7 @@ feature "Admin budgets" do context "Update" do - background do + before do create(:budget) end diff --git a/spec/features/admin/comments_spec.rb b/spec/features/admin/comments_spec.rb index 0c4994e31..5953e5252 100644 --- a/spec/features/admin/comments_spec.rb +++ b/spec/features/admin/comments_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin comments" do +describe "Admin comments" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/dashboard/actions_spec.rb b/spec/features/admin/dashboard/actions_spec.rb index 0492bc56e..652d2c9f6 100644 --- a/spec/features/admin/dashboard/actions_spec.rb +++ b/spec/features/admin/dashboard/actions_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Admin dashboard actions" do +describe "Admin dashboard actions" do let(:admin) { create :administrator } before do diff --git a/spec/features/admin/dashboard/administrator_tasks_spec.rb b/spec/features/admin/dashboard/administrator_tasks_spec.rb index 985f9d641..f5520cbc0 100644 --- a/spec/features/admin/dashboard/administrator_tasks_spec.rb +++ b/spec/features/admin/dashboard/administrator_tasks_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Admin administrator tasks" do +describe "Admin administrator tasks" do let(:admin) { create :administrator } before do diff --git a/spec/features/admin/debates_spec.rb b/spec/features/admin/debates_spec.rb index 18c238646..009e1900e 100644 --- a/spec/features/admin/debates_spec.rb +++ b/spec/features/admin/debates_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Admin debates" do +describe "Admin debates" do scenario "Disabled with a feature flag" do Setting["process.debates"] = nil @@ -12,7 +12,7 @@ feature "Admin debates" do Setting["process.debates"] = true end - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/emails/emails_download_spec.rb b/spec/features/admin/emails/emails_download_spec.rb index 13aad88a7..c3c48428e 100644 --- a/spec/features/admin/emails/emails_download_spec.rb +++ b/spec/features/admin/emails/emails_download_spec.rb @@ -1,10 +1,10 @@ require "rails_helper" -feature "Admin download user emails" do +describe "Admin download user emails" do let(:admin_user) { create(:user, newsletter: false, email: "admin@consul.dev") } - background do + before do create(:administrator, user: admin_user) login_as(admin_user) end diff --git a/spec/features/admin/emails/newsletters_spec.rb b/spec/features/admin/emails/newsletters_spec.rb index 7356ed978..0278738da 100644 --- a/spec/features/admin/emails/newsletters_spec.rb +++ b/spec/features/admin/emails/newsletters_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin newsletter emails" do +describe "Admin newsletter emails" do - background do + before do admin = create(:administrator) login_as(admin.user) create(:budget) diff --git a/spec/features/admin/feature_flags_spec.rb b/spec/features/admin/feature_flags_spec.rb index 155c822e7..b22e6831b 100644 --- a/spec/features/admin/feature_flags_spec.rb +++ b/spec/features/admin/feature_flags_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin feature flags" do +describe "Admin feature flags" do - background do + before do Setting["feature.spending_proposals"] = true Setting["feature.spending_proposal_features.voting_allowed"] = true login_as(create(:administrator).user) diff --git a/spec/features/admin/geozones_spec.rb b/spec/features/admin/geozones_spec.rb index 9fadded83..896f1c4f5 100644 --- a/spec/features/admin/geozones_spec.rb +++ b/spec/features/admin/geozones_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin geozones" do +describe "Admin geozones" do - background do + before do login_as(create(:administrator).user) end diff --git a/spec/features/admin/hidden_budget_investments_spec.rb b/spec/features/admin/hidden_budget_investments_spec.rb index 1b1944ea0..451ff48e3 100644 --- a/spec/features/admin/hidden_budget_investments_spec.rb +++ b/spec/features/admin/hidden_budget_investments_spec.rb @@ -1,12 +1,12 @@ require "rails_helper" -feature "Admin hidden budget investments" do +describe "Admin hidden budget investments" do let(:budget) { create(:budget) } let(:group) { create(:budget_group, name: "Music", budget: budget) } let(:heading) { create(:budget_heading, name: "Black metal", price: 666666, group: group) } - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/hidden_proposals_spec.rb b/spec/features/admin/hidden_proposals_spec.rb index 724b8ffea..c7a7a3d24 100644 --- a/spec/features/admin/hidden_proposals_spec.rb +++ b/spec/features/admin/hidden_proposals_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin hidden proposals" do +describe "Admin hidden proposals" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/hidden_users_spec.rb b/spec/features/admin/hidden_users_spec.rb index 8061277c3..3e90cbed0 100644 --- a/spec/features/admin/hidden_users_spec.rb +++ b/spec/features/admin/hidden_users_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin hidden users" do +describe "Admin hidden users" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/homepage/homepage_spec.rb b/spec/features/admin/homepage/homepage_spec.rb index d82f39d99..c2c47c6e0 100644 --- a/spec/features/admin/homepage/homepage_spec.rb +++ b/spec/features/admin/homepage/homepage_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Homepage" do +describe "Homepage" do - background do + before do admin = create(:administrator).user login_as(admin) diff --git a/spec/features/admin/legislation/draft_versions_spec.rb b/spec/features/admin/legislation/draft_versions_spec.rb index 5fedbab5a..f930fec01 100644 --- a/spec/features/admin/legislation/draft_versions_spec.rb +++ b/spec/features/admin/legislation/draft_versions_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin legislation draft versions" do +describe "Admin legislation draft versions" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/legislation/processes_spec.rb b/spec/features/admin/legislation/processes_spec.rb index 838dbe2bb..2da2ca0c5 100644 --- a/spec/features/admin/legislation/processes_spec.rb +++ b/spec/features/admin/legislation/processes_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin collaborative legislation" do +describe "Admin collaborative legislation" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/legislation/proposals_spec.rb b/spec/features/admin/legislation/proposals_spec.rb index 932b21d43..06d56ff11 100644 --- a/spec/features/admin/legislation/proposals_spec.rb +++ b/spec/features/admin/legislation/proposals_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin collaborative legislation" do +describe "Admin collaborative legislation" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/legislation/questions_spec.rb b/spec/features/admin/legislation/questions_spec.rb index ec1355f15..bc1cf7ba0 100644 --- a/spec/features/admin/legislation/questions_spec.rb +++ b/spec/features/admin/legislation/questions_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin legislation questions" do +describe "Admin legislation questions" do - background do + before do admin = create(:administrator) login_as(admin.user) end @@ -16,7 +16,7 @@ feature "Admin legislation questions" do context "Feature flag" do - background do + before do Setting["process.legislation"] = nil end diff --git a/spec/features/admin/managers_spec.rb b/spec/features/admin/managers_spec.rb index 915ebe34f..f1d81efa7 100644 --- a/spec/features/admin/managers_spec.rb +++ b/spec/features/admin/managers_spec.rb @@ -1,7 +1,7 @@ require "rails_helper" -feature "Admin managers" do - background do +describe "Admin managers" do + before do @admin = create(:administrator) @user = create(:user) @manager = create(:manager) @@ -36,7 +36,7 @@ feature "Admin managers" do context "Search" do - background do + before do user = create(:user, username: "Taylor Swift", email: "taylor@swift.com") user2 = create(:user, username: "Stephanie Corneliussen", email: "steph@mrrobot.com") @manager1 = create(:manager, user: user) diff --git a/spec/features/admin/milestone_statuses_spec.rb b/spec/features/admin/milestone_statuses_spec.rb index 56442db54..8dc196155 100644 --- a/spec/features/admin/milestone_statuses_spec.rb +++ b/spec/features/admin/milestone_statuses_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin milestone statuses" do +describe "Admin milestone statuses" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/moderators_spec.rb b/spec/features/admin/moderators_spec.rb index 733a45b90..9ccca132c 100644 --- a/spec/features/admin/moderators_spec.rb +++ b/spec/features/admin/moderators_spec.rb @@ -1,7 +1,7 @@ require "rails_helper" -feature "Admin moderators" do - background do +describe "Admin moderators" do + before do @admin = create(:administrator) @user = create(:user, username: "Jose Luis Balbin") @moderator = create(:moderator) @@ -36,7 +36,7 @@ feature "Admin moderators" do context "Search" do - background do + before do user = create(:user, username: "Elizabeth Bathory", email: "elizabeth@bathory.com") user2 = create(:user, username: "Ada Lovelace", email: "ada@lovelace.com") @moderator1 = create(:moderator, user: user) diff --git a/spec/features/admin/officials_spec.rb b/spec/features/admin/officials_spec.rb index ce17f58f7..639bbd730 100644 --- a/spec/features/admin/officials_spec.rb +++ b/spec/features/admin/officials_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin officials" do +describe "Admin officials" do - background do + before do @citizen = create(:user, username: "Citizen Kane") @official = create(:user, official_position: "Mayor", official_level: 5) @admin = create(:administrator) diff --git a/spec/features/admin/organizations_spec.rb b/spec/features/admin/organizations_spec.rb index 061967328..c646f3fc6 100644 --- a/spec/features/admin/organizations_spec.rb +++ b/spec/features/admin/organizations_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin::Organizations" do +describe "Admin::Organizations" do - background do + before do administrator = create(:user) create(:administrator, user: administrator) @@ -28,7 +28,7 @@ feature "Admin::Organizations" do context "Search" do - background do + before do @user = create(:user, email: "marley@humanrights.com", phone_number: "6764440002") create(:organization, user: @user, name: "Get up, Stand up") end diff --git a/spec/features/admin/poll/active_polls_spec.rb b/spec/features/admin/poll/active_polls_spec.rb index 9fffd70f7..48eff3ea7 100644 --- a/spec/features/admin/poll/active_polls_spec.rb +++ b/spec/features/admin/poll/active_polls_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin Active polls" do +describe "Admin Active polls" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/poll/booth_assigments_spec.rb b/spec/features/admin/poll/booth_assigments_spec.rb index 29c447c31..39e292fcb 100644 --- a/spec/features/admin/poll/booth_assigments_spec.rb +++ b/spec/features/admin/poll/booth_assigments_spec.rb @@ -1,13 +1,13 @@ require "rails_helper" -feature "Admin booths assignments" do +describe "Admin booths assignments" do - background do + before do admin = create(:administrator) login_as(admin.user) end - feature "Admin Booth Assignment management" do + describe "Admin Booth Assignment management" do let!(:poll) { create(:poll) } let!(:booth) { create(:poll_booth) } @@ -143,7 +143,7 @@ feature "Admin booths assignments" do end end - feature "Show" do + describe "Show" do scenario "Lists all assigned poll officers" do poll = create(:poll) booth = create(:poll_booth) diff --git a/spec/features/admin/poll/booths_spec.rb b/spec/features/admin/poll/booths_spec.rb index 592bb7c34..c49a34b6b 100644 --- a/spec/features/admin/poll/booths_spec.rb +++ b/spec/features/admin/poll/booths_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin booths" do +describe "Admin booths" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/poll/officer_assignments_spec.rb b/spec/features/admin/poll/officer_assignments_spec.rb index d58f1331a..891f381c4 100644 --- a/spec/features/admin/poll/officer_assignments_spec.rb +++ b/spec/features/admin/poll/officer_assignments_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Officer Assignments" do +describe "Officer Assignments" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/poll/officers_spec.rb b/spec/features/admin/poll/officers_spec.rb index 4fd3f0d96..c47f17ccb 100644 --- a/spec/features/admin/poll/officers_spec.rb +++ b/spec/features/admin/poll/officers_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin poll officers" do +describe "Admin poll officers" do - background do + before do @admin = create(:administrator) @user = create(:user, username: "Pedro Jose Garcia") @officer = create(:poll_officer) diff --git a/spec/features/admin/poll/polls_spec.rb b/spec/features/admin/poll/polls_spec.rb index f48e6eb37..0a898c34e 100644 --- a/spec/features/admin/poll/polls_spec.rb +++ b/spec/features/admin/poll/polls_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin polls" do +describe "Admin polls" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/poll/questions/answers/answers_spec.rb b/spec/features/admin/poll/questions/answers/answers_spec.rb index 4b1ca3a6e..6efc76fb6 100644 --- a/spec/features/admin/poll/questions/answers/answers_spec.rb +++ b/spec/features/admin/poll/questions/answers/answers_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Answers" do +describe "Answers" do - background do + before do admin = create(:administrator) login_as admin.user end diff --git a/spec/features/admin/poll/questions/answers/documents/documents_spec.rb b/spec/features/admin/poll/questions/answers/documents/documents_spec.rb index 34d43a454..17340d98d 100644 --- a/spec/features/admin/poll/questions/answers/documents/documents_spec.rb +++ b/spec/features/admin/poll/questions/answers/documents/documents_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Documents" do +describe "Documents" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/poll/questions/answers/images/images_spec.rb b/spec/features/admin/poll/questions/answers/images/images_spec.rb index 2e62250e1..474b63a5c 100644 --- a/spec/features/admin/poll/questions/answers/images/images_spec.rb +++ b/spec/features/admin/poll/questions/answers/images/images_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Images" do +describe "Images" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/poll/questions/answers/videos/videos_spec.rb b/spec/features/admin/poll/questions/answers/videos/videos_spec.rb index e11f3b9e4..a801accaa 100644 --- a/spec/features/admin/poll/questions/answers/videos/videos_spec.rb +++ b/spec/features/admin/poll/questions/answers/videos/videos_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Videos" do +describe "Videos" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/poll/questions_spec.rb b/spec/features/admin/poll/questions_spec.rb index 188fcf215..c315f904e 100644 --- a/spec/features/admin/poll/questions_spec.rb +++ b/spec/features/admin/poll/questions_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin poll questions" do +describe "Admin poll questions" do - background do + before do login_as(create(:administrator).user) end diff --git a/spec/features/admin/poll/shifts_spec.rb b/spec/features/admin/poll/shifts_spec.rb index a4b1cbed9..1aead8555 100644 --- a/spec/features/admin/poll/shifts_spec.rb +++ b/spec/features/admin/poll/shifts_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin shifts" do +describe "Admin shifts" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/proposal_notifications_spec.rb b/spec/features/admin/proposal_notifications_spec.rb index 6bf60709c..c2977daed 100644 --- a/spec/features/admin/proposal_notifications_spec.rb +++ b/spec/features/admin/proposal_notifications_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin proposal notifications" do +describe "Admin proposal notifications" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/proposals_spec.rb b/spec/features/admin/proposals_spec.rb index affc723f7..0048108ad 100644 --- a/spec/features/admin/proposals_spec.rb +++ b/spec/features/admin/proposals_spec.rb @@ -1,7 +1,7 @@ require "rails_helper" -feature "Admin proposals" do - background do +describe "Admin proposals" do + before do login_as create(:administrator).user end diff --git a/spec/features/admin/settings_spec.rb b/spec/features/admin/settings_spec.rb index 41d573299..4800b8c3e 100644 --- a/spec/features/admin/settings_spec.rb +++ b/spec/features/admin/settings_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin settings" do +describe "Admin settings" do - background do + before do @setting1 = create(:setting) @setting2 = create(:setting) @setting3 = create(:setting) diff --git a/spec/features/admin/signature_sheets_spec.rb b/spec/features/admin/signature_sheets_spec.rb index edaa42336..63d6c2607 100644 --- a/spec/features/admin/signature_sheets_spec.rb +++ b/spec/features/admin/signature_sheets_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Signature sheets" do +describe "Signature sheets" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/site_customization/content_blocks_spec.rb b/spec/features/admin/site_customization/content_blocks_spec.rb index c2e5e519a..e21a76e88 100644 --- a/spec/features/admin/site_customization/content_blocks_spec.rb +++ b/spec/features/admin/site_customization/content_blocks_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin custom content blocks" do +describe "Admin custom content blocks" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/site_customization/documents_spec.rb b/spec/features/admin/site_customization/documents_spec.rb index 0ff667c2b..92f322fac 100644 --- a/spec/features/admin/site_customization/documents_spec.rb +++ b/spec/features/admin/site_customization/documents_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Documents" do +describe "Documents" do before do admin = create(:administrator) diff --git a/spec/features/admin/site_customization/images_spec.rb b/spec/features/admin/site_customization/images_spec.rb index 8a5a00c28..59961c71e 100644 --- a/spec/features/admin/site_customization/images_spec.rb +++ b/spec/features/admin/site_customization/images_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin custom images" do +describe "Admin custom images" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/site_customization/information_texts_spec.rb b/spec/features/admin/site_customization/information_texts_spec.rb index 547ead3a7..f561c909a 100644 --- a/spec/features/admin/site_customization/information_texts_spec.rb +++ b/spec/features/admin/site_customization/information_texts_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin custom information texts" do +describe "Admin custom information texts" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/site_customization/pages_spec.rb b/spec/features/admin/site_customization/pages_spec.rb index 07a162d97..9a6cf35ea 100644 --- a/spec/features/admin/site_customization/pages_spec.rb +++ b/spec/features/admin/site_customization/pages_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin custom pages" do +describe "Admin custom pages" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/stats_spec.rb b/spec/features/admin/stats_spec.rb index bc5bb3a2c..ca1b9be20 100644 --- a/spec/features/admin/stats_spec.rb +++ b/spec/features/admin/stats_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Stats" do +describe "Stats" do - background do + before do admin = create(:administrator) login_as(admin.user) visit root_path @@ -104,7 +104,7 @@ feature "Stats" do describe "Budget investments" do context "Supporting phase" do - background do + before do @budget = create(:budget) @group_all_city = create(:budget_group, budget: @budget) @heading_all_city = create(:budget_heading, group: @group_all_city) @@ -191,7 +191,7 @@ feature "Stats" do end context "Balloting phase" do - background do + before do @budget = create(:budget, :balloting) @group = create(:budget_group, budget: @budget) @heading = create(:budget_heading, group: @group) diff --git a/spec/features/admin/system_emails_spec.rb b/spec/features/admin/system_emails_spec.rb index 831e560f7..4c71f4f3f 100644 --- a/spec/features/admin/system_emails_spec.rb +++ b/spec/features/admin/system_emails_spec.rb @@ -1,10 +1,10 @@ require "rails_helper" -feature "System Emails" do +describe "System Emails" do let(:admin) { create(:administrator) } - background do + before do login_as(admin.user) end diff --git a/spec/features/admin/tags_spec.rb b/spec/features/admin/tags_spec.rb index 3102df400..ac8a3856a 100644 --- a/spec/features/admin/tags_spec.rb +++ b/spec/features/admin/tags_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin tags" do +describe "Admin tags" do - background do + before do @tag1 = create(:tag, :category) login_as(create(:administrator).user) end diff --git a/spec/features/admin/users_spec.rb b/spec/features/admin/users_spec.rb index 7972f7c16..8ba66a6d7 100644 --- a/spec/features/admin/users_spec.rb +++ b/spec/features/admin/users_spec.rb @@ -1,7 +1,7 @@ require "rails_helper" -feature "Admin users" do - background do +describe "Admin users" do + before do @admin = create(:administrator) @user = create(:user, username: "Jose Luis Balbin") login_as(@admin.user) diff --git a/spec/features/admin/valuator_groups_spec.rb b/spec/features/admin/valuator_groups_spec.rb index 9cf86bc50..12134379e 100644 --- a/spec/features/admin/valuator_groups_spec.rb +++ b/spec/features/admin/valuator_groups_spec.rb @@ -1,10 +1,10 @@ require "rails_helper" -feature "Valuator groups" do +describe "Valuator groups" do let(:admin) { create(:administrator).user } - background do + before do login_as(admin) end diff --git a/spec/features/admin/valuators_spec.rb b/spec/features/admin/valuators_spec.rb index c80e44fcc..a8a08b9f9 100644 --- a/spec/features/admin/valuators_spec.rb +++ b/spec/features/admin/valuators_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin valuators" do +describe "Admin valuators" do - background do + before do @admin = create(:administrator) @user = create(:user, username: "Jose Luis Balbin") @valuator = create(:valuator) @@ -57,7 +57,7 @@ feature "Admin valuators" do context "Search" do - background do + before do user = create(:user, username: "David Foster Wallace", email: "david@wallace.com") user2 = create(:user, username: "Steven Erikson", email: "steven@erikson.com") @valuator1 = create(:valuator, user: user) diff --git a/spec/features/admin/verifications_spec.rb b/spec/features/admin/verifications_spec.rb index 0d09eaaf0..8bbc1174a 100644 --- a/spec/features/admin/verifications_spec.rb +++ b/spec/features/admin/verifications_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Incomplete verifications" do +describe "Incomplete verifications" do - background do + before do admin = create(:administrator) login_as(admin.user) end diff --git a/spec/features/admin/widgets/cards_spec.rb b/spec/features/admin/widgets/cards_spec.rb index 316ebc3c2..2f4d9bbd4 100644 --- a/spec/features/admin/widgets/cards_spec.rb +++ b/spec/features/admin/widgets/cards_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Cards" do +describe "Cards" do - background do + before do admin = create(:administrator).user login_as(admin) end diff --git a/spec/features/admin_spec.rb b/spec/features/admin_spec.rb index f7808d601..e290b506d 100644 --- a/spec/features/admin_spec.rb +++ b/spec/features/admin_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Admin" do +describe "Admin" do let(:user) { create(:user) } let(:administrator) do create(:administrator, user: user) diff --git a/spec/features/banners_spec.rb b/spec/features/banners_spec.rb index 2bdd475b5..3a9503bec 100644 --- a/spec/features/banners_spec.rb +++ b/spec/features/banners_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Banner" do +describe "Banner" do scenario "The banner is shown correctly" do create(:web_section, name: "homepage") diff --git a/spec/features/budget_polls/ballot_sheets_spec.rb b/spec/features/budget_polls/ballot_sheets_spec.rb index cc42e253d..5e17fc2d9 100644 --- a/spec/features/budget_polls/ballot_sheets_spec.rb +++ b/spec/features/budget_polls/ballot_sheets_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Poll budget ballot sheets" do +describe "Poll budget ballot sheets" do let(:budget) { create(:budget) } let(:poll) { create(:poll, budget: budget, ends_at: 1.day.ago) } let(:booth) { create(:poll_booth) } @@ -8,7 +8,7 @@ feature "Poll budget ballot sheets" do context "Officing recounts and results view" do - background do + before do create(:poll_booth_assignment, poll: poll, booth: booth) create(:poll_shift, :recount_scrutiny_task, officer: poll_officer, booth: booth, date: Date.current) @@ -80,7 +80,7 @@ feature "Poll budget ballot sheets" do context "Index" do - background do + before do create(:poll_booth_assignment, poll: poll, booth: booth) create(:poll_shift, :recount_scrutiny_task, officer: poll_officer, booth: booth, date: Date.current) @@ -102,7 +102,7 @@ feature "Poll budget ballot sheets" do context "New" do - background do + before do create(:poll_booth_assignment, poll: poll, booth: booth) create(:poll_shift, :recount_scrutiny_task, officer: poll_officer, booth: booth, date: Date.current) @@ -150,7 +150,7 @@ feature "Poll budget ballot sheets" do context "Show" do - background do + before do create(:poll_booth_assignment, poll: poll, booth: booth) create(:poll_shift, :recount_scrutiny_task, officer: poll_officer, booth: booth, date: Date.current) diff --git a/spec/features/budget_polls/budgets_spec.rb b/spec/features/budget_polls/budgets_spec.rb index 6c815e337..036db71c3 100644 --- a/spec/features/budget_polls/budgets_spec.rb +++ b/spec/features/budget_polls/budgets_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Admin Budgets" do +describe "Admin Budgets" do - background do + before do admin = create(:administrator).user login_as(admin) end diff --git a/spec/features/budget_polls/officing_spec.rb b/spec/features/budget_polls/officing_spec.rb index 7b91eec12..d9ae81cac 100644 --- a/spec/features/budget_polls/officing_spec.rb +++ b/spec/features/budget_polls/officing_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Budget Poll Officing" do +describe "Budget Poll Officing" do scenario "Show sidebar menus if officer has shifts assigned" do poll = create(:poll) diff --git a/spec/features/budget_polls/polls_spec.rb b/spec/features/budget_polls/polls_spec.rb index d9ae151cf..bc394bad9 100644 --- a/spec/features/budget_polls/polls_spec.rb +++ b/spec/features/budget_polls/polls_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Polls" do +describe "Polls" do context "Public index" do diff --git a/spec/features/budget_polls/questions_spec.rb b/spec/features/budget_polls/questions_spec.rb index 5e320573b..1d0add98b 100644 --- a/spec/features/budget_polls/questions_spec.rb +++ b/spec/features/budget_polls/questions_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Poll Questions" do +describe "Poll Questions" do before do admin = create(:administrator).user diff --git a/spec/features/budget_polls/voter_spec.rb b/spec/features/budget_polls/voter_spec.rb index 6462f021d..b2225c05b 100644 --- a/spec/features/budget_polls/voter_spec.rb +++ b/spec/features/budget_polls/voter_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "BudgetPolls", :with_frozen_time do +describe "BudgetPolls", :with_frozen_time do let(:budget) { create(:budget, :balloting) } let(:group) { create(:budget_group, budget: budget) } let(:heading) { create(:budget_heading, group: group) } @@ -11,7 +11,7 @@ feature "BudgetPolls", :with_frozen_time do let(:admin) { create(:administrator) } let!(:user) { create(:user, :in_census) } - background do + before do create(:poll_shift, officer: officer, booth: booth, date: Date.current, task: :vote_collection) booth_assignment = create(:poll_booth_assignment, poll: poll, booth: booth) create(:poll_officer_assignment, officer: officer, booth_assignment: booth_assignment, date: Date.current) diff --git a/spec/features/budgets/ballots_spec.rb b/spec/features/budgets/ballots_spec.rb index d849ccfc5..0f9bb1c05 100644 --- a/spec/features/budgets/ballots_spec.rb +++ b/spec/features/budgets/ballots_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Ballots" do +describe "Ballots" do let!(:user) { create(:user, :level_two) } let!(:budget) { create(:budget, phase: "balloting") } @@ -10,7 +10,7 @@ feature "Ballots" do context "Voting" do - background do + before do login_as(user) visit budget_path(budget) end @@ -280,7 +280,7 @@ feature "Ballots" do let!(:investment) { create(:budget_investment, :selected, heading: california) } - background { login_as(user) } + before { login_as(user) } scenario "Select my heading", :js do visit budget_path(budget) diff --git a/spec/features/budgets/budgets_spec.rb b/spec/features/budgets/budgets_spec.rb index 0aa886014..2d404fbd9 100644 --- a/spec/features/budgets/budgets_spec.rb +++ b/spec/features/budgets/budgets_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Budgets" do +describe "Budgets" do let(:budget) { create(:budget) } let(:level_two_user) { create(:user, :level_two) } @@ -258,7 +258,7 @@ feature "Budgets" do let(:group) { create(:budget_group, budget: budget) } let(:heading) { create(:budget_heading, group: group) } - background do + before do Setting["feature.map"] = true end @@ -468,7 +468,7 @@ feature "Budgets" do let(:admin) { create(:administrator).user } - background do + before do logout budget.update(phase: "drafting") create(:budget) @@ -505,7 +505,7 @@ feature "Budgets" do context "Accepting" do - background do + before do budget.update(phase: "accepting") end diff --git a/spec/features/budgets/executions_spec.rb b/spec/features/budgets/executions_spec.rb index b6c0e60c6..dd8966ed9 100644 --- a/spec/features/budgets/executions_spec.rb +++ b/spec/features/budgets/executions_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Executions" do +describe "Executions" do let(:budget) { create(:budget, :finished) } let(:group) { create(:budget_group, budget: budget) } diff --git a/spec/features/budgets/groups_spec.rb b/spec/features/budgets/groups_spec.rb index c19783a73..808646733 100644 --- a/spec/features/budgets/groups_spec.rb +++ b/spec/features/budgets/groups_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Budget Groups" do +describe "Budget Groups" do let(:budget) { create(:budget) } let(:group) { create(:budget_group, budget: budget) } diff --git a/spec/features/budgets/investments_spec.rb b/spec/features/budgets/investments_spec.rb index 4d01a2c12..66873fbf2 100644 --- a/spec/features/budgets/investments_spec.rb +++ b/spec/features/budgets/investments_spec.rb @@ -1,8 +1,7 @@ require "rails_helper" require "sessions_helper" -feature "Budget Investments" do - +describe "Budget Investments" do let(:author) { create(:user, :level_two, username: "Isabel") } let(:budget) { create(:budget, name: "Big Budget") } @@ -1019,7 +1018,7 @@ feature "Budget Investments" do context "When investment with price is unselected" do - background do + before do investment.update(selected: false) end @@ -1086,7 +1085,7 @@ feature "Budget Investments" do price_explanation: "Every wheel is 4 euros, so total is 16") end - background do + before do user = create(:user) login_as(user) end @@ -1314,7 +1313,7 @@ feature "Budget Investments" do context "Selecting Phase" do - background do + before do budget.update(phase: "selecting") end @@ -1397,7 +1396,7 @@ feature "Budget Investments" do context "Evaluating Phase" do - background do + before do budget.update(phase: "valuating") end @@ -1440,7 +1439,7 @@ feature "Budget Investments" do context "Publishing prices phase" do - background do + before do budget.update(phase: "publishing_prices") end @@ -1461,7 +1460,7 @@ feature "Budget Investments" do context "Balloting Phase" do - background do + before do budget.update(phase: "balloting") end @@ -1707,7 +1706,7 @@ feature "Budget Investments" do expect(page).not_to have_link("Vote") end - feature "Reclassification" do + describe "Reclassification" do scenario "Due to heading change" do user = create(:user, :level_two) diff --git a/spec/features/budgets/results_spec.rb b/spec/features/budgets/results_spec.rb index 0fcf809b9..f8e00bcb3 100644 --- a/spec/features/budgets/results_spec.rb +++ b/spec/features/budgets/results_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Results" do +describe "Results" do let(:budget) { create(:budget, :finished) } let(:group) { create(:budget_group, budget: budget) } @@ -11,7 +11,7 @@ feature "Results" do let!(:investment3) { create(:budget_investment, :incompatible, heading: heading, price: 500, ballot_lines_count: 700) } let!(:investment4) { create(:budget_investment, :selected, heading: heading, price: 600, ballot_lines_count: 600) } - background do + before do Budget::Result.new(budget, heading).calculate_winners end diff --git a/spec/features/budgets/stats_spec.rb b/spec/features/budgets/stats_spec.rb index f459a74a4..5b9305b33 100644 --- a/spec/features/budgets/stats_spec.rb +++ b/spec/features/budgets/stats_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Stats" do +describe "Stats" do let(:budget) { create(:budget) } let(:group) { create(:budget_group, budget: budget) } diff --git a/spec/features/budgets/votes_spec.rb b/spec/features/budgets/votes_spec.rb index 8513ec420..282cd449a 100644 --- a/spec/features/budgets/votes_spec.rb +++ b/spec/features/budgets/votes_spec.rb @@ -1,16 +1,16 @@ require "rails_helper" -feature "Votes" do +describe "Votes" do - feature "Investments" do + describe "Investments" do let(:manuela) { create(:user, verified_at: Time.current) } let(:budget) { create(:budget, phase: "selecting") } let(:group) { create(:budget_group, budget: budget) } let(:heading) { create(:budget_heading, group: group) } - background { login_as(manuela) } + before { login_as(manuela) } - feature "Index" do + describe "Index" do scenario "Index shows user votes on proposals" do investment1 = create(:budget_investment, heading: heading) @@ -53,7 +53,7 @@ feature "Votes" do end end - feature "Single spending proposal" do + describe "Single spending proposal" do let(:investment) { create(:budget_investment, budget: budget, heading: heading)} scenario "Show no votes" do @@ -116,7 +116,7 @@ feature "Votes" do let!(:san_francisco_investment) { create(:budget_investment, heading: san_francisco) } let!(:third_heading_investment) { create(:budget_investment, heading: third_heading) } - background do + before do group.update(max_votable_headings: 2) end diff --git a/spec/features/campaigns_spec.rb b/spec/features/campaigns_spec.rb index 517c95481..a050d24e5 100644 --- a/spec/features/campaigns_spec.rb +++ b/spec/features/campaigns_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Email campaigns" do +describe "Email campaigns" do - background do + before do @campaign1 = create(:campaign) @campaign2 = create(:campaign) diff --git a/spec/features/ckeditor_spec.rb b/spec/features/ckeditor_spec.rb index 469df5001..568441d5d 100644 --- a/spec/features/ckeditor_spec.rb +++ b/spec/features/ckeditor_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "CKEditor" do +describe "CKEditor" do scenario "is present before & after turbolinks update page", :js do author = create(:user) diff --git a/spec/features/comments/budget_investments_spec.rb b/spec/features/comments/budget_investments_spec.rb index c3a3e3193..58a468755 100644 --- a/spec/features/comments/budget_investments_spec.rb +++ b/spec/features/comments/budget_investments_spec.rb @@ -1,7 +1,7 @@ require "rails_helper" include ActionView::Helpers::DateHelper -feature "Commenting Budget::Investments" do +describe "Commenting Budget::Investments" do let(:user) { create :user } let(:investment) { create :budget_investment } @@ -159,7 +159,7 @@ feature "Commenting Budget::Investments" do expect(page).to have_css(".comment", count: 2) end - feature "Not logged user" do + describe "Not logged user" do scenario "can not see comments forms" do create(:comment, commentable: investment) visit budget_investment_path(investment.budget, investment) @@ -305,7 +305,7 @@ feature "Commenting Budget::Investments" do end end - feature "Moderators" do + describe "Moderators" do scenario "can create comment as a moderator", :js do moderator = create(:moderator) @@ -361,7 +361,7 @@ feature "Commenting Budget::Investments" do end end - feature "Administrators" do + describe "Administrators" do scenario "can create comment as an administrator", :js do admin = create(:administrator) @@ -417,9 +417,9 @@ feature "Commenting Budget::Investments" do end end - feature "Voting comments" do + describe "Voting comments" do - background do + before do @manuela = create(:user, verified_at: Time.current) @pablo = create(:user) @investment = create(:budget_investment) diff --git a/spec/features/comments/budget_investments_valuation_spec.rb b/spec/features/comments/budget_investments_valuation_spec.rb index 1db3ab8be..4099b6524 100644 --- a/spec/features/comments/budget_investments_valuation_spec.rb +++ b/spec/features/comments/budget_investments_valuation_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Internal valuation comments on Budget::Investments" do +describe "Internal valuation comments on Budget::Investments" do let(:user) { create(:user) } let(:valuator_user) { create(:valuator).user } let(:admin_user) { create(:administrator).user } @@ -9,14 +9,14 @@ feature "Internal valuation comments on Budget::Investments" do let(:heading) { create(:budget_heading, group: group) } let(:investment) { create(:budget_investment, budget: budget, group: group, heading: heading) } - background do + before do investment.valuators << valuator_user.valuator login_as(valuator_user) end context "Show valuation comments" do context "Show valuation comments without public comments" do - background do + before do public_comment = create(:comment, commentable: investment, body: "Public comment") create(:comment, commentable: investment, author: valuator_user, body: "Public valuator comment") @@ -251,7 +251,7 @@ feature "Internal valuation comments on Budget::Investments" do end end - feature "Administrators" do + describe "Administrators" do scenario "can create valuation comment as an administrator", :js do login_as(admin_user) visit valuation_budget_budget_investment_path(budget, investment) diff --git a/spec/features/comments/debates_spec.rb b/spec/features/comments/debates_spec.rb index d42844c51..c8e17f170 100644 --- a/spec/features/comments/debates_spec.rb +++ b/spec/features/comments/debates_spec.rb @@ -1,7 +1,7 @@ require "rails_helper" include ActionView::Helpers::DateHelper -feature "Commenting debates" do +describe "Commenting debates" do let(:user) { create :user } let(:debate) { create :debate } @@ -154,7 +154,7 @@ feature "Commenting debates" do expect(page).to have_css(".comment", count: 2) end - feature "Not logged user" do + describe "Not logged user" do scenario "can not see comments forms" do create(:comment, commentable: debate) visit debate_path(debate) @@ -312,7 +312,7 @@ feature "Commenting debates" do expect(page).to have_content("Testing submit button!") end - feature "Moderators" do + describe "Moderators" do scenario "can create comment as a moderator", :js do moderator = create(:moderator) @@ -368,7 +368,7 @@ feature "Commenting debates" do end end - feature "Administrators" do + describe "Administrators" do scenario "can create comment as an administrator", :js do admin = create(:administrator) @@ -424,8 +424,8 @@ feature "Commenting debates" do end end - feature "Voting comments" do - background do + describe "Voting comments" do + before do @manuela = create(:user, verified_at: Time.current) @pablo = create(:user) @debate = create(:debate) diff --git a/spec/features/comments/legislation_annotations_spec.rb b/spec/features/comments/legislation_annotations_spec.rb index cfeda9a9a..f226cf529 100644 --- a/spec/features/comments/legislation_annotations_spec.rb +++ b/spec/features/comments/legislation_annotations_spec.rb @@ -1,7 +1,7 @@ require "rails_helper" include ActionView::Helpers::DateHelper -feature "Commenting legislation questions" do +describe "Commenting legislation questions" do let(:user) { create :user } let(:legislation_annotation) { create :legislation_annotation, author: user } @@ -186,7 +186,7 @@ feature "Commenting legislation questions" do expect(page).to have_css(".comment", count: 3) end - feature "Not logged user" do + describe "Not logged user" do scenario "can not see comments forms" do create(:comment, commentable: legislation_annotation) visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process, @@ -369,7 +369,7 @@ feature "Commenting legislation questions" do expect(page).to have_content("Testing submit button!") end - feature "Moderators" do + describe "Moderators" do scenario "can create comment as a moderator", :js do moderator = create(:moderator) @@ -432,7 +432,7 @@ feature "Commenting legislation questions" do end end - feature "Administrators" do + describe "Administrators" do scenario "can create comment as an administrator", :js do admin = create(:administrator) @@ -495,8 +495,8 @@ feature "Commenting legislation questions" do end end - feature "Voting comments" do - background do + describe "Voting comments" do + before do @manuela = create(:user, verified_at: Time.current) @pablo = create(:user) @legislation_annotation = create(:legislation_annotation) @@ -598,7 +598,7 @@ feature "Commenting legislation questions" do end end - feature "Merged comment threads", :js do + describe "Merged comment threads", :js do let!(:draft_version) { create(:legislation_draft_version, :published) } let!(:annotation1) do create(:legislation_annotation, draft_version: draft_version, text: "my annotation", @@ -609,7 +609,7 @@ feature "Commenting legislation questions" do ranges: [{"start" => "/p[1]", "startOffset" => 1, "end" => "/p[1]", "endOffset" => 10}]) end - background do + before do login_as user visit legislation_process_draft_version_path(draft_version.process, draft_version) diff --git a/spec/features/comments/legislation_questions_spec.rb b/spec/features/comments/legislation_questions_spec.rb index db707a626..67be1f55d 100644 --- a/spec/features/comments/legislation_questions_spec.rb +++ b/spec/features/comments/legislation_questions_spec.rb @@ -1,7 +1,7 @@ require "rails_helper" include ActionView::Helpers::DateHelper -feature "Commenting legislation questions" do +describe "Commenting legislation questions" do let(:user) { create :user, :level_two } let(:process) { create :legislation_process, :in_debate_phase } @@ -161,7 +161,7 @@ feature "Commenting legislation questions" do expect(page).to have_css(".comment", count: 2) end - feature "Not logged user" do + describe "Not logged user" do scenario "can not see comments forms" do create(:comment, commentable: legislation_question) visit legislation_process_question_path(legislation_question.process, legislation_question) @@ -335,7 +335,7 @@ feature "Commenting legislation questions" do expect(page).to have_content("Testing submit button!") end - feature "Moderators" do + describe "Moderators" do scenario "can create comment as a moderator", :js do moderator = create(:moderator) @@ -391,7 +391,7 @@ feature "Commenting legislation questions" do end end - feature "Administrators" do + describe "Administrators" do scenario "can create comment as an administrator", :js do admin = create(:administrator) @@ -447,8 +447,8 @@ feature "Commenting legislation questions" do end end - feature "Voting comments" do - background do + describe "Voting comments" do + before do @manuela = create(:user, verified_at: Time.current) @pablo = create(:user) @legislation_question = create(:legislation_question) diff --git a/spec/features/comments/polls_spec.rb b/spec/features/comments/polls_spec.rb index 7d7e63f98..1a4c20664 100644 --- a/spec/features/comments/polls_spec.rb +++ b/spec/features/comments/polls_spec.rb @@ -1,7 +1,7 @@ require "rails_helper" include ActionView::Helpers::DateHelper -feature "Commenting polls" do +describe "Commenting polls" do let(:user) { create :user } let(:poll) { create(:poll, author: create(:user)) } @@ -155,7 +155,7 @@ feature "Commenting polls" do expect(page).to have_css(".comment", count: 2) end - feature "Not logged user" do + describe "Not logged user" do scenario "can not see comments forms" do create(:comment, commentable: poll) visit poll_path(poll) @@ -307,7 +307,7 @@ feature "Commenting polls" do end end - feature "Moderators" do + describe "Moderators" do scenario "can create comment as a moderator", :js do skip "Feature not implemented yet, review soon" @@ -370,7 +370,7 @@ feature "Commenting polls" do end end - feature "Administrators" do + describe "Administrators" do scenario "can create comment as an administrator", :js do skip "Feature not implemented yet, review soon" @@ -432,9 +432,9 @@ feature "Commenting polls" do end end - feature "Voting comments" do + describe "Voting comments" do - background do + before do @manuela = create(:user, verified_at: Time.current) @pablo = create(:user) @poll = create(:poll) diff --git a/spec/features/comments/proposals_spec.rb b/spec/features/comments/proposals_spec.rb index 07c2cf1f7..d86b016a9 100644 --- a/spec/features/comments/proposals_spec.rb +++ b/spec/features/comments/proposals_spec.rb @@ -1,7 +1,7 @@ require "rails_helper" include ActionView::Helpers::DateHelper -feature "Commenting proposals" do +describe "Commenting proposals" do let(:user) { create :user } let(:proposal) { create :proposal } @@ -153,7 +153,7 @@ feature "Commenting proposals" do expect(page).to have_css(".comment", count: 2) end - feature "Not logged user" do + describe "Not logged user" do scenario "can not see comments forms" do create(:comment, commentable: proposal) visit proposal_path(proposal) @@ -299,7 +299,7 @@ feature "Commenting proposals" do end end - feature "Moderators" do + describe "Moderators" do scenario "can create comment as a moderator", :js do moderator = create(:moderator) @@ -355,7 +355,7 @@ feature "Commenting proposals" do end end - feature "Administrators" do + describe "Administrators" do scenario "can create comment as an administrator", :js do admin = create(:administrator) @@ -411,9 +411,8 @@ feature "Commenting proposals" do end end - feature "Voting comments" do - - background do + describe "Voting comments" do + before do @manuela = create(:user, verified_at: Time.current) @pablo = create(:user) @proposal = create(:proposal) diff --git a/spec/features/comments/topics_spec.rb b/spec/features/comments/topics_spec.rb index 5fe47e50b..b6b918055 100644 --- a/spec/features/comments/topics_spec.rb +++ b/spec/features/comments/topics_spec.rb @@ -1,7 +1,7 @@ require "rails_helper" include ActionView::Helpers::DateHelper -feature "Commenting topics from proposals" do +describe "Commenting topics from proposals" do let(:user) { create :user } let(:proposal) { create :proposal } @@ -166,7 +166,7 @@ feature "Commenting topics from proposals" do expect(page).to have_css(".comment", count: 2) end - feature "Not logged user" do + describe "Not logged user" do scenario "can not see comments forms" do community = proposal.community topic = create(:topic, community: community) @@ -336,7 +336,7 @@ feature "Commenting topics from proposals" do end end - feature "Moderators" do + describe "Moderators" do scenario "can create comment as a moderator", :js do community = proposal.community topic = create(:topic, community: community) @@ -398,7 +398,7 @@ feature "Commenting topics from proposals" do end end - feature "Administrators" do + describe "Administrators" do scenario "can create comment as an administrator", :js do community = proposal.community topic = create(:topic, community: community) @@ -460,9 +460,8 @@ feature "Commenting topics from proposals" do end end - feature "Voting comments" do - - background do + describe "Voting comments" do + before do @manuela = create(:user, verified_at: Time.current) @pablo = create(:user) @proposal = create(:proposal) @@ -555,7 +554,7 @@ feature "Commenting topics from proposals" do end -feature "Commenting topics from budget investments" do +describe "Commenting topics from budget investments" do let(:user) { create :user } let(:investment) { create :budget_investment } @@ -720,7 +719,7 @@ feature "Commenting topics from budget investments" do expect(page).to have_css(".comment", count: 2) end - feature "Not logged user" do + describe "Not logged user" do scenario "can not see comments forms" do community = investment.community topic = create(:topic, community: community) @@ -890,7 +889,7 @@ feature "Commenting topics from budget investments" do end end - feature "Moderators" do + describe "Moderators" do scenario "can create comment as a moderator", :js do community = investment.community topic = create(:topic, community: community) @@ -952,7 +951,7 @@ feature "Commenting topics from budget investments" do end end - feature "Administrators" do + describe "Administrators" do scenario "can create comment as an administrator", :js do community = investment.community topic = create(:topic, community: community) @@ -1014,9 +1013,8 @@ feature "Commenting topics from budget investments" do end end - feature "Voting comments" do - - background do + describe "Voting comments" do + before do @manuela = create(:user, verified_at: Time.current) @pablo = create(:user) @investment = create(:budget_investment) diff --git a/spec/features/communities_spec.rb b/spec/features/communities_spec.rb index 1c54aa681..6f76d7acd 100644 --- a/spec/features/communities_spec.rb +++ b/spec/features/communities_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Communities" do +describe "Communities" do - background do + before do Setting["feature.community"] = true end diff --git a/spec/features/dashboard/dashboard_spec.rb b/spec/features/dashboard/dashboard_spec.rb index a691d081e..34fdd7e38 100644 --- a/spec/features/dashboard/dashboard_spec.rb +++ b/spec/features/dashboard/dashboard_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Proposal's dashboard" do +describe "Proposal's dashboard" do let!(:proposal) { create(:proposal, :draft) } before do diff --git a/spec/features/dashboard/mailing_spec.rb b/spec/features/dashboard/mailing_spec.rb index de54860ef..f890b8d60 100644 --- a/spec/features/dashboard/mailing_spec.rb +++ b/spec/features/dashboard/mailing_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Mailing" do +describe "Mailing" do let!(:proposal) { create(:proposal, :draft) } before do diff --git a/spec/features/dashboard/polls_spec.rb b/spec/features/dashboard/polls_spec.rb index 0164ba4e3..d9e57a589 100644 --- a/spec/features/dashboard/polls_spec.rb +++ b/spec/features/dashboard/polls_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Polls" do +describe "Polls" do let!(:proposal) { create(:proposal, :draft) } before do diff --git a/spec/features/dashboard/poster_spec.rb b/spec/features/dashboard/poster_spec.rb index 83e1f148e..5f8deb1b7 100644 --- a/spec/features/dashboard/poster_spec.rb +++ b/spec/features/dashboard/poster_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Poster" do +describe "Poster" do let!(:proposal) { create(:proposal, :draft) } before do diff --git a/spec/features/debates_spec.rb b/spec/features/debates_spec.rb index 2424597cf..c65483c6d 100644 --- a/spec/features/debates_spec.rb +++ b/spec/features/debates_spec.rb @@ -1,7 +1,7 @@ # coding: utf-8 require "rails_helper" -feature "Debates" do +describe "Debates" do scenario "Disabled with a feature flag" do Setting["process.debates"] = nil @@ -374,7 +374,7 @@ feature "Debates" do expect(Flag.flagged?(user, debate)).not_to be end - feature "Debate index order filters" do + describe "Debate index order filters" do scenario "Default order is hot_score", :js do best_debate = create(:debate, title: "Best") @@ -437,7 +437,7 @@ feature "Debates" do let!(:medium_debate) { create(:debate, title: "Medium", cached_votes_total: 5, tag_list: "Sport") } let!(:worst_debate) { create(:debate, title: "Worst", cached_votes_total: 1, tag_list: "Sport") } - background do + before do Setting["feature.user.recommendations"] = true Setting["feature.user.recommendations_on_debates"] = true end @@ -1035,7 +1035,7 @@ feature "Debates" do context "By geozone" do - background do + before do @california = Geozone.create(name: "California") @new_york = Geozone.create(name: "New York") diff --git a/spec/features/direct_messages_spec.rb b/spec/features/direct_messages_spec.rb index 1b1704087..c64d56d5a 100644 --- a/spec/features/direct_messages_spec.rb +++ b/spec/features/direct_messages_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Direct messages" do +describe "Direct messages" do - background do + before do Setting[:direct_message_max_per_day] = 3 end diff --git a/spec/features/emails_spec.rb b/spec/features/emails_spec.rb index 94904695a..852156a08 100644 --- a/spec/features/emails_spec.rb +++ b/spec/features/emails_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Emails" do +describe "Emails" do - background do + before do reset_mailer end @@ -379,7 +379,7 @@ feature "Emails" do context "Budgets" do - background do + before do Setting["process.budgets"] = true end diff --git a/spec/features/help_page_spec.rb b/spec/features/help_page_spec.rb index 2efe7aa9f..22c305493 100644 --- a/spec/features/help_page_spec.rb +++ b/spec/features/help_page_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Help page" do +describe "Help page" do context "Index" do diff --git a/spec/features/home_spec.rb b/spec/features/home_spec.rb index 08186c217..108d55678 100644 --- a/spec/features/home_spec.rb +++ b/spec/features/home_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Home" do +describe "Home" do context "For not logged users" do @@ -22,9 +22,9 @@ feature "Home" do context "For signed in users" do - feature "Recommended" do + describe "Recommended" do - background do + before do Setting["feature.user.recommendations"] = true user = create(:user) proposal = create(:proposal, tag_list: "Sport") @@ -111,7 +111,7 @@ feature "Home" do end - feature "IE alert" do + describe "IE alert" do scenario "IE visitors are presented with an alert until they close it", :page_driver do # Selenium API does not include page request/response inspection methods # so we must use Capybara::RackTest driver to set the browser's headers diff --git a/spec/features/legislation/draft_versions_spec.rb b/spec/features/legislation/draft_versions_spec.rb index fccdc3900..d43256ea2 100644 --- a/spec/features/legislation/draft_versions_spec.rb +++ b/spec/features/legislation/draft_versions_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Legislation Draft Versions" do +describe "Legislation Draft Versions" do let(:user) { create(:user) } let(:administrator) do create(:administrator, user: user) @@ -143,7 +143,7 @@ feature "Legislation Draft Versions" do context "Annotations", :js do let(:user) { create(:user) } - background { login_as user } + before { login_as user } scenario "Visit as anonymous" do logout @@ -222,7 +222,7 @@ feature "Legislation Draft Versions" do let(:user) { create(:user) } - background { login_as user } + before { login_as user } scenario "View annotations and comments in an included range" do draft_version = create(:legislation_draft_version, :published) @@ -246,7 +246,7 @@ feature "Legislation Draft Versions" do end context "Annotations page" do - background do + before do @draft_version = create(:legislation_draft_version, :published) create(:legislation_annotation, draft_version: @draft_version, text: "my annotation", quote: "ipsum", ranges: [{"start" => "/p[1]", "startOffset" => 6, "end" => "/p[1]", "endOffset" => 11}]) @@ -262,7 +262,7 @@ feature "Legislation Draft Versions" do end context "switching versions" do - background do + before do @process = create(:legislation_process) @draft_version_1 = create(:legislation_draft_version, :published, process: @process, title: "Version 1", body: "Text with quote for version 1") @@ -298,7 +298,7 @@ feature "Legislation Draft Versions" do end context "Annotation comments page" do - background do + before do @draft_version = create(:legislation_draft_version, :published) create(:legislation_annotation, draft_version: @draft_version, text: "my annotation", quote: "ipsum", ranges: [{"start" => "/p[1]", "startOffset" => 6, "end" => "/p[1]", "endOffset" => 11}]) diff --git a/spec/features/legislation/processes_spec.rb b/spec/features/legislation/processes_spec.rb index fca4fdcaf..248c3c446 100644 --- a/spec/features/legislation/processes_spec.rb +++ b/spec/features/legislation/processes_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Legislation" do +describe "Legislation" do let!(:administrator) { create(:administrator).user } diff --git a/spec/features/legislation/proposals_spec.rb b/spec/features/legislation/proposals_spec.rb index c2d516c92..91af4b109 100644 --- a/spec/features/legislation/proposals_spec.rb +++ b/spec/features/legislation/proposals_spec.rb @@ -1,7 +1,7 @@ require "rails_helper" require "sessions_helper" -feature "Legislation Proposals" do +describe "Legislation Proposals" do let(:user) { create(:user) } let(:user2) { create(:user) } @@ -20,7 +20,7 @@ feature "Legislation Proposals" do end end - feature "Random pagination" do + describe "Random pagination" do before do allow(Legislation::Proposal).to receive(:default_per_page).and_return(12) diff --git a/spec/features/legislation/questions_spec.rb b/spec/features/legislation/questions_spec.rb index 8cb46a020..eae324e22 100644 --- a/spec/features/legislation/questions_spec.rb +++ b/spec/features/legislation/questions_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Legislation" do +describe "Legislation" do context "process debate page" do before do @process = create(:legislation_process, debate_start_date: Date.current - 3.days, debate_end_date: Date.current + 2.days) diff --git a/spec/features/localization_spec.rb b/spec/features/localization_spec.rb index 7094b0394..287cdfb5b 100644 --- a/spec/features/localization_spec.rb +++ b/spec/features/localization_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Localization" do +describe "Localization" do scenario "Wrong locale" do Globalize.with_locale(:es) do diff --git a/spec/features/management/account_spec.rb b/spec/features/management/account_spec.rb index 9e65781d5..43a439a81 100644 --- a/spec/features/management/account_spec.rb +++ b/spec/features/management/account_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Account" do +describe "Account" do - background do + before do login_as_manager end diff --git a/spec/features/management/budget_investments_spec.rb b/spec/features/management/budget_investments_spec.rb index c482b6be7..efb00d12f 100644 --- a/spec/features/management/budget_investments_spec.rb +++ b/spec/features/management/budget_investments_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Budget Investments" do +describe "Budget Investments" do let(:manager) { create(:manager) } let(:budget) { create(:budget, phase: "selecting", name: "2033") } diff --git a/spec/features/management/document_verifications_spec.rb b/spec/features/management/document_verifications_spec.rb index b02cbfbfc..3e1dcc67c 100644 --- a/spec/features/management/document_verifications_spec.rb +++ b/spec/features/management/document_verifications_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "DocumentVerifications" do +describe "DocumentVerifications" do - background do + before do login_as_manager end diff --git a/spec/features/management/email_verifications_spec.rb b/spec/features/management/email_verifications_spec.rb index 79f86bfc0..7de10c253 100644 --- a/spec/features/management/email_verifications_spec.rb +++ b/spec/features/management/email_verifications_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "EmailVerifications" do +describe "EmailVerifications" do scenario "Verifying a level 1 user via email" do login_as_manager diff --git a/spec/features/management/localization_spec.rb b/spec/features/management/localization_spec.rb index d55a67168..e741ddc27 100644 --- a/spec/features/management/localization_spec.rb +++ b/spec/features/management/localization_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Localization" do +describe "Localization" do - background do + before do login_as_manager end diff --git a/spec/features/management/managed_users_spec.rb b/spec/features/management/managed_users_spec.rb index 360c28caa..3fa0478ac 100644 --- a/spec/features/management/managed_users_spec.rb +++ b/spec/features/management/managed_users_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Managed User" do +describe "Managed User" do - background do + before do login_as_manager end diff --git a/spec/features/management/proposals_spec.rb b/spec/features/management/proposals_spec.rb index 6e17e1dfc..3f3ef2840 100644 --- a/spec/features/management/proposals_spec.rb +++ b/spec/features/management/proposals_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Proposals" do +describe "Proposals" do - background do + before do login_as_manager end diff --git a/spec/features/management/users_spec.rb b/spec/features/management/users_spec.rb index 38891eb14..929828b96 100644 --- a/spec/features/management/users_spec.rb +++ b/spec/features/management/users_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Users" do +describe "Users" do - background do + before do login_as_manager end diff --git a/spec/features/management_spec.rb b/spec/features/management_spec.rb index 4a5fd426f..9098b13f6 100644 --- a/spec/features/management_spec.rb +++ b/spec/features/management_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Management" do +describe "Management" do let(:user) { create(:user) } scenario "Should show admin menu if logged user is admin" do diff --git a/spec/features/moderation/budget_investments_spec.rb b/spec/features/moderation/budget_investments_spec.rb index 79aac76b5..2d8bcc4c8 100644 --- a/spec/features/moderation/budget_investments_spec.rb +++ b/spec/features/moderation/budget_investments_spec.rb @@ -1,12 +1,12 @@ require "rails_helper" -feature "Moderate budget investments" do +describe "Moderate budget investments" do let(:budget) { create(:budget) } let(:group) { create(:budget_group, name: "Culture", budget: budget) } let(:heading) { create(:budget_heading, name: "More libraries", price: 666666, group: group) } - background do + before do @mod = create(:moderator) @investment = create(:budget_investment, heading: heading, author: create(:user)) end @@ -56,16 +56,16 @@ feature "Moderate budget investments" do end end - feature "/moderation/ screen" do + describe "/moderation/ screen" do - background do + before do login_as(@mod.user) end - feature "moderate in bulk" do - feature "When an investment has been selected for moderation" do + describe "moderate in bulk" do + describe "When an investment has been selected for moderation" do - background do + before do visit moderation_budget_investments_path within(".menu.simple") do diff --git a/spec/features/moderation/comments_spec.rb b/spec/features/moderation/comments_spec.rb index 2a0c65b6d..366a2fc4d 100644 --- a/spec/features/moderation/comments_spec.rb +++ b/spec/features/moderation/comments_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Moderate comments" do +describe "Moderate comments" do scenario "Hide", :js do citizen = create(:user) @@ -63,16 +63,16 @@ feature "Moderate comments" do expect(page).to have_content("This is SPAM comment on proposal") end - feature "/moderation/ screen" do + describe "/moderation/ screen" do - background do + before do moderator = create(:moderator) login_as(moderator.user) end - feature "moderate in bulk" do - feature "When a comment has been selected for moderation" do - background do + describe "moderate in bulk" do + describe "When a comment has been selected for moderation" do + before do @comment = create(:comment) visit moderation_comments_path within(".menu.simple") do diff --git a/spec/features/moderation/debates_spec.rb b/spec/features/moderation/debates_spec.rb index bcf32e065..a3d213b5e 100644 --- a/spec/features/moderation/debates_spec.rb +++ b/spec/features/moderation/debates_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Moderate debates" do +describe "Moderate debates" do scenario "Disabled with a feature flag" do Setting["process.debates"] = nil @@ -44,16 +44,16 @@ feature "Moderate debates" do end end - feature "/moderation/ screen" do + describe "/moderation/ screen" do - background do + before do moderator = create(:moderator) login_as(moderator.user) end - feature "moderate in bulk" do - feature "When a debate has been selected for moderation" do - background do + describe "moderate in bulk" do + describe "When a debate has been selected for moderation" do + before do @debate = create(:debate) visit moderation_debates_path within(".menu.simple") do diff --git a/spec/features/moderation/proposal_notifications_spec.rb b/spec/features/moderation/proposal_notifications_spec.rb index c6d6252d7..1f9b17b93 100644 --- a/spec/features/moderation/proposal_notifications_spec.rb +++ b/spec/features/moderation/proposal_notifications_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Moderate proposal notifications" do +describe "Moderate proposal notifications" do scenario "Hide", :js do citizen = create(:user) @@ -39,16 +39,16 @@ feature "Moderate proposal notifications" do end end - feature "/moderation/ screen" do + describe "/moderation/ screen" do - background do + before do moderator = create(:moderator) login_as(moderator.user) end - feature "moderate in bulk" do - feature "When a proposal has been selected for moderation" do - background do + describe "moderate in bulk" do + describe "When a proposal has been selected for moderation" do + before do proposal = create(:proposal) @proposal_notification = create(:proposal_notification, proposal: proposal, created_at: Date.current - 4.days) visit moderation_proposal_notifications_path diff --git a/spec/features/moderation/proposals_spec.rb b/spec/features/moderation/proposals_spec.rb index 513baf0b8..3bb443699 100644 --- a/spec/features/moderation/proposals_spec.rb +++ b/spec/features/moderation/proposals_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Moderate proposals" do +describe "Moderate proposals" do scenario "Disabled with a feature flag" do Setting["process.proposals"] = nil @@ -43,16 +43,16 @@ feature "Moderate proposals" do end end - feature "/moderation/ screen" do + describe "/moderation/ screen" do - background do + before do moderator = create(:moderator) login_as(moderator.user) end - feature "moderate in bulk" do - feature "When a proposal has been selected for moderation" do - background do + describe "moderate in bulk" do + describe "When a proposal has been selected for moderation" do + before do @proposal = create(:proposal) visit moderation_proposals_path within(".menu.simple") do diff --git a/spec/features/moderation/users_spec.rb b/spec/features/moderation/users_spec.rb index 3fd0255f7..6fc04cff2 100644 --- a/spec/features/moderation/users_spec.rb +++ b/spec/features/moderation/users_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Moderate users" do +describe "Moderate users" do scenario "Hide" do citizen = create(:user) diff --git a/spec/features/moderation_spec.rb b/spec/features/moderation_spec.rb index 455a98fa1..690e88a9f 100644 --- a/spec/features/moderation_spec.rb +++ b/spec/features/moderation_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Moderation" do +describe "Moderation" do let(:user) { create(:user) } scenario "Access as regular user is not authorized" do @@ -94,7 +94,7 @@ feature "Moderation" do end context "Moderation dashboard" do - background do + before do Setting["org_name"] = "OrgName" end diff --git a/spec/features/notifications_spec.rb b/spec/features/notifications_spec.rb index 1702bf943..a1296409e 100644 --- a/spec/features/notifications_spec.rb +++ b/spec/features/notifications_spec.rb @@ -1,10 +1,10 @@ require "rails_helper" -feature "Notifications" do +describe "Notifications" do let(:user) { create :user } - background do + before do login_as(user) visit root_path end diff --git a/spec/features/official_positions_spec.rb b/spec/features/official_positions_spec.rb index 8eeda2038..bc4aaacef 100644 --- a/spec/features/official_positions_spec.rb +++ b/spec/features/official_positions_spec.rb @@ -1,10 +1,10 @@ require "rails_helper" -feature "Official positions" do +describe "Official positions" do context "Badge" do - background do + before do @user1 = create(:user, official_level: 1, official_position: "Employee", official_position_badge: true) @user2 = create(:user, official_level: 0, official_position: "") end @@ -22,7 +22,7 @@ feature "Official positions" do context "Debates" do - background do + before do @debate1 = create(:debate, author: @user1) @debate2 = create(:debate, author: @user2) end @@ -46,7 +46,7 @@ feature "Official positions" do context "Proposals" do - background do + before do @proposal1 = create(:proposal, author: @user1) @proposal2 = create(:proposal, author: @user2) @@ -72,7 +72,7 @@ feature "Official positions" do context "Spending proposals" do - background do + before do Setting["feature.spending_proposals"] = true @spending_proposal1 = create(:spending_proposal, author: @user1) @spending_proposal2 = create(:spending_proposal, author: @user2) diff --git a/spec/features/officing/booth_spec.rb b/spec/features/officing/booth_spec.rb index 72eddbdbc..b26e2f0c4 100644 --- a/spec/features/officing/booth_spec.rb +++ b/spec/features/officing/booth_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Booth", :with_frozen_time do +describe "Booth", :with_frozen_time do scenario "Officer with no booth assignments today" do officer = create(:poll_officer) diff --git a/spec/features/officing/residence_spec.rb b/spec/features/officing/residence_spec.rb index 3908fa546..475835523 100644 --- a/spec/features/officing/residence_spec.rb +++ b/spec/features/officing/residence_spec.rb @@ -1,9 +1,9 @@ require "rails_helper" -feature "Residence", :with_frozen_time do +describe "Residence", :with_frozen_time do let(:officer) { create(:poll_officer) } - feature "Officers without assignments" do + describe "Officers without assignments" do scenario "Can not access residence verification" do login_as(officer.user) @@ -21,9 +21,9 @@ feature "Residence", :with_frozen_time do end - feature "Assigned officers" do + describe "Assigned officers" do - background do + before do create(:poll_officer_assignment, officer: officer) login_through_form_as_officer(officer.user) visit officing_root_path diff --git a/spec/features/officing/results_spec.rb b/spec/features/officing/results_spec.rb index 7ce642e8d..75644fbfe 100644 --- a/spec/features/officing/results_spec.rb +++ b/spec/features/officing/results_spec.rb @@ -1,11 +1,11 @@ require "rails_helper" -feature "Officing Results", :with_frozen_time do +describe "Officing Results", :with_frozen_time do let(:poll) { create(:poll, ends_at: 1.day.ago) } let(:booth) { create(:poll_booth) } let(:poll_officer) { create(:poll_officer) } - background do + before do create(:poll_booth_assignment, poll: poll, booth: booth) create(:poll_shift, :recount_scrutiny_task, officer: poll_officer, booth: booth, date: Date.current) @question_1 = create(:poll_question, poll: poll) diff --git a/spec/features/officing/voters_spec.rb b/spec/features/officing/voters_spec.rb index 2f21234e7..10f984e90 100644 --- a/spec/features/officing/voters_spec.rb +++ b/spec/features/officing/voters_spec.rb @@ -1,12 +1,12 @@ require "rails_helper" -feature "Voters" do +describe "Voters" do let(:poll) { create(:poll, :current) } let(:booth) { create(:poll_booth) } let(:officer) { create(:poll_officer) } - background do + before do login_as(officer.user) create(:geozone, :in_census) create(:poll_shift, officer: officer, booth: booth, date: Date.current, task: :vote_collection) diff --git a/spec/features/officing_spec.rb b/spec/features/officing_spec.rb index 9a8bc3f26..10c600238 100644 --- a/spec/features/officing_spec.rb +++ b/spec/features/officing_spec.rb @@ -1,7 +1,7 @@ require "rails_helper" require "sessions_helper" -feature "Poll Officing" do +describe "Poll Officing" do let(:user) { create(:user) } scenario "Access as regular user is not authorized" do diff --git a/spec/features/organizations_spec.rb b/spec/features/organizations_spec.rb index c68df84e4..601ae9d1e 100644 --- a/spec/features/organizations_spec.rb +++ b/spec/features/organizations_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Organizations" do +describe "Organizations" do scenario "Organizations can be created" do user = User.organizations.where(email: "green@peace.com").first diff --git a/spec/features/polls/answers_spec.rb b/spec/features/polls/answers_spec.rb index e500e15ed..67d46fb16 100644 --- a/spec/features/polls/answers_spec.rb +++ b/spec/features/polls/answers_spec.rb @@ -1,11 +1,11 @@ require "rails_helper" -feature "Answers" do +describe "Answers" do let(:question) { create(:poll_question) } let(:admin) { create(:administrator) } - background do + before do login_as(admin.user) end diff --git a/spec/features/polls/polls_spec.rb b/spec/features/polls/polls_spec.rb index 12ff3eb93..b0d968448 100644 --- a/spec/features/polls/polls_spec.rb +++ b/spec/features/polls/polls_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Polls" do +describe "Polls" do context "Concerns" do it_behaves_like "notifiable in-app", Poll diff --git a/spec/features/polls/questions_spec.rb b/spec/features/polls/questions_spec.rb index 4af4f9785..1c067f192 100644 --- a/spec/features/polls/questions_spec.rb +++ b/spec/features/polls/questions_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Poll Questions" do +describe "Poll Questions" do scenario "Lists questions from proposals before regular questions" do poll = create(:poll) diff --git a/spec/features/polls/results_spec.rb b/spec/features/polls/results_spec.rb index 99236849a..8ad18748a 100644 --- a/spec/features/polls/results_spec.rb +++ b/spec/features/polls/results_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Poll Results" do +describe "Poll Results" do scenario "List each Poll question", :js do user1 = create(:user, :level_two) user2 = create(:user, :level_two) diff --git a/spec/features/polls/voter_spec.rb b/spec/features/polls/voter_spec.rb index 9310c2438..2365d9345 100644 --- a/spec/features/polls/voter_spec.rb +++ b/spec/features/polls/voter_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Voter" do +describe "Voter" do context "Origin", :with_frozen_time do @@ -12,7 +12,7 @@ feature "Voter" do let!(:answer_yes) { create(:poll_question_answer, question: question, title: "Yes") } let!(:answer_no) { create(:poll_question_answer, question: question, title: "No") } - background do + before do create(:geozone, :in_census) create(:poll_shift, officer: officer, booth: booth, date: Date.current, task: :vote_collection) booth_assignment = create(:poll_booth_assignment, poll: poll, booth: booth) diff --git a/spec/features/proposal_ballots_spec.rb b/spec/features/proposal_ballots_spec.rb index d67585a7c..62de85e7b 100644 --- a/spec/features/proposal_ballots_spec.rb +++ b/spec/features/proposal_ballots_spec.rb @@ -1,7 +1,7 @@ # coding: utf-8 require "rails_helper" -feature "Proposal ballots" do +describe "Proposal ballots" do scenario "Successful proposals do not show support buttons in index" do successful_proposals = create_successful_proposals diff --git a/spec/features/proposal_notifications_spec.rb b/spec/features/proposal_notifications_spec.rb index 089138e21..6b12286f3 100644 --- a/spec/features/proposal_notifications_spec.rb +++ b/spec/features/proposal_notifications_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Proposal Notifications" do +describe "Proposal Notifications" do scenario "Send a notification" do author = create(:user) @@ -363,7 +363,7 @@ feature "Proposal Notifications" do context "Group notifications" do - background do + before do Setting[:proposal_notification_minimum_interval_in_days] = 0 end diff --git a/spec/features/proposals_spec.rb b/spec/features/proposals_spec.rb index 5162dae30..db3850dd7 100644 --- a/spec/features/proposals_spec.rb +++ b/spec/features/proposals_spec.rb @@ -1,7 +1,7 @@ # coding: utf-8 require "rails_helper" -feature "Proposals" do +describe "Proposals" do it_behaves_like "milestoneable", :proposal, @@ -646,7 +646,7 @@ feature "Proposals" do expect(page).to have_content error_message end - feature "Proposal index order filters" do + describe "Proposal index order filters" do scenario "Default order is hot_score", :js do create_featured_proposals @@ -831,7 +831,7 @@ feature "Proposals" do end end - feature "Archived proposals" do + describe "Archived proposals" do scenario "show on archived tab" do create_featured_proposals @@ -1556,7 +1556,7 @@ feature "Proposals" do context "By geozone" do - background do + before do @california = Geozone.create(name: "California") @new_york = Geozone.create(name: "New York") @@ -1745,7 +1745,7 @@ feature "Proposals" do end -feature "Successful proposals" do +describe "Successful proposals" do scenario "Successful proposals do not show support buttons in index" do successful_proposals = create_successful_proposals diff --git a/spec/features/registration_form_spec.rb b/spec/features/registration_form_spec.rb index b7c0a6385..3f6faaa35 100644 --- a/spec/features/registration_form_spec.rb +++ b/spec/features/registration_form_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Registration form" do +describe "Registration form" do scenario "username is not available", :js do user = create(:user) diff --git a/spec/features/sessions_spec.rb b/spec/features/sessions_spec.rb index 968dd6a6e..5e0dd0b09 100644 --- a/spec/features/sessions_spec.rb +++ b/spec/features/sessions_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Sessions" do +describe "Sessions" do scenario "Staying in the same page after doing login/logout" do user = create(:user, sign_in_count: 10) diff --git a/spec/features/site_customization/content_blocks_spec.rb b/spec/features/site_customization/content_blocks_spec.rb index 3919ee429..1af8f571e 100644 --- a/spec/features/site_customization/content_blocks_spec.rb +++ b/spec/features/site_customization/content_blocks_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Custom content blocks" do +describe "Custom content blocks" do scenario "top links" do create(:site_customization_content_block, name: "top_links", locale: "en", body: "content for top links") diff --git a/spec/features/site_customization/custom_pages_spec.rb b/spec/features/site_customization/custom_pages_spec.rb index 6a797fa5a..2f1a70755 100644 --- a/spec/features/site_customization/custom_pages_spec.rb +++ b/spec/features/site_customization/custom_pages_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Custom Pages" do +describe "Custom Pages" do context "New custom page" do context "Draft" do diff --git a/spec/features/site_customization/information_texts_spec.rb b/spec/features/site_customization/information_texts_spec.rb index 297e27e01..6e394eb65 100644 --- a/spec/features/site_customization/information_texts_spec.rb +++ b/spec/features/site_customization/information_texts_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Custom information texts" do +describe "Custom information texts" do scenario "Show custom texts instead of default ones" do admin = create(:administrator) diff --git a/spec/features/social_media_meta_tags_spec.rb b/spec/features/social_media_meta_tags_spec.rb index b002113a6..50c0cd012 100644 --- a/spec/features/social_media_meta_tags_spec.rb +++ b/spec/features/social_media_meta_tags_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Social media meta tags" do +describe "Social media meta tags" do context "Setting social media meta tags" do diff --git a/spec/features/stats_spec.rb b/spec/features/stats_spec.rb index f14efea9a..a16e63aab 100644 --- a/spec/features/stats_spec.rb +++ b/spec/features/stats_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Stats" do +describe "Stats" do context "Summary" do diff --git a/spec/features/tags/budget_investments_spec.rb b/spec/features/tags/budget_investments_spec.rb index 940c98c67..a0fb60339 100644 --- a/spec/features/tags/budget_investments_spec.rb +++ b/spec/features/tags/budget_investments_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Tags" do +describe "Tags" do let(:author) { create(:user, :level_two, username: "Isabel") } let(:budget) { create(:budget, name: "Big Budget") } diff --git a/spec/features/tags/debates_spec.rb b/spec/features/tags/debates_spec.rb index 281b59608..ba582a294 100644 --- a/spec/features/tags/debates_spec.rb +++ b/spec/features/tags/debates_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Tags" do +describe "Tags" do scenario "Index" do earth = create(:debate, tag_list: "Medio Ambiente") diff --git a/spec/features/tags/proposals_spec.rb b/spec/features/tags/proposals_spec.rb index a0e1cd690..d471b01e0 100644 --- a/spec/features/tags/proposals_spec.rb +++ b/spec/features/tags/proposals_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Tags" do +describe "Tags" do scenario "Index" do create_featured_proposals diff --git a/spec/features/tags_spec.rb b/spec/features/tags_spec.rb index 16e26d9f6..1b349819c 100644 --- a/spec/features/tags_spec.rb +++ b/spec/features/tags_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Tags" do +describe "Tags" do scenario "Index" do earth = create(:debate, tag_list: "Medio Ambiente") diff --git a/spec/features/topics_specs.rb b/spec/features/topics_specs.rb index 6af83bb2e..6e88dc8ae 100644 --- a/spec/features/topics_specs.rb +++ b/spec/features/topics_specs.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Topics" do +describe "Topics" do context "Concerns" do it_behaves_like "notifiable in-app", Topic diff --git a/spec/features/tracks_spec.rb b/spec/features/tracks_spec.rb index 073c2af59..70538cb03 100644 --- a/spec/features/tracks_spec.rb +++ b/spec/features/tracks_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Tracking" do +describe "Tracking" do context "Custom variable" do diff --git a/spec/features/user_invites_spec.rb b/spec/features/user_invites_spec.rb index ab439c1d5..5e15cd222 100644 --- a/spec/features/user_invites_spec.rb +++ b/spec/features/user_invites_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "User invites" do +describe "User invites" do - background do + before do login_as_manager end diff --git a/spec/features/users_auth_spec.rb b/spec/features/users_auth_spec.rb index 7c7a1222f..be4d5409e 100644 --- a/spec/features/users_auth_spec.rb +++ b/spec/features/users_auth_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Users" do +describe "Users" do context "Regular authentication" do context "Sign up" do diff --git a/spec/features/users_spec.rb b/spec/features/users_spec.rb index 5e371a8bd..781b55c68 100644 --- a/spec/features/users_spec.rb +++ b/spec/features/users_spec.rb @@ -1,10 +1,10 @@ require "rails_helper" -feature "Users" do +describe "Users" do - feature "Show (public page)" do + describe "Show (public page)" do - background do + before do @user = create(:user) 1.times {create(:debate, author: @user)} 2.times {create(:proposal, author: @user)} @@ -137,8 +137,8 @@ feature "Users" do end - feature "Public activity" do - background do + describe "Public activity" do + before do @user = create(:user) end @@ -201,9 +201,9 @@ feature "Users" do expect(page).not_to have_content("activity list private") end - feature "User email" do + describe "User email" do - background do + before do @user = create(:user) end @@ -234,8 +234,8 @@ feature "Users" do end - feature "Public interests" do - background do + describe "Public interests" do + before do @user = create(:user) end @@ -366,7 +366,7 @@ feature "Users" do end end - feature "Special comments" do + describe "Special comments" do scenario "comments posted as moderator are not visible in user activity" do moderator = create(:administrator).user @@ -419,7 +419,7 @@ feature "Users" do end end - feature "Following (public page)" do + describe "Following (public page)" do before do @user = create(:user) diff --git a/spec/features/valuation/budget_investments_spec.rb b/spec/features/valuation/budget_investments_spec.rb index fa918b500..03b843e03 100644 --- a/spec/features/valuation/budget_investments_spec.rb +++ b/spec/features/valuation/budget_investments_spec.rb @@ -1,13 +1,13 @@ require "rails_helper" -feature "Valuation budget investments" do +describe "Valuation budget investments" do let(:budget) { create(:budget, :valuating) } let(:valuator) do create(:valuator, user: create(:user, username: "Rachel", email: "rachel@valuators.org")) end - background do + before do login_as(valuator.user) end @@ -23,7 +23,7 @@ feature "Valuation budget investments" do expect(page).to have_link "Valuation", href: valuation_root_path end - feature "Index" do + describe "Index" do scenario "Index shows budget investments assigned to current valuator" do investment1 = create(:budget_investment, :visible_to_valuators, budget: budget) investment2 = create(:budget_investment, :visible_to_valuators, budget: budget) @@ -209,7 +209,7 @@ feature "Valuation budget investments" do end end - feature "Show" do + describe "Show" do let(:administrator) do create(:administrator, user: create(:user, username: "Ana", email: "ana@admins.org")) end @@ -222,7 +222,7 @@ feature "Valuation budget investments" do administrator: administrator,) end - background do + before do investment.valuators << [valuator, second_valuator] end @@ -280,7 +280,7 @@ feature "Valuation budget investments" do end - feature "Valuate" do + describe "Valuate" do let(:admin) { create(:administrator) } let(:investment) do group = create(:budget_group, budget: budget) @@ -289,7 +289,7 @@ feature "Valuation budget investments" do administrator: admin) end - background do + before do investment.valuators << valuator end @@ -427,7 +427,7 @@ feature "Valuation budget investments" do end context "Reopen valuation" do - background do + before do investment.update( valuation_finished: true, feasibility: "feasible", diff --git a/spec/features/valuation/budgets_spec.rb b/spec/features/valuation/budgets_spec.rb index fc20dcd75..bb0d51059 100644 --- a/spec/features/valuation/budgets_spec.rb +++ b/spec/features/valuation/budgets_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Valuation budgets" do +describe "Valuation budgets" do - background do + before do @valuator = create(:valuator, user: create(:user, username: "Rachel", email: "rachel@valuators.org")) login_as(@valuator.user) end diff --git a/spec/features/valuation_spec.rb b/spec/features/valuation_spec.rb index d67070760..302899428 100644 --- a/spec/features/valuation_spec.rb +++ b/spec/features/valuation_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Valuation" do +describe "Valuation" do let(:user) { create(:user) } context "Access" do diff --git a/spec/features/verification/email_spec.rb b/spec/features/verification/email_spec.rb index 662da10f6..bfb274049 100644 --- a/spec/features/verification/email_spec.rb +++ b/spec/features/verification/email_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Verify email" do +describe "Verify email" do scenario "Verify" do user = create(:user, diff --git a/spec/features/verification/letter_spec.rb b/spec/features/verification/letter_spec.rb index 74ab31ac7..91c5246bd 100644 --- a/spec/features/verification/letter_spec.rb +++ b/spec/features/verification/letter_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Verify Letter" do +describe "Verify Letter" do scenario "Request a letter" do user = create(:user, residence_verified_at: Time.current, diff --git a/spec/features/verification/level_three_verification_spec.rb b/spec/features/verification/level_three_verification_spec.rb index 1cdd96fde..ad55f30fd 100644 --- a/spec/features/verification/level_three_verification_spec.rb +++ b/spec/features/verification/level_three_verification_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Level three verification" do +describe "Level three verification" do scenario "Verification with residency and verified sms" do create(:geozone) user = create(:user) diff --git a/spec/features/verification/level_two_verification_spec.rb b/spec/features/verification/level_two_verification_spec.rb index 085926fba..e9fc0bb24 100644 --- a/spec/features/verification/level_two_verification_spec.rb +++ b/spec/features/verification/level_two_verification_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Level two verification" do +describe "Level two verification" do scenario "Verification with residency and sms" do create(:geozone) diff --git a/spec/features/verification/residence_spec.rb b/spec/features/verification/residence_spec.rb index 832894a90..cd05b4545 100644 --- a/spec/features/verification/residence_spec.rb +++ b/spec/features/verification/residence_spec.rb @@ -1,8 +1,8 @@ require "rails_helper" -feature "Residence" do +describe "Residence" do - background { create(:geozone) } + before { create(:geozone) } scenario "Verify resident" do user = create(:user) diff --git a/spec/features/verification/sms_spec.rb b/spec/features/verification/sms_spec.rb index 956d28136..449062d44 100644 --- a/spec/features/verification/sms_spec.rb +++ b/spec/features/verification/sms_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "SMS Verification" do +describe "SMS Verification" do scenario "Verify" do user = create(:user, residence_verified_at: Time.current) diff --git a/spec/features/verification/verification_path_spec.rb b/spec/features/verification/verification_path_spec.rb index c97830318..6ff2ee46b 100644 --- a/spec/features/verification/verification_path_spec.rb +++ b/spec/features/verification/verification_path_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Verification path" do +describe "Verification path" do scenario "User is an organization" do user = create(:user, verified_at: Time.current) diff --git a/spec/features/verification/verified_user_spec.rb b/spec/features/verification/verified_user_spec.rb index 541bf11e8..8a9e1c936 100644 --- a/spec/features/verification/verified_user_spec.rb +++ b/spec/features/verification/verified_user_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Verified users" do +describe "Verified users" do scenario "Verified emails" do user = create(:user, diff --git a/spec/features/votes_spec.rb b/spec/features/votes_spec.rb index eb9154050..db9091aeb 100644 --- a/spec/features/votes_spec.rb +++ b/spec/features/votes_spec.rb @@ -1,14 +1,14 @@ require "rails_helper" -feature "Votes" do +describe "Votes" do - background do + before do @manuela = create(:user, verified_at: Time.current) @pablo = create(:user) end - feature "Debates" do - background { login_as(@manuela) } + describe "Debates" do + before { login_as(@manuela) } scenario "Index shows user votes on debates" do @@ -59,7 +59,7 @@ feature "Votes" do end end - feature "Single debate" do + describe "Single debate" do scenario "Show no votes" do visit debate_path(create(:debate)) @@ -184,8 +184,8 @@ feature "Votes" do end end - feature "Proposals" do - background { login_as(@manuela) } + describe "Proposals" do + before { login_as(@manuela) } scenario "Index shows user votes on proposals" do proposal1 = create(:proposal) @@ -210,8 +210,8 @@ feature "Votes" do end end - feature "Single proposal" do - background do + describe "Single proposal" do + before do @proposal = create(:proposal) end @@ -368,8 +368,8 @@ feature "Votes" do end end - feature "Spending Proposals" do - background do + describe "Spending Proposals" do + before do Setting["feature.spending_proposals"] = true Setting["feature.spending_proposal_features.voting_allowed"] = true login_as(@manuela) @@ -380,7 +380,7 @@ feature "Votes" do Setting["feature.spending_proposal_features.voting_allowed"] = nil end - feature "Index" do + describe "Index" do scenario "Index shows user votes on proposals" do spending_proposal1 = create(:spending_proposal) spending_proposal2 = create(:spending_proposal) @@ -417,8 +417,8 @@ feature "Votes" do end end - feature "Single spending proposal" do - background do + describe "Single spending proposal" do + before do @proposal = create(:spending_proposal) end diff --git a/spec/features/welcome_spec.rb b/spec/features/welcome_spec.rb index 2542dea86..ec59f9fbe 100644 --- a/spec/features/welcome_spec.rb +++ b/spec/features/welcome_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "Welcome screen" do +describe "Welcome screen" do let(:budget) { create(:budget) } diff --git a/spec/lib/tasks/sitemap_spec.rb b/spec/lib/tasks/sitemap_spec.rb index e7c38a62c..97e57a60a 100644 --- a/spec/lib/tasks/sitemap_spec.rb +++ b/spec/lib/tasks/sitemap_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -feature "rake sitemap:create" do +describe "rake sitemap:create", type: :feature do before do @file ||= Rails.root.join("public", "sitemap.xml") diff --git a/spec/shared/features/admin_milestoneable.rb b/spec/shared/features/admin_milestoneable.rb index cb60fba52..bbf436f77 100644 --- a/spec/shared/features/admin_milestoneable.rb +++ b/spec/shared/features/admin_milestoneable.rb @@ -1,7 +1,7 @@ shared_examples "admin_milestoneable" do |factory_name, path_name| it_behaves_like "admin_progressable", factory_name, path_name - feature "Admin milestones" do + describe "Admin milestones" do let!(:milestoneable) { create(factory_name) } let(:path) { send(path_name, *resource_hierarchy_for(milestoneable)) } diff --git a/spec/shared/features/admin_progressable.rb b/spec/shared/features/admin_progressable.rb index 31347942d..81cd2cb62 100644 --- a/spec/shared/features/admin_progressable.rb +++ b/spec/shared/features/admin_progressable.rb @@ -1,7 +1,7 @@ shared_examples "admin_progressable" do |factory_name, path_name| let!(:progressable) { create(factory_name) } - feature "Manage progress bars" do + describe "Manage progress bars" do let(:progressable_path) { send(path_name, *resource_hierarchy_for(progressable)) } let(:path) do diff --git a/spec/shared/features/imageable_destroy.rb b/spec/shared/features/imageable_destroy.rb index af7dcdc97..dc8d7d62c 100644 --- a/spec/shared/features/imageable_destroy.rb +++ b/spec/shared/features/imageable_destroy.rb @@ -22,7 +22,7 @@ shared_examples "imageable destroy" do |imageable_factory_name, context "Destroy" do - background do + before do create(:image, imageable: imageable, user: imageable.author) end diff --git a/spec/shared/features/milestoneable.rb b/spec/shared/features/milestoneable.rb index 75897b286..f983f9aa3 100644 --- a/spec/shared/features/milestoneable.rb +++ b/spec/shared/features/milestoneable.rb @@ -3,7 +3,7 @@ shared_examples "milestoneable" do |factory_name, path_name| let!(:milestoneable) { create(factory_name) } - feature "Show milestones" do + describe "Show milestones" do let(:path) { send(path_name, *resource_hierarchy_for(milestoneable)) } scenario "Show milestones", :js do diff --git a/spec/shared/features/progressable.rb b/spec/shared/features/progressable.rb index 5cdc0c750..0856009cb 100644 --- a/spec/shared/features/progressable.rb +++ b/spec/shared/features/progressable.rb @@ -1,5 +1,5 @@ shared_examples "progressable" do |factory_name, path_name| - feature "Progress bars", :js do + describe "Progress bars", :js do let!(:progressable) { create(factory_name) } let(:path) { send(path_name, *resource_hierarchy_for(progressable)) }