Don't reload records in system tests

As mentioned in commits like a586ba806, a7664ad81, 006128da5, b41fbfa52
and c480cdd91, accessing the database after starting the browser with
the `visit` method sometimes results in database corruption and failing
tests on our CI due to the process running the test accessing the
database after the process running the browser has started.

For example, one of these tests has recently failed on our CI:

```
3) Users Create a level 3 user with email from scratch
   Failure/Error: expect(user.reload).to be_confirmed
     expected `#<User id: 2060, email: "pepe@gmail.com", created_at:
     "2025-03-12 19:51:03.688867000 +0100", updated_...d_debates: true,
     recommended_proposals: true, subscriptions_token: nil,
     registering_from_web: false>.confirmed?` to be truthy, got false
```

IMHO this is also a bad practice for system tests, since these tests
should be checking what users experience.

So we're modifying the tests to check the results of users interaction
from the point of view of the users. For example, instead of checking
that a user is now level 3 verified in the database, we're checking that
the user interface states that the user is level 3 verified.

Note we're adding an offset when editing the map marker by clicking on
`map-location` with `.click(x: 30, y: 30)`. This way we make sure that
both the latitude and longitude change from the original values; we used
to clicking in the middle (no offset), which didn't change the longitude
and changed the latitude just by coincidence.

Also note we aren't changing tests with the `:no_js` tag, since these
tests don't run a real browser in a separate process. In the future, we
should also change most of these tests so they don't access the database
and they use a real browser.
This commit is contained in:
Javi Martín
2025-03-12 15:23:11 +01:00
parent e29ad8b505
commit 1b8a079727
11 changed files with 98 additions and 84 deletions

View File

@@ -26,7 +26,11 @@ describe "DocumentVerifications" do
expect(page).to have_content "already verified"
expect(user.reload).to be_level_three_verified
visit management_document_verifications_path
fill_in "document_verification_document_number", with: user.document_number
click_button "Check document"
expect(page).to have_content "already verified"
end
describe "Verifying througth Census" do

View File

@@ -2,35 +2,46 @@ require "rails_helper"
describe "EmailVerifications" do
scenario "Verifying a level 1 user via email" do
login_as_manager
user = create(:user)
visit management_document_verifications_path
fill_in "document_verification_document_number", with: "12345678Z"
click_button "Check document"
in_browser(:user) do
login_as user
visit root_path
expect(page).to have_content "Please introduce the email used on the account"
expect(page).to have_content "Debates"
end
fill_in "email_verification_email", with: user.email
click_button "Send verification email"
in_browser(:manager) do
login_as_manager
visit management_document_verifications_path
fill_in "document_verification_document_number", with: "12345678Z"
click_button "Check document"
expect(page).to have_content "In order to completely verify this user, " \
"it is necessary that the user clicks on a link"
expect(page).to have_content "Please introduce the email used on the account"
user.reload
fill_in "email_verification_email", with: user.email
click_button "Send verification email"
login_as(user)
expect(page).to have_content "In order to completely verify this user, " \
"it is necessary that the user clicks on a link"
end
sent_token = /.*email_verification_token=(.*)".*/.match(ActionMailer::Base.deliveries.last.body.to_s)[1]
visit email_path(email_verification_token: sent_token)
expect(page).to have_content "You are a verified user"
in_browser(:user) do
visit email_path(email_verification_token: sent_token)
expect(page).not_to have_link "Verify my account"
expect(page).to have_content "Account verified"
expect(page).to have_content "You are a verified user"
expect(page).to have_content "Account verified"
expect(page).not_to have_link "Verify my account"
end
expect(user.reload.document_number).to eq("12345678Z")
expect(user).to be_level_three_verified
in_browser(:manager) do
visit management_document_verifications_path
fill_in "document_verification_document_number", with: "12345678Z"
click_button "Check document"
expect(page).to have_content "This user account is already verified"
end
end
end

View File

@@ -37,9 +37,12 @@ describe "Users" do
click_button "Confirm"
expect(user.reload).to be_confirmed
expect(page).to have_content "Your account has been confirmed."
visit account_path
expect(page).to have_field "Username", with: "pepe"
expect(page).to have_content "Account verified"
end
scenario "Create a level 3 user without email from scratch" do