1b8a079727
As mentioned in commits likea586ba806,a7664ad81,006128da5,b41fbfa52andc480cdd91, accessing the database after starting the browser with the `visit` method sometimes results in database corruption and failing tests on our CI due to the process running the test accessing the database after the process running the browser has started. For example, one of these tests has recently failed on our CI: ``` 3) Users Create a level 3 user with email from scratch Failure/Error: expect(user.reload).to be_confirmed expected `#<User id: 2060, email: "pepe@gmail.com", created_at: "2025-03-12 19:51:03.688867000 +0100", updated_...d_debates: true, recommended_proposals: true, subscriptions_token: nil, registering_from_web: false>.confirmed?` to be truthy, got false ``` IMHO this is also a bad practice for system tests, since these tests should be checking what users experience. So we're modifying the tests to check the results of users interaction from the point of view of the users. For example, instead of checking that a user is now level 3 verified in the database, we're checking that the user interface states that the user is level 3 verified. Note we're adding an offset when editing the map marker by clicking on `map-location` with `.click(x: 30, y: 30)`. This way we make sure that both the latitude and longitude change from the original values; we used to clicking in the middle (no offset), which didn't change the longitude and changed the latitude just by coincidence. Also note we aren't changing tests with the `:no_js` tag, since these tests don't run a real browser in a separate process. In the future, we should also change most of these tests so they don't access the database and they use a real browser.
108 lines
3.5 KiB
Ruby
108 lines
3.5 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Users" do
|
|
scenario "Create a level 3 user with email from scratch" do
|
|
login_as_manager
|
|
visit management_document_verifications_path
|
|
fill_in "document_verification_document_number", with: "12345678Z"
|
|
click_button "Check document"
|
|
|
|
expect(page).to have_content "Please introduce the email used on the account"
|
|
|
|
click_link "Create a new account"
|
|
|
|
fill_in "user_username", with: "pepe"
|
|
fill_in "user_email", with: "pepe@gmail.com"
|
|
fill_in "Date of birth", with: Date.new(1980, 12, 31)
|
|
|
|
click_button "Create user"
|
|
|
|
expect(page).to have_content "We have sent an email"
|
|
expect(page).not_to have_content "Autogenerated password is"
|
|
|
|
user = User.find_by(email: "pepe@gmail.com")
|
|
|
|
expect(user).to be_level_three_verified
|
|
expect(user).to be_residence_verified
|
|
expect(user).not_to be_confirmed
|
|
expect(user.date_of_birth).to have_content Date.new(1980, 12, 31)
|
|
|
|
sent_token = /.*confirmation_token=(.*)".*/.match(ActionMailer::Base.deliveries.last.body.to_s)[1]
|
|
visit user_confirmation_path(confirmation_token: sent_token)
|
|
|
|
expect(page).to have_content "Confirming the account with email"
|
|
|
|
fill_in "user_password", with: "12345678"
|
|
fill_in "user_password_confirmation", with: "12345678"
|
|
|
|
click_button "Confirm"
|
|
|
|
expect(page).to have_content "Your account has been confirmed."
|
|
|
|
visit account_path
|
|
|
|
expect(page).to have_field "Username", with: "pepe"
|
|
expect(page).to have_content "Account verified"
|
|
end
|
|
|
|
scenario "Create a level 3 user without email from scratch" do
|
|
login_as_manager
|
|
visit management_document_verifications_path
|
|
fill_in "document_verification_document_number", with: "12345678Z"
|
|
click_button "Check document"
|
|
|
|
expect(page).to have_content "Please introduce the email used on the account"
|
|
|
|
click_link "Create a new account"
|
|
|
|
fill_in "user_username", with: "Kelly Sue"
|
|
fill_in "user_email", with: ""
|
|
fill_in "Date of birth", with: Date.new(1980, 12, 31)
|
|
|
|
click_button "Create user"
|
|
|
|
expect(page).not_to have_content "We have sent an email"
|
|
expect(page).to have_content "Autogenerated password is"
|
|
|
|
user = User.find_by(username: "Kelly Sue")
|
|
|
|
expect(user).to be_level_three_verified
|
|
expect(user).to be_residence_verified
|
|
expect(user).to be_confirmed
|
|
expect(user.date_of_birth).to have_content Date.new(1980, 12, 31)
|
|
end
|
|
|
|
scenario "Delete a level 2 user account from document verification page" do
|
|
level_2_user = create(:user, :level_two, document_number: "12345678Z")
|
|
manager = create(:manager)
|
|
administrator = create(:administrator)
|
|
|
|
login_as_manager(manager)
|
|
visit management_document_verifications_path
|
|
fill_in "document_verification_document_number", with: "12345678Z"
|
|
click_button "Check document"
|
|
|
|
expect(page).to have_content "This user can participate in the website with the following permissions"
|
|
expect(page).not_to have_content "This user account is already verified."
|
|
|
|
click_link "Delete user"
|
|
accept_confirm { click_button "Delete account" }
|
|
|
|
expect(page).to have_content "User account deleted."
|
|
|
|
fill_in "document_verification_document_number", with: "12345678Z"
|
|
click_button "Check document"
|
|
|
|
expect(page).to have_content "no user account associated to it"
|
|
|
|
logout
|
|
login_as(administrator.user)
|
|
|
|
visit admin_users_path(filter: "erased")
|
|
|
|
within "tr", text: level_2_user.id do
|
|
expect(page).to have_content "Deleted by manager: manager_user_#{manager.user_id}"
|
|
end
|
|
end
|
|
end
|