db97f9d08c
We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
43 lines
1.4 KiB
Ruby
43 lines
1.4 KiB
Ruby
require "rails_helper"
|
|
|
|
describe ProposalsHelper do
|
|
describe "#progress_bar_percentage" do
|
|
it "is 0 if no votes" do
|
|
proposal = create(:proposal)
|
|
expect(progress_bar_percentage(proposal)).to eq 0
|
|
end
|
|
|
|
it "is between 1 and 100 if there are votes but less than needed" do
|
|
proposal = create(:proposal, cached_votes_up: Proposal.votes_needed_for_success / 2)
|
|
expect(progress_bar_percentage(proposal)).to eq 50
|
|
end
|
|
|
|
it "is 100 if there are more votes than needed" do
|
|
proposal = create(:proposal, cached_votes_up: Proposal.votes_needed_for_success * 2)
|
|
expect(progress_bar_percentage(proposal)).to eq 100
|
|
end
|
|
end
|
|
|
|
describe "#supports_percentage" do
|
|
it "is 0 if no votes" do
|
|
proposal = create(:proposal)
|
|
expect(supports_percentage(proposal)).to eq "0%"
|
|
end
|
|
|
|
it "is between 0.1 from 1 to 0.1% of needed votes" do
|
|
proposal = create(:proposal, cached_votes_up: 1)
|
|
expect(supports_percentage(proposal)).to eq "0.1%"
|
|
end
|
|
|
|
it "is between 1 and 100 if there are votes but less than needed" do
|
|
proposal = create(:proposal, cached_votes_up: Proposal.votes_needed_for_success / 2)
|
|
expect(supports_percentage(proposal)).to eq "50%"
|
|
end
|
|
|
|
it "is 100 if there are more votes than needed" do
|
|
proposal = create(:proposal, cached_votes_up: Proposal.votes_needed_for_success * 2)
|
|
expect(supports_percentage(proposal)).to eq "100%"
|
|
end
|
|
end
|
|
end
|