f47179ff68
People using screen readers usually expect links to take them somewhere else in the page on to a different page, while they expect buttons to change something on the page. Since we're in the latter scenario, using a button is more accessible. It's also more natural; with a button, we don't need to provide `#` as the URL or stop the default event when the button is clicked. And, unlike links, buttons can be activated with either the space or the enter key. Finally, clicking a link pointing to `#` with the middle mouse button opens a useless new tab, while buttons do nothing in this case. Now that we only have one "All" link on the page, we no longer need to specify which "All" link we're clicking or which "All" link we are checking, so we're simplifying the code doing so.
237 lines
8.0 KiB
Ruby
237 lines
8.0 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Moderate comments" do
|
|
scenario "Hide" do
|
|
citizen = create(:user)
|
|
moderator = create(:moderator)
|
|
|
|
comment = create(:comment)
|
|
|
|
login_as(moderator.user)
|
|
visit debate_path(comment.commentable)
|
|
|
|
within("#comment_#{comment.id}") do
|
|
accept_confirm("Are you sure? Hide") { click_button "Hide" }
|
|
expect(page).to have_css(".comment .faded")
|
|
end
|
|
|
|
login_as(citizen)
|
|
visit debate_path(comment.commentable)
|
|
|
|
expect(page).to have_css(".comment", count: 1)
|
|
expect(page).not_to have_content("This comment has been deleted")
|
|
expect(page).not_to have_content("SPAM")
|
|
end
|
|
|
|
scenario "Can not hide own comment" do
|
|
moderator = create(:moderator)
|
|
comment = create(:comment, user: moderator.user)
|
|
|
|
login_as(moderator.user)
|
|
visit debate_path(comment.commentable)
|
|
|
|
within("#comment_#{comment.id}") do
|
|
expect(page).not_to have_button "Hide"
|
|
expect(page).not_to have_button "Block author"
|
|
end
|
|
end
|
|
|
|
scenario "Visit items with flagged comments" do
|
|
moderator = create(:moderator)
|
|
debate = create(:debate, title: "Debate with spam comment")
|
|
proposal = create(:proposal, title: "Proposal with spam comment")
|
|
create(:comment, commentable: debate, body: "This is SPAM comment on debate", flags_count: 2)
|
|
create(:comment, commentable: proposal, body: "This is SPAM comment on proposal", flags_count: 2)
|
|
|
|
login_as(moderator.user)
|
|
visit moderation_comments_path
|
|
|
|
expect(page).to have_content("Debate with spam comment")
|
|
expect(page).to have_content("Proposal with spam comment")
|
|
expect(page).to have_content("This is SPAM comment on debate")
|
|
expect(page).to have_content("This is SPAM comment on proposal")
|
|
|
|
click_link "Debate with spam comment"
|
|
expect(page).to have_content("Debate with spam comment")
|
|
expect(page).to have_content("This is SPAM comment on debate")
|
|
|
|
visit moderation_comments_path
|
|
|
|
click_link "Proposal with spam comment"
|
|
expect(page).to have_content("Proposal with spam comment")
|
|
expect(page).to have_content("This is SPAM comment on proposal")
|
|
end
|
|
|
|
describe "/moderation/ screen" do
|
|
before do
|
|
moderator = create(:moderator)
|
|
login_as(moderator.user)
|
|
end
|
|
|
|
describe "moderate in bulk" do
|
|
describe "When a comment has been selected for moderation" do
|
|
let!(:comment) { create(:comment) }
|
|
|
|
before do
|
|
visit moderation_comments_path
|
|
click_link "All"
|
|
|
|
within("#comment_#{comment.id}") do
|
|
check "comment_#{comment.id}_check"
|
|
end
|
|
end
|
|
|
|
scenario "Hide the comment" do
|
|
accept_confirm("Are you sure? Hide comments") do
|
|
click_button "Hide comments"
|
|
end
|
|
|
|
expect(page).not_to have_css("#comment_#{comment.id}")
|
|
|
|
click_link "Block users"
|
|
fill_in "email or name of user", with: comment.user.email
|
|
click_button "Search"
|
|
|
|
within "tr", text: comment.user.name do
|
|
expect(page).to have_button "Block"
|
|
end
|
|
end
|
|
|
|
scenario "Block the user" do
|
|
accept_confirm("Are you sure? Block authors") do
|
|
click_button "Block authors"
|
|
end
|
|
|
|
expect(page).not_to have_css("#comment_#{comment.id}")
|
|
|
|
click_link "Block users"
|
|
fill_in "email or name of user", with: comment.user.email
|
|
click_button "Search"
|
|
|
|
within "tr", text: comment.user.name do
|
|
expect(page).to have_content "Blocked"
|
|
end
|
|
end
|
|
|
|
scenario "Ignore the comment", :no_js do
|
|
click_button "Mark as viewed"
|
|
|
|
expect(comment.reload).to be_ignored_flag
|
|
expect(comment.reload).not_to be_hidden
|
|
expect(comment.user).not_to be_hidden
|
|
end
|
|
end
|
|
|
|
scenario "select all/none" do
|
|
create_list(:comment, 2)
|
|
|
|
visit moderation_comments_path
|
|
click_link "All"
|
|
|
|
expect(page).to have_field type: :checkbox, count: 2
|
|
|
|
within(".check-all-none") { click_button "All" }
|
|
|
|
expect(all(:checkbox)).to all(be_checked)
|
|
|
|
within(".check-all-none") { click_button "None" }
|
|
|
|
all(:checkbox).each { |checkbox| expect(checkbox).not_to be_checked }
|
|
end
|
|
|
|
scenario "remembering page, filter and order" do
|
|
stub_const("#{ModerateActions}::PER_PAGE", 2)
|
|
create_list(:comment, 4)
|
|
|
|
visit moderation_comments_path(filter: "all", page: "2", order: "newest")
|
|
|
|
accept_confirm("Are you sure? Mark as viewed") { click_button "Mark as viewed" }
|
|
|
|
expect(page).to have_link "Newest", class: "is-active"
|
|
expect(page).to have_link "Most flagged"
|
|
|
|
expect(page).to have_current_path(/filter=all/)
|
|
expect(page).to have_current_path(/page=2/)
|
|
expect(page).to have_current_path(/order=newest/)
|
|
end
|
|
end
|
|
|
|
scenario "Current filter is properly highlighted" do
|
|
visit moderation_comments_path
|
|
expect(page).not_to have_link("Pending")
|
|
expect(page).to have_link("All")
|
|
expect(page).to have_link("Marked as viewed")
|
|
|
|
visit moderation_comments_path(filter: "all")
|
|
expect(page).not_to have_link("All")
|
|
expect(page).to have_link("Pending")
|
|
expect(page).to have_link("Marked as viewed")
|
|
|
|
visit moderation_comments_path(filter: "pending_flag_review")
|
|
expect(page).to have_link("All")
|
|
expect(page).not_to have_link("Pending")
|
|
expect(page).to have_link("Marked as viewed")
|
|
|
|
visit moderation_comments_path(filter: "with_ignored_flag")
|
|
expect(page).to have_link("All")
|
|
expect(page).to have_link("Pending")
|
|
expect(page).not_to have_link("Marked as viewed")
|
|
end
|
|
|
|
scenario "Filtering comments" do
|
|
create(:comment, body: "Regular comment")
|
|
create(:comment, :flagged, body: "Pending comment")
|
|
create(:comment, :hidden, body: "Hidden comment")
|
|
create(:comment, :flagged, :with_ignored_flag, body: "Ignored comment")
|
|
|
|
visit moderation_comments_path(filter: "all")
|
|
expect(page).to have_content("Regular comment")
|
|
expect(page).to have_content("Pending comment")
|
|
expect(page).not_to have_content("Hidden comment")
|
|
expect(page).to have_content("Ignored comment")
|
|
|
|
visit moderation_comments_path(filter: "pending_flag_review")
|
|
expect(page).not_to have_content("Regular comment")
|
|
expect(page).to have_content("Pending comment")
|
|
expect(page).not_to have_content("Hidden comment")
|
|
expect(page).not_to have_content("Ignored comment")
|
|
|
|
visit moderation_comments_path(filter: "with_ignored_flag")
|
|
expect(page).not_to have_content("Regular comment")
|
|
expect(page).not_to have_content("Pending comment")
|
|
expect(page).not_to have_content("Hidden comment")
|
|
expect(page).to have_content("Ignored comment")
|
|
end
|
|
|
|
scenario "sorting comments" do
|
|
flagged_comment = create(:comment,
|
|
body: "Flagged comment",
|
|
created_at: 1.day.ago,
|
|
flags_count: 5)
|
|
flagged_new_comment = create(:comment,
|
|
body: "Flagged new comment",
|
|
created_at: 12.hours.ago,
|
|
flags_count: 3)
|
|
newer_comment = create(:comment, body: "Newer comment", created_at: Time.current)
|
|
|
|
visit moderation_comments_path(order: "newest")
|
|
|
|
expect(flagged_new_comment.body).to appear_before(flagged_comment.body)
|
|
|
|
visit moderation_comments_path(order: "flags")
|
|
|
|
expect(flagged_comment.body).to appear_before(flagged_new_comment.body)
|
|
|
|
visit moderation_comments_path(filter: "all", order: "newest")
|
|
|
|
expect(newer_comment.body).to appear_before(flagged_new_comment.body)
|
|
expect(flagged_new_comment.body).to appear_before(flagged_comment.body)
|
|
|
|
visit moderation_comments_path(filter: "all", order: "flags")
|
|
|
|
expect(flagged_comment.body).to appear_before(flagged_new_comment.body)
|
|
expect(flagged_new_comment.body).to appear_before(newer_comment.body)
|
|
end
|
|
end
|
|
end
|