4c02317909
Since we were using an icon font with no text, screen readers were announcing things like "Enabled, L", trying to read the icon generated with CSS. Using text and replacing it with CSS with an icon solves the problem. We could also use aria-label, but I prefer using "Yes/No" so the text can be shown/hidden with CSS. Also useful when using `save_and_open_page` during tests, since the displayed page will not have any CSS rules applied. Out of several existing techniques to hide text [1], we're setting the font size to 1px in combination with moving the content off-screen because that way we can override it in the `::before` element. Just moving the content off-screen has the inconvenient of the content still being taken into account when calculating the text indentation. And just using a 1px font would make a 1px-sized square appear when selecting text, which could confuse users. [1] https://webaim.org/techniques/css/invisiblecontent/
423 lines
14 KiB
Ruby
423 lines
14 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Admin budgets", :admin do
|
|
context "Feature flag" do
|
|
before do
|
|
Setting["process.budgets"] = nil
|
|
end
|
|
|
|
scenario "Disabled with a feature flag" do
|
|
expect { visit admin_budgets_path }.to raise_exception(FeatureFlags::FeatureDisabled)
|
|
end
|
|
end
|
|
|
|
context "Load" do
|
|
let!(:budget) { create(:budget, slug: "budget_slug") }
|
|
|
|
scenario "finds budget by slug" do
|
|
visit edit_admin_budget_path("budget_slug")
|
|
|
|
expect(page).to have_content("Edit Participatory budget")
|
|
end
|
|
|
|
scenario "raises an error if budget slug is not found" do
|
|
expect do
|
|
visit edit_admin_budget_path("wrong_budget")
|
|
end.to raise_error ActiveRecord::RecordNotFound
|
|
end
|
|
|
|
scenario "raises an error if budget id is not found" do
|
|
expect do
|
|
visit edit_admin_budget_path(0)
|
|
end.to raise_error ActiveRecord::RecordNotFound
|
|
end
|
|
end
|
|
|
|
context "Index" do
|
|
scenario "Displaying no open budgets text" do
|
|
visit admin_budgets_path
|
|
|
|
expect(page).to have_content("There are no budgets.")
|
|
end
|
|
|
|
scenario "Displaying budgets" do
|
|
budget = create(:budget, :accepting)
|
|
visit admin_budgets_path
|
|
|
|
expect(page).to have_content budget.name
|
|
expect(page).to have_content "Accepting projects"
|
|
end
|
|
|
|
scenario "Filters by phase" do
|
|
drafting_budget = create(:budget, :drafting)
|
|
accepting_budget = create(:budget, :accepting)
|
|
selecting_budget = create(:budget, :selecting)
|
|
balloting_budget = create(:budget, :balloting)
|
|
finished_budget = create(:budget, :finished)
|
|
|
|
visit admin_budgets_path
|
|
expect(page).to have_content(drafting_budget.name)
|
|
expect(page).to have_content(accepting_budget.name)
|
|
expect(page).to have_content(selecting_budget.name)
|
|
expect(page).to have_content(balloting_budget.name)
|
|
expect(page).to have_content(finished_budget.name)
|
|
|
|
within "#budget_#{finished_budget.id}" do
|
|
expect(page).to have_content("Completed")
|
|
end
|
|
|
|
click_link "Finished"
|
|
expect(page).not_to have_content(drafting_budget.name)
|
|
expect(page).not_to have_content(accepting_budget.name)
|
|
expect(page).not_to have_content(selecting_budget.name)
|
|
expect(page).not_to have_content(balloting_budget.name)
|
|
expect(page).to have_content(finished_budget.name)
|
|
|
|
click_link "Open"
|
|
expect(page).to have_content(drafting_budget.name)
|
|
expect(page).to have_content(accepting_budget.name)
|
|
expect(page).to have_content(selecting_budget.name)
|
|
expect(page).to have_content(balloting_budget.name)
|
|
expect(page).not_to have_content(finished_budget.name)
|
|
end
|
|
|
|
scenario "Filters are properly highlighted" do
|
|
filters_links = { "all" => "All", "open" => "Open", "finished" => "Finished" }
|
|
|
|
visit admin_budgets_path
|
|
|
|
expect(page).not_to have_link(filters_links.values.first)
|
|
filters_links.keys.drop(1).each { |filter| expect(page).to have_link(filters_links[filter]) }
|
|
|
|
filters_links.each do |current_filter, link|
|
|
visit admin_budgets_path(filter: current_filter)
|
|
|
|
expect(page).not_to have_link(link)
|
|
|
|
(filters_links.keys - [current_filter]).each do |filter|
|
|
expect(page).to have_link(filters_links[filter])
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context "New" do
|
|
scenario "Create budget - Knapsack voting (default)" do
|
|
visit admin_budgets_path
|
|
click_link "Create new budget"
|
|
|
|
fill_in "Name", with: "M30 - Summer campaign"
|
|
select "Accepting projects", from: "budget[phase]"
|
|
|
|
click_button "Create Budget"
|
|
|
|
expect(page).to have_content "New participatory budget created successfully!"
|
|
expect(page).to have_field "Name", with: "M30 - Summer campaign"
|
|
expect(page).to have_select "Final voting style", selected: "Knapsack"
|
|
end
|
|
|
|
scenario "Create budget - Approval voting", :js do
|
|
admin = Administrator.first
|
|
|
|
visit admin_budgets_path
|
|
click_link "Create new budget"
|
|
|
|
fill_in "Name", with: "M30 - Summer campaign"
|
|
select "Accepting projects", from: "budget[phase]"
|
|
select "Approval", from: "Final voting style"
|
|
click_button "Create Budget"
|
|
|
|
expect(page).to have_content "New participatory budget created successfully!"
|
|
expect(page).to have_field "Name", with: "M30 - Summer campaign"
|
|
expect(page).to have_select "Final voting style", selected: "Approval"
|
|
|
|
click_link "Select administrators"
|
|
|
|
expect(page).to have_field admin.name
|
|
end
|
|
|
|
scenario "Name is mandatory" do
|
|
visit new_admin_budget_path
|
|
click_button "Create Budget"
|
|
|
|
expect(page).not_to have_content "New participatory budget created successfully!"
|
|
expect(page).to have_css(".is-invalid-label", text: "Name")
|
|
end
|
|
|
|
scenario "Name should be unique" do
|
|
create(:budget, name: "Existing Name")
|
|
|
|
visit new_admin_budget_path
|
|
fill_in "Name", with: "Existing Name"
|
|
click_button "Create Budget"
|
|
|
|
expect(page).not_to have_content "New participatory budget created successfully!"
|
|
expect(page).to have_css(".is-invalid-label", text: "Name")
|
|
expect(page).to have_css("small.form-error", text: "has already been taken")
|
|
end
|
|
|
|
scenario "Do not show results and stats settings on new budget", :js do
|
|
visit new_admin_budget_path
|
|
|
|
expect(page).not_to have_content "Show results and stats"
|
|
expect(page).not_to have_field "Show results"
|
|
expect(page).not_to have_field "Show stats"
|
|
expect(page).not_to have_field "Show advanced stats"
|
|
end
|
|
end
|
|
|
|
context "Create", :js do
|
|
scenario "A new budget is always created in draft mode" do
|
|
visit admin_budgets_path
|
|
click_link "Create new budget"
|
|
|
|
fill_in "Name", with: "M30 - Summer campaign"
|
|
select "Accepting projects", from: "budget[phase]"
|
|
|
|
click_button "Create Budget"
|
|
|
|
expect(page).to have_content "New participatory budget created successfully!"
|
|
expect(page).to have_content "This participatory budget is in draft mode"
|
|
expect(page).to have_link "Preview budget"
|
|
expect(page).to have_link "Publish budget"
|
|
end
|
|
end
|
|
|
|
context "Publish", :js do
|
|
let(:budget) { create(:budget, :drafting) }
|
|
|
|
scenario "Can preview budget before it is published" do
|
|
visit edit_admin_budget_path(budget)
|
|
|
|
within_window(window_opened_by { click_link "Preview budget" }) do
|
|
expect(page).to have_current_path budget_path(budget)
|
|
end
|
|
end
|
|
|
|
scenario "Can preview a budget after it is published" do
|
|
visit edit_admin_budget_path(budget)
|
|
|
|
accept_confirm { click_link "Publish budget" }
|
|
|
|
expect(page).to have_content "Participatory budget published successfully"
|
|
expect(page).not_to have_content "This participatory budget is in draft mode"
|
|
expect(page).not_to have_link "Publish budget"
|
|
|
|
within_window(window_opened_by { click_link "Preview budget" }) do
|
|
expect(page).to have_current_path budget_path(budget)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "Destroy" do
|
|
let!(:budget) { create(:budget) }
|
|
let(:heading) { create(:budget_heading, budget: budget) }
|
|
|
|
scenario "Destroy a budget without investments" do
|
|
visit admin_budgets_path
|
|
click_link "Edit budget"
|
|
click_link "Delete budget"
|
|
|
|
expect(page).to have_content("Budget deleted successfully")
|
|
expect(page).to have_content("There are no budgets.")
|
|
end
|
|
|
|
scenario "Try to destroy a budget with investments" do
|
|
create(:budget_investment, heading: heading)
|
|
|
|
visit admin_budgets_path
|
|
click_link "Edit budget"
|
|
click_link "Delete budget"
|
|
|
|
expect(page).to have_content("You cannot delete a budget that has associated investments")
|
|
expect(page).to have_content("There is 1 budget")
|
|
end
|
|
|
|
scenario "Try to destroy a budget with polls" do
|
|
create(:poll, budget: budget)
|
|
|
|
visit edit_admin_budget_path(budget)
|
|
click_link "Delete budget"
|
|
|
|
expect(page).to have_content("You cannot delete a budget that has an associated poll")
|
|
expect(page).to have_content("There is 1 budget")
|
|
end
|
|
end
|
|
|
|
context "Edit" do
|
|
let(:budget) { create(:budget) }
|
|
|
|
scenario "Show phases table" do
|
|
travel_to(Date.new(2015, 7, 15)) do
|
|
budget.update!(phase: "selecting")
|
|
budget.phases.valuating.update!(enabled: false)
|
|
|
|
visit edit_admin_budget_path(budget)
|
|
|
|
expect(page).to have_select "Phase", selected: "Selecting projects"
|
|
|
|
expect(page).to have_table "Phases", with_cols: [
|
|
[
|
|
"Information",
|
|
"Accepting projects",
|
|
"Reviewing projects",
|
|
"Selecting projects Active",
|
|
"Valuating projects",
|
|
"Publishing projects prices",
|
|
"Voting projects",
|
|
"Reviewing voting"
|
|
],
|
|
[
|
|
"2015-07-15 00:00:00 - 2015-08-14 23:59:59",
|
|
"2015-08-15 00:00:00 - 2015-09-14 23:59:59",
|
|
"2015-09-15 00:00:00 - 2015-10-14 23:59:59",
|
|
"2015-10-15 00:00:00 - 2015-11-14 23:59:59",
|
|
"2015-11-15 00:00:00 - 2015-12-14 23:59:59",
|
|
"2015-11-15 00:00:00 - 2016-01-14 23:59:59",
|
|
"2016-01-15 00:00:00 - 2016-02-14 23:59:59",
|
|
"2016-02-15 00:00:00 - 2016-03-14 23:59:59"
|
|
],
|
|
[
|
|
"Yes",
|
|
"Yes",
|
|
"Yes",
|
|
"Yes",
|
|
"No",
|
|
"Yes",
|
|
"Yes",
|
|
"Yes"
|
|
]
|
|
]
|
|
|
|
within_table "Phases" do
|
|
within "tr", text: "Information" do
|
|
expect(page).to have_link "Edit phase"
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
scenario "Show results and stats settings", :js do
|
|
visit edit_admin_budget_path(budget)
|
|
|
|
within_fieldset "Show results and stats" do
|
|
expect(page).to have_field "Show results"
|
|
expect(page).to have_field "Show stats"
|
|
expect(page).to have_field "Show advanced stats"
|
|
end
|
|
end
|
|
|
|
scenario "Changing name for current locale will update the slug if budget is in draft phase", :js do
|
|
budget.update!(published: false)
|
|
old_slug = budget.slug
|
|
|
|
visit edit_admin_budget_path(budget)
|
|
|
|
select "Español", from: :add_language
|
|
fill_in "Name", with: "Spanish name"
|
|
click_button "Update Budget"
|
|
|
|
expect(page).to have_content "Participatory budget updated successfully"
|
|
expect(budget.reload.slug).to eq old_slug
|
|
|
|
visit edit_admin_budget_path(budget)
|
|
|
|
select "English", from: :select_language
|
|
fill_in "Name", with: "New English Name"
|
|
click_button "Update Budget"
|
|
|
|
expect(page).to have_content "Participatory budget updated successfully"
|
|
expect(budget.reload.slug).not_to eq old_slug
|
|
expect(budget.slug).to eq "new-english-name"
|
|
end
|
|
end
|
|
|
|
context "Update" do
|
|
scenario "Update budget" do
|
|
visit edit_admin_budget_path(create(:budget))
|
|
|
|
fill_in "Name", with: "More trees on the streets"
|
|
click_button "Update Budget"
|
|
|
|
expect(page).to have_content("More trees on the streets")
|
|
expect(page).to have_current_path(admin_budgets_path)
|
|
end
|
|
|
|
scenario "Deselect all selected staff", :js do
|
|
admin = Administrator.first
|
|
valuator = create(:valuator)
|
|
|
|
budget = create(:budget, administrators: [admin], valuators: [valuator])
|
|
|
|
visit edit_admin_budget_path(budget)
|
|
click_link "1 administrator selected"
|
|
uncheck admin.name
|
|
|
|
expect(page).to have_link "Select administrators"
|
|
|
|
click_link "1 valuator selected"
|
|
uncheck valuator.name
|
|
|
|
expect(page).to have_link "Select valuators"
|
|
|
|
click_button "Update Budget"
|
|
visit edit_admin_budget_path(budget)
|
|
|
|
expect(page).to have_link "Select administrators"
|
|
expect(page).to have_link "Select valuators"
|
|
end
|
|
end
|
|
|
|
context "Calculate Budget's Winner Investments" do
|
|
scenario "For a Budget in reviewing balloting", :js do
|
|
budget = create(:budget, :reviewing_ballots)
|
|
heading = create(:budget_heading, budget: budget, price: 4)
|
|
unselected = create(:budget_investment, :unselected, heading: heading, price: 1,
|
|
ballot_lines_count: 3)
|
|
winner = create(:budget_investment, :selected, heading: heading, price: 3,
|
|
ballot_lines_count: 2)
|
|
selected = create(:budget_investment, :selected, heading: heading, price: 2, ballot_lines_count: 1)
|
|
|
|
visit edit_admin_budget_path(budget)
|
|
expect(page).not_to have_content "See results"
|
|
click_link "Calculate Winner Investments"
|
|
expect(page).to have_content "Winners being calculated, it may take a minute."
|
|
expect(page).to have_content winner.title
|
|
expect(page).not_to have_content unselected.title
|
|
expect(page).not_to have_content selected.title
|
|
|
|
visit edit_admin_budget_path(budget)
|
|
expect(page).to have_content "See results"
|
|
end
|
|
|
|
scenario "For a finished Budget" do
|
|
budget = create(:budget, :finished)
|
|
allow_any_instance_of(Budget).to receive(:has_winning_investments?).and_return(true)
|
|
|
|
visit edit_admin_budget_path(budget)
|
|
|
|
expect(page).to have_content "Calculate Winner Investments"
|
|
expect(page).to have_content "See results"
|
|
end
|
|
|
|
scenario "Recalculate for a finished Budget" do
|
|
budget = create(:budget, :finished)
|
|
create(:budget_investment, :winner, budget: budget)
|
|
|
|
visit edit_admin_budget_path(budget)
|
|
|
|
expect(page).to have_content "Recalculate Winner Investments"
|
|
expect(page).to have_content "See results"
|
|
expect(page).not_to have_content "Calculate Winner Investments"
|
|
|
|
visit admin_budget_budget_investments_path(budget)
|
|
click_link "Advanced filters"
|
|
check "Winners"
|
|
click_button "Filter"
|
|
|
|
expect(page).to have_content "Recalculate Winner Investments"
|
|
expect(page).not_to have_content "Calculate Winner Investments"
|
|
end
|
|
end
|
|
end
|