The word "budget" in the "Preview budget" link is redundant. On the other hand, the words "Manage", Edit" and "Admin" are not really necessary in my humble opinion. Just like in the admin navigation menu we use "Participatory budgets" instead of "Manage Participatory budgets", the fact that we're going to manage or admin or edit something can be deduced from the fact that we're in the admin section. Besides, it isn't clear to me why we use "Manage" for projects, "Edit" for heading groups and "Admin" for ballots. The differences between these three concepts might be too subtle for me. The previous paragraphs haven't been corroborated with real users, though, so I might be mistaken and we might need to revisit these links in the future. These actions still take quite a lot of space. Maybe in the future we could remove the "delete" icon, at least on budgets which cannot be deleted.
139 lines
4.8 KiB
Ruby
139 lines
4.8 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Budgets wizard, first step", :admin do
|
|
describe "New" do
|
|
scenario "Create budget - Knapsack voting (default)" do
|
|
visit admin_budgets_path
|
|
click_button "Create new budget"
|
|
click_link "Create multiple headings budget"
|
|
|
|
fill_in "Name", with: "M30 - Summer campaign"
|
|
fill_in "Text on the link", with: "Participate now!"
|
|
fill_in "The link takes you to (add a link)", with: "https://consulproject.org"
|
|
fill_in "Name", with: "M30 - Summer campaign"
|
|
click_button "Continue to groups"
|
|
|
|
expect(page).to have_content "New participatory budget created successfully!"
|
|
|
|
click_link "Go back to edit budget"
|
|
|
|
expect(page).to have_field "Name", with: "M30 - Summer campaign"
|
|
expect(page).to have_select "Final voting style", selected: "Knapsack"
|
|
end
|
|
|
|
scenario "Create budget - Approval voting" do
|
|
admin = Administrator.first
|
|
|
|
visit admin_budgets_path
|
|
click_button "Create new budget"
|
|
click_link "Create multiple headings budget"
|
|
|
|
fill_in "Name", with: "M30 - Summer campaign"
|
|
select "Approval", from: "Final voting style"
|
|
click_button "Continue to groups"
|
|
|
|
expect(page).to have_content "New participatory budget created successfully!"
|
|
|
|
click_link "Go back to edit budget"
|
|
|
|
expect(page).to have_field "Name", with: "M30 - Summer campaign"
|
|
expect(page).to have_select "Final voting style", selected: "Approval"
|
|
|
|
click_link "Select administrators"
|
|
|
|
expect(page).to have_field admin.name
|
|
end
|
|
|
|
scenario "Submit the form with errors" do
|
|
visit new_admin_budgets_wizard_budget_path
|
|
click_button "Continue to groups"
|
|
|
|
expect(page).not_to have_content "New participatory budget created successfully!"
|
|
expect(page).to have_css ".is-invalid-label", text: "Name"
|
|
expect(page).to have_css ".creation-timeline"
|
|
end
|
|
|
|
scenario "Name should be unique" do
|
|
create(:budget, name: "Existing Name")
|
|
|
|
visit new_admin_budgets_wizard_budget_path
|
|
fill_in "Name", with: "Existing Name"
|
|
click_button "Continue to groups"
|
|
|
|
expect(page).not_to have_content "New participatory budget created successfully!"
|
|
expect(page).to have_css(".is-invalid-label", text: "Name")
|
|
expect(page).to have_css("small.form-error", text: "has already been taken")
|
|
end
|
|
|
|
scenario "Do not show results and stats settings on new budget" do
|
|
visit new_admin_budgets_wizard_budget_path
|
|
|
|
expect(page).not_to have_content "Show results and stats"
|
|
expect(page).not_to have_field "Show results"
|
|
expect(page).not_to have_field "Show stats"
|
|
expect(page).not_to have_field "Show advanced stats"
|
|
end
|
|
end
|
|
|
|
describe "Create" do
|
|
scenario "A new budget is always created in draft mode" do
|
|
visit admin_budgets_path
|
|
click_button "Create new budget"
|
|
click_link "Create multiple headings budget"
|
|
|
|
fill_in "Name", with: "M30 - Summer campaign"
|
|
|
|
click_button "Continue to groups"
|
|
|
|
expect(page).to have_content "New participatory budget created successfully!"
|
|
|
|
within("#side_menu") { click_link "Participatory budgets" }
|
|
within("tr", text: "M30 - Summer campaign") { click_link "Edit" }
|
|
|
|
expect(page).to have_content "This participatory budget is in draft mode"
|
|
expect(page).to have_link "Preview"
|
|
expect(page).to have_link "Publish budget"
|
|
end
|
|
end
|
|
|
|
describe "Edit" do
|
|
scenario "update budget" do
|
|
budget = create(:budget, name: "Budget wiht typo")
|
|
|
|
visit admin_budgets_wizard_budget_groups_path(budget)
|
|
|
|
click_link "Go back to edit budget"
|
|
|
|
expect(page).to have_content "Edit Participatory budget"
|
|
expect(page).to have_css ".creation-timeline"
|
|
expect(page).to have_field "Name", with: "Budget wiht typo"
|
|
|
|
fill_in "Name", with: "Budget without typos"
|
|
click_button "Continue to groups"
|
|
|
|
expect(page).to have_content "Participatory budget updated successfully"
|
|
expect(page).to have_content "Budget without typos"
|
|
expect(page).to have_css ".creation-timeline"
|
|
expect(page).to have_content "There are no groups"
|
|
end
|
|
|
|
scenario "submit the form with errors and then without errors" do
|
|
budget = create(:budget, name: "Budget wiht typo")
|
|
|
|
visit edit_admin_budgets_wizard_budget_path(budget)
|
|
fill_in "Name", with: ""
|
|
click_button "Continue to groups"
|
|
|
|
expect(page).to have_css "#error_explanation"
|
|
|
|
fill_in "Name", with: "Budget without typos"
|
|
click_button "Continue to groups"
|
|
|
|
expect(page).to have_content "Participatory budget updated successfully"
|
|
expect(page).to have_content "Budget without typos"
|
|
expect(page).to have_css ".creation-timeline"
|
|
expect(page).to have_content "There are no groups"
|
|
end
|
|
end
|
|
end
|