We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
85 lines
2.4 KiB
Ruby
85 lines
2.4 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Admin managers" do
|
|
let!(:user) { create(:user) }
|
|
let!(:manager) { create(:manager) }
|
|
|
|
before do
|
|
login_as(create(:administrator).user)
|
|
visit admin_managers_path
|
|
end
|
|
|
|
scenario "Index" do
|
|
expect(page).to have_content manager.name
|
|
expect(page).to have_content manager.email
|
|
expect(page).not_to have_content user.name
|
|
end
|
|
|
|
scenario "Create Manager", :js do
|
|
fill_in "name_or_email", with: user.email
|
|
click_button "Search"
|
|
|
|
expect(page).to have_content user.name
|
|
click_link "Add"
|
|
within("#managers") do
|
|
expect(page).to have_content user.name
|
|
end
|
|
end
|
|
|
|
scenario "Delete Manager" do
|
|
click_link "Delete"
|
|
|
|
within("#managers") do
|
|
expect(page).not_to have_content manager.name
|
|
end
|
|
end
|
|
|
|
context "Search" do
|
|
let(:user) { create(:user, username: "Taylor Swift", email: "taylor@swift.com") }
|
|
let(:user2) { create(:user, username: "Stephanie Corneliussen", email: "steph@mrrobot.com") }
|
|
let!(:manager1) { create(:manager, user: user) }
|
|
let!(:manager2) { create(:manager, user: user2) }
|
|
|
|
before do
|
|
visit admin_managers_path
|
|
end
|
|
|
|
scenario "returns no results if search term is empty" do
|
|
expect(page).to have_content(manager1.name)
|
|
expect(page).to have_content(manager2.name)
|
|
|
|
fill_in "name_or_email", with: " "
|
|
click_button "Search"
|
|
|
|
expect(page).to have_content("Managers: User search")
|
|
expect(page).to have_content("No results found")
|
|
expect(page).not_to have_content(manager1.name)
|
|
expect(page).not_to have_content(manager2.name)
|
|
end
|
|
|
|
scenario "search by name" do
|
|
expect(page).to have_content(manager1.name)
|
|
expect(page).to have_content(manager2.name)
|
|
|
|
fill_in "name_or_email", with: "Taylor"
|
|
click_button "Search"
|
|
|
|
expect(page).to have_content("Managers: User search")
|
|
expect(page).to have_content(manager1.name)
|
|
expect(page).not_to have_content(manager2.name)
|
|
end
|
|
|
|
scenario "search by email" do
|
|
expect(page).to have_content(manager1.email)
|
|
expect(page).to have_content(manager2.email)
|
|
|
|
fill_in "name_or_email", with: manager2.email
|
|
click_button "Search"
|
|
|
|
expect(page).to have_content("Managers: User search")
|
|
expect(page).to have_content(manager2.email)
|
|
expect(page).not_to have_content(manager1.email)
|
|
end
|
|
end
|
|
end
|