995f7036de
The main reason for this change is that Pronto doesn't run in pull requests opened by external contributors, and we haven't found how to fix this issue. Another reason is that Pronto only detects issues in the lines where the changes are done, but sometimes we introduce issues related to other lines and those aren't detected by Pronto. Also, when adding or changing Rubocop rules, or when we update Rubocop, Pronto doesn't check whether those rules are applied in every Ruby and ERB file, and we sometimes forget to do so (particularly in ERB files). So, from now, the linters will check all the code in every pull request. Note we're now excluding the `vendor` folder in our linters because the `setup-ruby` action actions generates a `vendor/bundle/` folder with all our gem dependencies, and we don't want to check those files.
41 lines
1.1 KiB
YAML
41 lines
1.1 KiB
YAML
name: linters
|
|
on: [pull_request]
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
linters:
|
|
runs-on: ubuntu-latest
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
include:
|
|
- name: RuboCop
|
|
run: bundle exec rubocop --fail-level convention --display-only-fail-level-offenses -f github
|
|
- name: ERB Lint
|
|
run: bundle exec erblint .
|
|
- name: ESLint
|
|
run: npx eslint . --quiet
|
|
- name: Stylelint
|
|
run: npx stylelint app/assets/stylesheets
|
|
name: ${{ matrix.name }}
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@v4
|
|
- run: |
|
|
git fetch --no-tags --prune origin +refs/heads/*:refs/remotes/origin/*
|
|
- name: Setup Ruby
|
|
uses: ruby/setup-ruby@v1
|
|
with:
|
|
bundler-cache: true
|
|
- name: Setup NPM
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
cache: "npm"
|
|
node-version-file: ".node-version"
|
|
- name: Install node packages
|
|
run: npm clean-install
|
|
- name: ${{ matrix.name }}
|
|
run: ${{ matrix.run }}
|