e0e35298d5
This fixes a few issues we've had for years. First, when attaching an image and then sending a form with validation errors, the image preview would not be rendered when the form was displayed once again. Now it's rendered as expected. Second, when attaching an image, removing it, and attaching a new one, browsers were displaying the image preview of the first one. That's because Paperclip generated the same URL from both files (as they both had the same hash data and prefix). Browsers usually cache images and render the cached image when getting the same URL. Since now we're storing each image in a different Blob, the images have different URLs and so the preview of the second one is correctly displayed. Finally, when users downloaded a document, they were getting files with a very long hexadecimal hash as filename. Now they get the original filename.
91 lines
3.2 KiB
Ruby
91 lines
3.2 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "active storage tasks" do
|
|
describe "migrate_from_paperclip" do
|
|
let(:run_rake_task) do
|
|
Rake::Task["active_storage:migrate_from_paperclip"].reenable
|
|
Rake.application.invoke_task("active_storage:migrate_from_paperclip")
|
|
end
|
|
|
|
let(:storage_root) { ActiveStorage::Blob.service.root }
|
|
before { FileUtils.rm_rf storage_root }
|
|
|
|
it "migrates records and attachments" do
|
|
document = build(:document,
|
|
attachment: nil,
|
|
paperclip_attachment: File.new("spec/fixtures/files/clippy.pdf"))
|
|
document.save(validate: false)
|
|
|
|
expect(ActiveStorage::Attachment.count).to eq 0
|
|
expect(ActiveStorage::Blob.count).to eq 0
|
|
expect(test_storage_file_paths.count).to eq 0
|
|
|
|
run_rake_task
|
|
document.reload
|
|
|
|
expect(ActiveStorage::Attachment.count).to eq 1
|
|
expect(ActiveStorage::Blob.count).to eq 1
|
|
expect(document.storage_attachment.filename).to eq "clippy.pdf"
|
|
expect(test_storage_file_paths.count).to eq 1
|
|
expect(storage_file_path(document)).to eq test_storage_file_paths.first
|
|
end
|
|
|
|
it "migrates records with deleted files ignoring the files" do
|
|
document = build(:document,
|
|
attachment: nil,
|
|
paperclip_attachment: File.new("spec/fixtures/files/clippy.pdf"))
|
|
document.save(validate: false)
|
|
FileUtils.rm(document.attachment.path)
|
|
|
|
run_rake_task
|
|
document.reload
|
|
|
|
expect(ActiveStorage::Attachment.count).to eq 1
|
|
expect(ActiveStorage::Blob.count).to eq 1
|
|
expect(document.storage_attachment.filename).to eq "clippy.pdf"
|
|
expect(test_storage_file_paths.count).to eq 0
|
|
end
|
|
|
|
it "does not migrate already migrated records" do
|
|
document = create(:document, attachment: File.new("spec/fixtures/files/clippy.pdf"))
|
|
|
|
migrated_file = test_storage_file_paths.first
|
|
attachment_id = document.storage_attachment.attachment.id
|
|
blob_id = document.storage_attachment.blob.id
|
|
|
|
run_rake_task
|
|
document.reload
|
|
|
|
expect(ActiveStorage::Attachment.count).to eq 1
|
|
expect(ActiveStorage::Blob.count).to eq 1
|
|
expect(document.storage_attachment.attachment.id).to eq attachment_id
|
|
expect(document.storage_attachment.blob.id).to eq blob_id
|
|
|
|
expect(test_storage_file_paths.count).to eq 1
|
|
expect(storage_file_path(document)).to eq migrated_file
|
|
expect(test_storage_file_paths.first).to eq migrated_file
|
|
end
|
|
|
|
it "does not migrate files for deleted records" do
|
|
document = create(:document, attachment: File.new("spec/fixtures/files/clippy.pdf"))
|
|
FileUtils.rm storage_file_path(document)
|
|
Document.delete_all
|
|
|
|
run_rake_task
|
|
|
|
expect(ActiveStorage::Attachment.count).to eq 1
|
|
expect(ActiveStorage::Blob.count).to eq 1
|
|
expect(document.storage_attachment.filename).to eq "clippy.pdf"
|
|
expect(test_storage_file_paths.count).to eq 0
|
|
end
|
|
|
|
def test_storage_file_paths
|
|
Dir.glob("#{storage_root}/**/*").select { |file_or_folder| File.file?(file_or_folder) }
|
|
end
|
|
|
|
def storage_file_path(record)
|
|
ActiveStorage::Blob.service.path_for(record.storage_attachment.blob.key)
|
|
end
|
|
end
|
|
end
|