88cde6d018
We were seeing an exception when a user was following a proposal and
that proposal becomes hidden
With this commit we are skipping this proposals and hopefully fixing
this exception
We are also adjusting the count of followed proposals, without
including hidden proposals. It might be cleaner, to remove a `Follow`
when its `Followable` becomes hidden. But then we should probably
activate the `Follow` again if the `Followable` becomes non-hidden…
For now this commit should suffice 😌
106 lines
3.4 KiB
Ruby
106 lines
3.4 KiB
Ruby
class UsersController < ApplicationController
|
|
has_filters %w{proposals debates budget_investments comments follows}, only: :show
|
|
|
|
load_and_authorize_resource
|
|
helper_method :author?
|
|
helper_method :valid_interests_access?
|
|
|
|
def show
|
|
load_filtered_activity if valid_access?
|
|
end
|
|
|
|
private
|
|
|
|
def set_activity_counts
|
|
@activity_counts = HashWithIndifferentAccess.new(
|
|
proposals: Proposal.where(author_id: @user.id).count,
|
|
debates: (Setting['feature.debates'] ? Debate.where(author_id: @user.id).count : 0),
|
|
budget_investments: (Setting['feature.budgets'] ? Budget::Investment.where(author_id: @user.id).count : 0),
|
|
comments: only_active_commentables.count,
|
|
follows: @user.follows.map(&:followable).compact.count)
|
|
end
|
|
|
|
def load_filtered_activity
|
|
set_activity_counts
|
|
case params[:filter]
|
|
when "proposals" then load_proposals
|
|
when "debates" then load_debates
|
|
when "budget_investments" then load_budget_investments
|
|
when "comments" then load_comments
|
|
when "follows" then load_follows
|
|
else load_available_activity
|
|
end
|
|
end
|
|
|
|
def load_available_activity
|
|
if @activity_counts[:proposals] > 0
|
|
load_proposals
|
|
@current_filter = "proposals"
|
|
elsif @activity_counts[:debates] > 0
|
|
load_debates
|
|
@current_filter = "debates"
|
|
elsif @activity_counts[:budget_investments] > 0
|
|
load_budget_investments
|
|
@current_filter = "budget_investments"
|
|
elsif @activity_counts[:comments] > 0
|
|
load_comments
|
|
@current_filter = "comments"
|
|
elsif @activity_counts[:follows] > 0
|
|
load_follows
|
|
@current_filter = "follows"
|
|
end
|
|
end
|
|
|
|
def load_proposals
|
|
@proposals = Proposal.where(author_id: @user.id).order(created_at: :desc).page(params[:page])
|
|
end
|
|
|
|
def load_debates
|
|
@debates = Debate.where(author_id: @user.id).order(created_at: :desc).page(params[:page])
|
|
end
|
|
|
|
def load_comments
|
|
@comments = only_active_commentables.includes(:commentable).order(created_at: :desc).page(params[:page])
|
|
end
|
|
|
|
def load_budget_investments
|
|
@budget_investments = Budget::Investment.where(author_id: @user.id).order(created_at: :desc).page(params[:page])
|
|
end
|
|
|
|
def load_follows
|
|
@follows = @user.follows.group_by(&:followable_type)
|
|
end
|
|
|
|
def valid_access?
|
|
@user.public_activity || authorized_current_user?
|
|
end
|
|
|
|
def valid_interests_access?
|
|
@user.public_interests || authorized_current_user?
|
|
end
|
|
|
|
def author?(proposal)
|
|
proposal.author_id == current_user.id if current_user
|
|
end
|
|
|
|
def authorized_current_user?
|
|
@authorized_current_user ||= current_user && (current_user == @user || current_user.moderator? || current_user.administrator?)
|
|
end
|
|
|
|
def all_user_comments
|
|
Comment.not_valuations.not_as_admin_or_moderator.where(user_id: @user.id)
|
|
end
|
|
|
|
def only_active_commentables
|
|
disabled_commentables = []
|
|
disabled_commentables << "Debate" unless Setting['feature.debates']
|
|
disabled_commentables << "Budget::Investment" unless Setting['feature.budgets']
|
|
if disabled_commentables.present?
|
|
all_user_comments.where("commentable_type NOT IN (?)", disabled_commentables)
|
|
else
|
|
all_user_comments
|
|
end
|
|
end
|
|
|
|
end
|