We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
28 lines
775 B
Ruby
28 lines
775 B
Ruby
# coding: utf-8
|
|
require "rails_helper"
|
|
|
|
describe "Proposal ballots" do
|
|
scenario "Successful proposals do not show support buttons in index" do
|
|
successful_proposals = create_successful_proposals
|
|
|
|
visit proposals_path
|
|
|
|
successful_proposals.each do |proposal|
|
|
within("#proposal_#{proposal.id}_votes .supports .progress") do
|
|
expect(page).to have_content "100% / 100%"
|
|
end
|
|
end
|
|
end
|
|
|
|
scenario "Successful proposals do not show support buttons in show" do
|
|
successful_proposals = create_successful_proposals
|
|
|
|
successful_proposals.each do |proposal|
|
|
visit proposal_path(proposal)
|
|
within("#proposal_#{proposal.id}_votes .supports .progress") do
|
|
expect(page).to have_content "100% / 100%"
|
|
end
|
|
end
|
|
end
|
|
end
|