d7e6a5c6bf
This is something we should do everywhere because concurrent requests might bypass Rails uniqueness validations. However, since there are places where we aren't applying this rule and adding a unique index means we also need to destroy any hypothetical duplicate records, it's something we aren't going to solve right now. Therefore we use the "refactor" severity so existing offenses don't get in our way. In any case, we're adding the rule so we don't make the same mistake in the future.
473 lines
7.0 KiB
YAML
473 lines
7.0 KiB
YAML
require:
|
|
- rubocop-performance
|
|
- rubocop-rails
|
|
- rubocop-rspec
|
|
|
|
AllCops:
|
|
DisplayCopNames: true
|
|
DisplayStyleGuide: true
|
|
Exclude:
|
|
- "db/schema.rb"
|
|
DisabledByDefault: true
|
|
|
|
Bundler/DuplicatedGem:
|
|
Enabled: true
|
|
|
|
Bundler/OrderedGems:
|
|
Enabled: true
|
|
ConsiderPunctuation: true
|
|
|
|
Capybara/CurrentPathExpectation:
|
|
Enabled: true
|
|
|
|
Capybara/FeatureMethods:
|
|
Enabled: true
|
|
EnabledMethods:
|
|
- scenario
|
|
- xscenario
|
|
|
|
Capybara/VisibilityMatcher:
|
|
Enabled: true
|
|
|
|
FactoryBot/AttributeDefinedStatically:
|
|
Enabled: true
|
|
|
|
FactoryBot/FactoryClassName:
|
|
Enabled: true
|
|
|
|
Layout/AssignmentIndentation:
|
|
Enabled: true
|
|
|
|
Layout/EmptyLineAfterGuardClause:
|
|
Enabled: true
|
|
|
|
Layout/EmptyLineBetweenDefs:
|
|
Enabled: true
|
|
|
|
Layout/EmptyLines:
|
|
Enabled: true
|
|
|
|
Layout/EmptyLinesAroundAccessModifier:
|
|
Enabled: true
|
|
|
|
Layout/EmptyLinesAroundBlockBody:
|
|
Enabled: true
|
|
|
|
Layout/EmptyLinesAroundClassBody:
|
|
Enabled: true
|
|
|
|
Layout/EmptyLinesAroundMethodBody:
|
|
Enabled: true
|
|
|
|
Layout/EmptyLinesAroundModuleBody:
|
|
Enabled: true
|
|
|
|
Layout/EndOfLine:
|
|
EnforcedStyle: lf
|
|
|
|
Layout/ExtraSpacing:
|
|
Enabled: true
|
|
|
|
Layout/HeredocIndentation:
|
|
Enabled: true
|
|
|
|
Layout/IndentationConsistency:
|
|
EnforcedStyle: indented_internal_methods
|
|
|
|
Layout/IndentationStyle:
|
|
Enabled: true
|
|
|
|
Layout/IndentationWidth:
|
|
Enabled: true
|
|
|
|
Layout/LeadingEmptyLines:
|
|
Enabled: true
|
|
|
|
Layout/LineLength:
|
|
Max: 110
|
|
Severity: refactor
|
|
|
|
Layout/MultilineBlockLayout:
|
|
Enabled: true
|
|
|
|
Layout/SpaceAfterColon:
|
|
Enabled: true
|
|
|
|
Layout/SpaceAfterComma:
|
|
Enabled: true
|
|
|
|
Layout/SpaceAfterMethodName:
|
|
Enabled: true
|
|
|
|
Layout/SpaceAfterNot:
|
|
Enabled: true
|
|
|
|
Layout/SpaceAfterSemicolon:
|
|
Enabled: true
|
|
|
|
Layout/SpaceAroundBlockParameters:
|
|
Enabled: true
|
|
|
|
Layout/SpaceAroundEqualsInParameterDefault:
|
|
Enabled: true
|
|
|
|
Layout/SpaceAroundMethodCallOperator:
|
|
Enabled: true
|
|
|
|
Layout/SpaceAroundOperators:
|
|
Enabled: true
|
|
|
|
Layout/SpaceBeforeBlockBraces:
|
|
Enabled: true
|
|
|
|
Layout/SpaceBeforeComma:
|
|
Enabled: true
|
|
|
|
Layout/SpaceBeforeComment:
|
|
Enabled: true
|
|
|
|
Layout/SpaceBeforeFirstArg:
|
|
Enabled: true
|
|
|
|
Layout/SpaceBeforeSemicolon:
|
|
Enabled: true
|
|
|
|
Layout/SpaceInLambdaLiteral:
|
|
Enabled: true
|
|
|
|
Layout/SpaceInsideArrayLiteralBrackets:
|
|
Enabled: true
|
|
|
|
Layout/SpaceInsideArrayPercentLiteral:
|
|
Enabled: true
|
|
|
|
Layout/SpaceInsideBlockBraces:
|
|
Enabled: true
|
|
|
|
Layout/SpaceInsideHashLiteralBraces:
|
|
Enabled: true
|
|
EnforcedStyle: compact
|
|
|
|
Layout/SpaceInsideParens:
|
|
Enabled: true
|
|
|
|
Layout/SpaceInsidePercentLiteralDelimiters:
|
|
Enabled: true
|
|
|
|
Layout/SpaceInsideRangeLiteral:
|
|
Enabled: true
|
|
|
|
Layout/SpaceInsideReferenceBrackets:
|
|
Enabled: true
|
|
|
|
Layout/SpaceInsideStringInterpolation:
|
|
Enabled: true
|
|
|
|
Layout/TrailingEmptyLines:
|
|
Enabled: true
|
|
|
|
Layout/TrailingWhitespace:
|
|
Enabled: true
|
|
|
|
Lint/AmbiguousRegexpLiteral:
|
|
Enabled: true
|
|
|
|
Lint/ConstantDefinitionInBlock:
|
|
Enabled: true
|
|
|
|
Lint/DuplicateMethods:
|
|
Enabled: true
|
|
|
|
Lint/EmptyFile:
|
|
Enabled: true
|
|
|
|
Lint/LiteralAsCondition:
|
|
Enabled: true
|
|
|
|
Lint/ParenthesesAsGroupedExpression:
|
|
Enabled: true
|
|
|
|
Lint/RedundantStringCoercion:
|
|
Enabled: true
|
|
|
|
Lint/SafeNavigationChain:
|
|
Enabled: true
|
|
|
|
Lint/ShadowingOuterLocalVariable:
|
|
Enabled: true
|
|
|
|
Lint/UselessAssignment:
|
|
Enabled: true
|
|
|
|
Lint/Void:
|
|
Enabled: true
|
|
|
|
Performance/CompareWithBlock:
|
|
Enabled: true
|
|
|
|
Performance/DoubleStartEndWith:
|
|
Enabled: true
|
|
|
|
Performance/EndWith:
|
|
Enabled: true
|
|
|
|
Performance/StartWith:
|
|
Enabled: true
|
|
|
|
Rails/CreateTableWithTimestamps:
|
|
Enabled: true
|
|
Exclude:
|
|
- "db/migrate/201[5-8]*"
|
|
- "db/migrate/*install_audited.rb"
|
|
|
|
Rails/Date:
|
|
Enabled: true
|
|
|
|
Rails/DynamicFindBy:
|
|
Enabled: true
|
|
Whitelist:
|
|
- find_by_slug_or_id
|
|
- find_by_slug_or_id!
|
|
- find_by_manager_login
|
|
|
|
Rails/EnumUniqueness:
|
|
Enabled: true
|
|
|
|
Rails/EnvironmentComparison:
|
|
Enabled: true
|
|
|
|
Rails/FindBy:
|
|
Enabled: true
|
|
Include:
|
|
- "**/*.rb"
|
|
|
|
Rails/FindEach:
|
|
Enabled: true
|
|
|
|
Rails/HasAndBelongsToMany:
|
|
Enabled: true
|
|
|
|
Rails/HasManyOrHasOneDependent:
|
|
Enabled: true
|
|
Severity: refactor
|
|
|
|
Rails/InverseOf:
|
|
Enabled: true
|
|
Exclude:
|
|
- "app/models/related_content.rb"
|
|
|
|
Rails/NotNullColumn:
|
|
Enabled: true
|
|
Exclude:
|
|
- "db/migrate/201[5-7]*"
|
|
|
|
Rails/OutputSafety:
|
|
Enabled: true
|
|
Severity: warning
|
|
Exclude:
|
|
- app/helpers/text_with_links_helper.rb
|
|
|
|
Rails/PluralizationGrammar:
|
|
Enabled: true
|
|
|
|
Rails/Presence:
|
|
Enabled: true
|
|
|
|
Rails/RelativeDateConstant:
|
|
Enabled: true
|
|
|
|
Rails/RequestReferer:
|
|
Enabled: true
|
|
|
|
Rails/ReversibleMigration:
|
|
Enabled: true
|
|
|
|
Rails/SafeNavigation:
|
|
Enabled: true
|
|
ConvertTry: true
|
|
|
|
Rails/SaveBang:
|
|
Enabled: true
|
|
Severity: refactor
|
|
|
|
Rails/SkipsModelValidations:
|
|
Enabled: true
|
|
Blacklist:
|
|
- update_attribute
|
|
Exclude:
|
|
- lib/acts_as_paranoid_aliases.rb
|
|
|
|
Rails/TimeZone:
|
|
Enabled: true
|
|
|
|
Rails/UniqueValidationWithoutIndex:
|
|
Enabled: true
|
|
Severity: refactor
|
|
|
|
Rails/UnknownEnv:
|
|
Enabled: true
|
|
Environments:
|
|
- development
|
|
- test
|
|
- production
|
|
- preproduction
|
|
- staging
|
|
|
|
Rails/Validation:
|
|
Enabled: true
|
|
|
|
RSpec/AroundBlock:
|
|
Enabled: true
|
|
|
|
RSpec/BeforeAfterAll:
|
|
Enabled: true
|
|
|
|
RSpec/ContextMethod:
|
|
Enabled: true
|
|
|
|
RSpec/DescribedClass:
|
|
Enabled: true
|
|
EnforcedStyle: explicit
|
|
|
|
RSpec/EmptyExampleGroup:
|
|
Enabled: true
|
|
Exclude:
|
|
- spec/factories/**/*
|
|
|
|
RSpec/EmptyHook:
|
|
Enabled: true
|
|
|
|
RSpec/EmptyLineAfterExample:
|
|
Enabled: true
|
|
|
|
RSpec/EmptyLineAfterExampleGroup:
|
|
Enabled: true
|
|
Exclude:
|
|
- spec/factories/**/*
|
|
|
|
RSpec/ExampleWording:
|
|
Enabled: true
|
|
|
|
RSpec/Focus:
|
|
Enabled: true
|
|
|
|
RSpec/HookArgument:
|
|
Enabled: true
|
|
|
|
RSpec/InstanceVariable:
|
|
Enabled: true
|
|
Exclude:
|
|
- spec/controllers/concerns/has_filters_spec.rb
|
|
- spec/controllers/concerns/has_orders_spec.rb
|
|
|
|
RSpec/LetBeforeExamples:
|
|
Enabled: true
|
|
|
|
RSpec/LetSetup:
|
|
Enabled: true
|
|
|
|
RSpec/NotToNot:
|
|
Enabled: true
|
|
|
|
RSpec/OverwritingSetup:
|
|
Enabled: true
|
|
|
|
RSpec/RepeatedExample:
|
|
Enabled: true
|
|
|
|
RSpec/RepeatedExampleGroupBody:
|
|
Enabled: true
|
|
|
|
RSpec/RepeatedExampleGroupDescription:
|
|
Enabled: true
|
|
|
|
RSpec/ScatteredLet:
|
|
Enabled: true
|
|
|
|
RSpec/ScatteredSetup:
|
|
Enabled: true
|
|
|
|
RSpec/VoidExpect:
|
|
Enabled: true
|
|
|
|
Security/Eval:
|
|
Enabled: true
|
|
|
|
Security/JSONLoad:
|
|
Enabled: true
|
|
|
|
Security/YAMLLoad:
|
|
Enabled: true
|
|
|
|
Style/AccessorGrouping:
|
|
Enabled: true
|
|
|
|
Style/AndOr:
|
|
Enabled: true
|
|
|
|
Style/ArrayCoercion:
|
|
Enabled: true
|
|
|
|
Style/BlockDelimiters:
|
|
Enabled: true
|
|
|
|
Style/ClassCheck:
|
|
Enabled: true
|
|
|
|
Style/ClassVars:
|
|
Enabled: true
|
|
|
|
Style/CollectionMethods:
|
|
Enabled: true
|
|
|
|
Style/HashSyntax:
|
|
Enabled: true
|
|
|
|
Style/IdenticalConditionalBranches:
|
|
Enabled: true
|
|
|
|
Style/MethodDefParentheses:
|
|
Enabled: true
|
|
|
|
Style/MutableConstant:
|
|
Enabled: true
|
|
|
|
Style/Not:
|
|
Enabled: true
|
|
|
|
Style/OrAssignment:
|
|
Enabled: true
|
|
|
|
Style/PercentLiteralDelimiters:
|
|
Enabled: true
|
|
|
|
Style/Proc:
|
|
Enabled: true
|
|
|
|
Style/RedundantFileExtensionInRequire:
|
|
Enabled: true
|
|
|
|
Style/RedundantFreeze:
|
|
Enabled: true
|
|
|
|
Style/RedundantReturn:
|
|
Enabled: true
|
|
|
|
Style/SafeNavigation:
|
|
Enabled: true
|
|
|
|
Style/StringLiterals:
|
|
EnforcedStyle: double_quotes
|
|
|
|
Style/StringLiteralsInInterpolation:
|
|
EnforcedStyle: double_quotes
|
|
|
|
Style/SymbolProc:
|
|
Enabled: true
|
|
|
|
Style/TrailingCommaInArrayLiteral:
|
|
Enabled: true
|
|
|
|
Style/TrailingCommaInHashLiteral:
|
|
Enabled: true
|