d0d1c9972c
There's a very common pattern in our test, where the setup only has two lines: variable = create(:something) unused_variable = create(:something_else, something: variable) In this case, since there's a blank line below these ones and then we'll get to the body of the test, and the second variable is going to be created based on the first variable, we can remove the useless assignment and the readability is still OK. Another option we almost unanimously discarded was: variable = create(:something) _unused_variable = create(:something_else, something: variable) We don't use it anywhere else, either. One more option we considered but found a bit too much for simple tests: variable = create(:something) do |something| create(:something_else, something: variable) end Then of course we could move the setup to `let` and `before` blocks, but the tests could get over-structured really quickly.
564 lines
21 KiB
Ruby
564 lines
21 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Proposal's dashboard" do
|
|
let!(:proposal) { create(:proposal, :draft) }
|
|
|
|
before do
|
|
login_as(proposal.author)
|
|
visit proposal_dashboard_path(proposal)
|
|
end
|
|
|
|
scenario "Dashboard has a link to my proposal" do
|
|
expect(page).to have_link("Edit my proposal")
|
|
end
|
|
|
|
scenario "My proposal has a link to edit the proposal" do
|
|
expect(page).to have_link("Edit proposal")
|
|
end
|
|
|
|
scenario "My proposal has a link to retire the proposal" do
|
|
expect(page).to have_link("Retire proposal")
|
|
end
|
|
|
|
scenario "My proposal has a link to publish the proposal" do
|
|
expect(page).to have_link("Publish proposal")
|
|
end
|
|
|
|
scenario "Publish link dissapears after proposal's publication" do
|
|
click_link "Publish proposal"
|
|
expect(page).not_to have_link("Publish proposal")
|
|
end
|
|
|
|
scenario "Dashboard progress shows current goal", js: true do
|
|
goal = create(:dashboard_action, :resource, :active,
|
|
required_supports: proposal.votes_for.size + 1_000)
|
|
future_goal = create(:dashboard_action, :resource, :active,
|
|
required_supports: proposal.votes_for.size + 2_000)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
within "div#goals-section" do
|
|
expect(page).to have_content(goal.title)
|
|
expect(page).not_to have_content(future_goal.title)
|
|
|
|
find(:css, "#see_complete_course_link").click
|
|
|
|
expect(page).to have_content(goal.title)
|
|
expect(page).to have_content(future_goal.title)
|
|
end
|
|
end
|
|
|
|
scenario "Dashboard progress show proposed actions" do
|
|
action = create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
expect(page).to have_content(action.title)
|
|
end
|
|
|
|
scenario "Dashboard progress show proposed actions truncated description" do
|
|
action = create(:dashboard_action, :proposed_action, :active, description: "One short action")
|
|
action_long = create(:dashboard_action, :proposed_action, :active,
|
|
description: "This is a really very long description for a proposed "\
|
|
"action on progress dashboard section, so this description "\
|
|
"should be appear truncated and shows the show description "\
|
|
"link to show the complete description to the users.")
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
expect(page).to have_content(action.description)
|
|
expect(page).to have_content("This is a really very long description for a proposed")
|
|
expect(page).to have_selector("#truncated_description_dashboard_action_#{action_long.id}")
|
|
expect(page).to have_selector("a", text: "Show description")
|
|
end
|
|
|
|
scenario "Dashboard progress do not display from the fourth proposed actions", js: true do
|
|
create_list(:dashboard_action, 4, :proposed_action, :active)
|
|
action_5 = create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
expect(page).not_to have_content(action_5.title)
|
|
end
|
|
|
|
scenario "Dashboard progress display link to new page for proposed actions when
|
|
there are more than four proposed actions", js: true do
|
|
create_list(:dashboard_action, 4, :proposed_action, :active)
|
|
create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
expect(page).to have_link("Go to recommended actions")
|
|
end
|
|
|
|
scenario "Dashboard progress do not display link to new page for proposed actions
|
|
when there are less than five proposed actions", js: true do
|
|
create_list(:dashboard_action, 4, :proposed_action, :active)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
expect(page).not_to have_link("Check out recommended actions")
|
|
end
|
|
|
|
scenario "Dashboard progress display proposed_action pending on his section" do
|
|
action = create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
within "#proposed_actions_pending" do
|
|
expect(page).to have_content(action.title)
|
|
end
|
|
end
|
|
|
|
scenario "Dashboard progress display proposed_action done on his section" do
|
|
action = create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
find(:css, "#dashboard_action_#{action.id}_execute").click
|
|
|
|
within "#proposed_actions_done" do
|
|
expect(page).to have_content(action.title)
|
|
end
|
|
end
|
|
|
|
scenario "Dashboard progress can execute proposed action" do
|
|
action = create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
expect(page).to have_content(action.title)
|
|
|
|
find(:css, "#dashboard_action_#{action.id}_execute").click
|
|
expect(page).not_to have_selector(:css, "#dashboard_action_#{action.id}_execute")
|
|
end
|
|
|
|
scenario "Dashboard progress can unexecute proposed action" do
|
|
action = create(:dashboard_action, :proposed_action, :active)
|
|
create(:dashboard_executed_action, proposal: proposal, action: action)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
expect(page).to have_content(action.title)
|
|
|
|
find(:css, "#dashboard_action_#{action.id}_unexecute").click
|
|
expect(page).to have_selector(:css, "#dashboard_action_#{action.id}_execute")
|
|
end
|
|
|
|
scenario "Dashboard progress dont show proposed actions with published_proposal: true" do
|
|
action = create(:dashboard_action, :proposed_action, :active, published_proposal: true)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
expect(page).not_to have_content(action.title)
|
|
end
|
|
|
|
scenario "Dashboard progress show available resources for proposal draft" do
|
|
available = create(:dashboard_action, :resource, :active)
|
|
|
|
requested = create(:dashboard_action, :resource, :admin_request, :active)
|
|
executed_action = create(:dashboard_executed_action, action: requested,
|
|
proposal: proposal, executed_at: Time.current)
|
|
_task = create(:dashboard_administrator_task, :pending, source: executed_action)
|
|
|
|
solved = create(:dashboard_action, :resource, :admin_request, :active)
|
|
executed_solved_action = create(:dashboard_executed_action, action: solved,
|
|
proposal: proposal, executed_at: Time.current)
|
|
_solved_task = create(:dashboard_administrator_task, :done, source: executed_solved_action)
|
|
|
|
unavailable = create(:dashboard_action, :resource, :active,
|
|
required_supports: proposal.votes_for.size + 1_000)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
within "div#available-resources-section" do
|
|
expect(page).to have_content("Polls")
|
|
expect(page).to have_content("E-mail")
|
|
expect(page).to have_content("Poster")
|
|
expect(page).to have_content(available.title)
|
|
expect(page).to have_content(unavailable.title)
|
|
expect(page).to have_content(requested.title)
|
|
expect(page).to have_content(solved.title)
|
|
|
|
within "div#dashboard_action_#{available.id}" do
|
|
expect(page).to have_link("Request resource")
|
|
end
|
|
|
|
within "div#dashboard_action_#{requested.id}" do
|
|
expect(page).to have_content("Resource already requested")
|
|
end
|
|
|
|
within "div#dashboard_action_#{unavailable.id}" do
|
|
expect(page).to have_content("1.000 supports required")
|
|
end
|
|
|
|
within "div#dashboard_action_#{solved.id}" do
|
|
expect(page).to have_link("See resource")
|
|
end
|
|
end
|
|
end
|
|
|
|
scenario "Dashboard progress show available resources for published proposal" do
|
|
proposal.update(published_at: Date.current)
|
|
available = create(:dashboard_action, :resource, :active)
|
|
|
|
requested = create(:dashboard_action, :resource, :admin_request, :active)
|
|
executed_action = create(:dashboard_executed_action, action: requested,
|
|
proposal: proposal, executed_at: Time.current)
|
|
_task = create(:dashboard_administrator_task, :pending, source: executed_action)
|
|
|
|
solved = create(:dashboard_action, :resource, :admin_request, :active)
|
|
executed_solved_action = create(:dashboard_executed_action, action: solved,
|
|
proposal: proposal, executed_at: Time.current)
|
|
_solved_task = create(:dashboard_administrator_task, :done, source: executed_solved_action)
|
|
|
|
unavailable = create(:dashboard_action, :resource, :active,
|
|
required_supports: proposal.votes_for.size + 1_000)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
within "div#available-resources-section" do
|
|
expect(page).to have_content("Polls")
|
|
expect(page).to have_content("E-mail")
|
|
expect(page).to have_content("Poster")
|
|
expect(page).to have_content(available.title)
|
|
expect(page).to have_content(unavailable.title)
|
|
expect(page).to have_content(requested.title)
|
|
expect(page).to have_content(solved.title)
|
|
|
|
within "div#dashboard_action_#{available.id}" do
|
|
expect(page).to have_link("Request resource")
|
|
end
|
|
|
|
within "div#dashboard_action_#{requested.id}" do
|
|
expect(page).to have_content("Resource already requested")
|
|
end
|
|
|
|
within "div#dashboard_action_#{unavailable.id}" do
|
|
expect(page).to have_content("1.000 supports required")
|
|
end
|
|
|
|
within "div#dashboard_action_#{solved.id}" do
|
|
expect(page).to have_link("See resource")
|
|
end
|
|
end
|
|
end
|
|
|
|
scenario "Dashboard progress dont show resources with published_proposal: true" do
|
|
available = create(:dashboard_action, :resource, :active, published_proposal: true)
|
|
unavailable = create(:dashboard_action, :resource, :active,
|
|
required_supports: proposal.votes_for.size + 1_000,
|
|
published_proposal: true)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
within "div#available-resources-section" do
|
|
expect(page).to have_content("Polls")
|
|
expect(page).to have_content("E-mail")
|
|
expect(page).to have_content("Poster")
|
|
expect(page).not_to have_content(available.title)
|
|
expect(page).not_to have_content(unavailable.title)
|
|
end
|
|
end
|
|
|
|
scenario "Dashboard has a link to polls feature" do
|
|
expect(page).to have_link("Polls")
|
|
end
|
|
|
|
scenario "Dashboard has a link to e-mail feature" do
|
|
expect(page).to have_link("E-mail")
|
|
end
|
|
|
|
scenario "Dashboard has a link to poster feature" do
|
|
expect(page).to have_link("Poster")
|
|
end
|
|
|
|
scenario "Dashboard has a link to resources on main menu" do
|
|
feature = create(:dashboard_action, :resource, :active)
|
|
|
|
visit proposal_dashboard_path(proposal)
|
|
expect(page).to have_link(feature.title)
|
|
end
|
|
|
|
scenario "Request resource with admin request", js: true do
|
|
feature = create(:dashboard_action, :resource, :active, :admin_request)
|
|
|
|
visit proposal_dashboard_path(proposal)
|
|
click_link(feature.title)
|
|
|
|
click_button "Request"
|
|
expect(page).to have_content("The request has been successfully sent. We will contact you "\
|
|
"as soon as possible to inform you about it.")
|
|
end
|
|
|
|
scenario "Request already requested resource with admin request", js: true do
|
|
feature = create(:dashboard_action, :resource, :active, :admin_request)
|
|
|
|
visit proposal_dashboard_path(proposal)
|
|
click_link(feature.title)
|
|
|
|
create(:dashboard_executed_action, action: feature, proposal: proposal)
|
|
|
|
click_button "Request"
|
|
expect(page).to have_content("Proposal has already been taken")
|
|
end
|
|
|
|
scenario "Resource requested show message instead of button" do
|
|
feature = create(:dashboard_action, :resource, :active, :admin_request)
|
|
|
|
visit proposal_dashboard_path(proposal)
|
|
within("#side_menu") do
|
|
click_link(feature.title)
|
|
end
|
|
click_button "Request"
|
|
|
|
expect(page).to have_content("The request has been successfully sent. We will contact you "\
|
|
"as soon as possible to inform you about it.")
|
|
end
|
|
|
|
scenario "Resource without admin request do not have a request link", js: true do
|
|
feature = create(:dashboard_action, :resource, :active)
|
|
|
|
visit proposal_dashboard_path(proposal)
|
|
click_link(feature.title)
|
|
|
|
expect(page).not_to have_button("Request")
|
|
end
|
|
|
|
scenario "Resource admin request button do not appear on archived proposals" do
|
|
feature = create(:dashboard_action, :resource, :active)
|
|
archived = Setting["months_to_archive_proposals"].to_i.months.ago
|
|
archived_proposal = create(:proposal, created_at: archived)
|
|
|
|
login_as(archived_proposal.author)
|
|
visit proposal_dashboard_path(archived_proposal)
|
|
|
|
within("#side_menu") do
|
|
click_link(feature.title)
|
|
end
|
|
|
|
expect(page).not_to have_button("Request")
|
|
expect(page).to have_content("This proposal is archived and can not request resources.")
|
|
end
|
|
|
|
scenario "Dashboard has a link to dashboard community", js: true do
|
|
expect(page).to have_link("Community")
|
|
click_link "Community"
|
|
|
|
expect(page).to have_content("Participants")
|
|
expect(page).to have_content("Debates")
|
|
expect(page).to have_content("Comments")
|
|
expect(page).to have_link("Access the community")
|
|
end
|
|
|
|
scenario "Dashboard has a link to recommended_actions if there is any", js: true do
|
|
expect(page).not_to have_link("Recommended actions")
|
|
|
|
create_list(:dashboard_action, 3, :proposed_action, :active)
|
|
visit recommended_actions_proposal_dashboard_path(proposal.to_param)
|
|
|
|
expect(page).to have_link("Recommended actions")
|
|
expect(page).to have_selector("h2", text: "Recommended actions")
|
|
expect(page).to have_content("Pending")
|
|
expect(page).to have_content("Done")
|
|
end
|
|
|
|
scenario "Dashboard has a link to messages" do
|
|
expect(page).to have_link("Message to users")
|
|
|
|
within("#side_menu") do
|
|
click_link "Message to users"
|
|
end
|
|
|
|
expect(page).to have_link("Send message to proposal supporters")
|
|
expect(page).to have_link("See previous notifications")
|
|
end
|
|
|
|
scenario "Dashboard has a link to send message to proposal supporters" do
|
|
visit messages_proposal_dashboard_path(proposal)
|
|
click_link("Send message to proposal supporters")
|
|
|
|
fill_in "Title", with: "Thank you for supporting my proposal"
|
|
fill_in "Message", with: "Please share it with others!"
|
|
click_button "Send message"
|
|
|
|
expect(page).to have_content "Your message has been sent correctly."
|
|
expect(page).to have_content "Thank you for supporting my proposal"
|
|
expect(page).to have_content "Please share it with others!"
|
|
end
|
|
|
|
scenario "Dashboard has a link to see previous notifications" do
|
|
visit messages_proposal_dashboard_path(proposal)
|
|
|
|
expect(page).to have_link("See previous notifications", href: proposal_path(proposal,
|
|
anchor: "tab-notifications"))
|
|
end
|
|
|
|
scenario "Dashboard has a related content section" do
|
|
related_debate = create(:debate)
|
|
related_proposal = create(:proposal)
|
|
|
|
create(:related_content, parent_relationable: proposal,
|
|
child_relationable: related_debate, author: build(:user))
|
|
|
|
create(:related_content, parent_relationable: proposal,
|
|
child_relationable: related_proposal, author: build(:user))
|
|
|
|
within("#side_menu") do
|
|
click_link "Related content"
|
|
end
|
|
|
|
expect(page).to have_button("Add related content")
|
|
|
|
within(".dashboard-related-content") do
|
|
expect(page).to have_content("Related content (2)")
|
|
expect(page).to have_selector(".related-content-title", text: "Proposal")
|
|
expect(page).to have_link related_proposal.title
|
|
expect(page).to have_selector(".related-content-title", text: "Debate")
|
|
expect(page).to have_link related_debate.title
|
|
end
|
|
end
|
|
|
|
scenario "On recommended actions section display from the fourth proposed actions
|
|
when click see_proposed_actions_link", js: true do
|
|
create_list(:dashboard_action, 4, :proposed_action, :active)
|
|
action_5 = create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit recommended_actions_proposal_dashboard_path(proposal.to_param)
|
|
find(:css, "#see_proposed_actions_link_pending").click
|
|
|
|
expect(page).to have_content(action_5.title)
|
|
end
|
|
|
|
scenario "On recommended actions section display four proposed actions", js: true do
|
|
create_list(:dashboard_action, 4, :proposed_action, :active)
|
|
action_5 = create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit recommended_actions_proposal_dashboard_path(proposal.to_param)
|
|
|
|
expect(page).not_to have_content(action_5.title)
|
|
end
|
|
|
|
scenario "On recommended actions section display link for toggle when there are
|
|
more than four proposed actions", js: true do
|
|
create_list(:dashboard_action, 4, :proposed_action, :active)
|
|
create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit recommended_actions_proposal_dashboard_path(proposal.to_param)
|
|
|
|
expect(page).to have_content("Check out recommended actions")
|
|
end
|
|
|
|
scenario "On recommended actions section do not display link for toggle when
|
|
there are less than five proposed actions", js: true do
|
|
create_list(:dashboard_action, 4, :proposed_action, :active)
|
|
|
|
visit recommended_actions_proposal_dashboard_path(proposal.to_param)
|
|
|
|
expect(page).not_to have_link("Check out recommended actions")
|
|
end
|
|
|
|
scenario "On recommended actions section display proposed_action pending on his section" do
|
|
action = create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit recommended_actions_proposal_dashboard_path(proposal.to_param)
|
|
|
|
within "#proposed_actions_pending" do
|
|
expect(page).to have_content(action.title)
|
|
end
|
|
end
|
|
|
|
scenario "No recommended actions pending" do
|
|
visit recommended_actions_proposal_dashboard_path(proposal.to_param)
|
|
|
|
expect(page).to have_content("No recommended actions pending")
|
|
end
|
|
|
|
scenario "On recommended actions section display proposed_action done on his section" do
|
|
action = create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit recommended_actions_proposal_dashboard_path(proposal.to_param)
|
|
find(:css, "#dashboard_action_#{action.id}_execute").click
|
|
|
|
within "#proposed_actions_done" do
|
|
expect(page).to have_content(action.title)
|
|
end
|
|
end
|
|
|
|
scenario "No recommended actions pending or done" do
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
expect(page).not_to have_content("Recommended actions")
|
|
end
|
|
|
|
describe "detect_new_actions_after_last_login" do
|
|
|
|
before do
|
|
proposal.author.update(last_sign_in_at: Date.yesterday)
|
|
end
|
|
|
|
scenario "Display tag 'new' on resouce when it is new for author since last login" do
|
|
resource = create(:dashboard_action, :resource, :active, day_offset: 0,
|
|
published_proposal: false)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
within "#dashboard_action_#{resource.id}" do
|
|
expect(page).to have_content("New")
|
|
end
|
|
end
|
|
|
|
scenario "Not display tag 'new' on resouce when there is not new resources since last login" do
|
|
resource = create(:dashboard_action, :resource, :active, day_offset: 0,
|
|
published_proposal: false)
|
|
proposal.author.update(last_sign_in_at: Date.current)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
within "#dashboard_action_#{resource.id}" do
|
|
expect(page).not_to have_content("New")
|
|
end
|
|
end
|
|
|
|
scenario "Display tag 'new' on proposed_action when it is new for author since last login" do
|
|
proposed_action = create(:dashboard_action, :proposed_action, :active, day_offset: 0,
|
|
published_proposal: false)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
within "#dashboard_action_#{proposed_action.id}" do
|
|
expect(page).to have_content("New")
|
|
end
|
|
end
|
|
|
|
scenario "Not display tag 'new' on proposed_action when there is not new since last login" do
|
|
proposed_action = create(:dashboard_action, :proposed_action, :active, day_offset: 0,
|
|
published_proposal: false)
|
|
proposal.author.update(last_sign_in_at: Date.current)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
within "#dashboard_action_#{proposed_action.id}" do
|
|
expect(page).not_to have_content("New")
|
|
end
|
|
end
|
|
|
|
scenario "Display tag 'new' on sidebar menu when there is a new resouce since last login" do
|
|
create(:dashboard_action, :resource, :active, day_offset: 0, published_proposal: false)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
within "#side_menu" do
|
|
expect(page).to have_content("New")
|
|
end
|
|
end
|
|
|
|
scenario "Not display tag 'new' on sidebar when there is not a new resouce since last login" do
|
|
create(:dashboard_action, :resource, :active, day_offset: 0, published_proposal: false)
|
|
proposal.author.update(last_sign_in_at: Date.current)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
within "#side_menu" do
|
|
expect(page).not_to have_content("New")
|
|
end
|
|
end
|
|
|
|
end
|
|
end
|