We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
32 lines
1.1 KiB
Ruby
32 lines
1.1 KiB
Ruby
class RemoteTranslationsController < ApplicationController
|
|
skip_authorization_check
|
|
respond_to :html, :js
|
|
|
|
before_action :set_remote_translations, only: :create
|
|
|
|
def create
|
|
@remote_translations.each do |remote_translation|
|
|
RemoteTranslation.create!(remote_translation) unless translations_enqueued?(remote_translation)
|
|
end
|
|
redirect_to request.referer, notice: t("remote_translations.create.enqueue_remote_translation")
|
|
end
|
|
|
|
private
|
|
|
|
def remote_translations_params
|
|
params.permit(:remote_translations)
|
|
end
|
|
|
|
def set_remote_translations
|
|
remote_translations = remote_translations_params["remote_translations"]
|
|
decoded_remote_translations = ActiveSupport::JSON.decode(remote_translations)
|
|
@remote_translations = decoded_remote_translations.map do |remote_translation|
|
|
remote_translation.slice("remote_translatable_id", "remote_translatable_type", "locale")
|
|
end
|
|
end
|
|
|
|
def translations_enqueued?(remote_translation)
|
|
RemoteTranslation.remote_translation_enqueued?(remote_translation)
|
|
end
|
|
end
|