We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
23 lines
825 B
Ruby
23 lines
825 B
Ruby
module MailerHelper
|
|
def commentable_url(commentable)
|
|
return poll_url(commentable) if commentable.is_a?(Poll)
|
|
return debate_url(commentable) if commentable.is_a?(Debate)
|
|
return proposal_url(commentable) if commentable.is_a?(Proposal)
|
|
return community_topic_url(commentable.community_id, commentable) if commentable.is_a?(Topic)
|
|
return budget_investment_url(commentable.budget_id, commentable) if commentable.is_a?(Budget::Investment)
|
|
end
|
|
|
|
def valuation_comments_url(commentable)
|
|
admin_budget_budget_investment_url(commentable.budget, commentable, anchor: "comments")
|
|
end
|
|
|
|
def valuation_comments_link(commentable)
|
|
link_to(
|
|
commentable.title,
|
|
valuation_comments_url(@email.commentable),
|
|
target: :blank,
|
|
style: "color: #2895F1; text-decoration:none;"
|
|
)
|
|
end
|
|
end
|