We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
62 lines
3.0 KiB
Ruby
62 lines
3.0 KiB
Ruby
require "rails_helper"
|
|
|
|
describe RelatedContent do
|
|
let(:parent_relationable) { create([:proposal, :debate].sample) }
|
|
let(:child_relationable) { create([:proposal, :debate].sample) }
|
|
|
|
it "is valid" do
|
|
expect(build(:related_content)).to be_valid
|
|
end
|
|
|
|
it "allows relationables from various classes" do
|
|
expect(build(:related_content, parent_relationable: parent_relationable, child_relationable: child_relationable)).to be_valid
|
|
expect(build(:related_content, parent_relationable: parent_relationable, child_relationable: child_relationable)).to be_valid
|
|
expect(build(:related_content, parent_relationable: parent_relationable, child_relationable: child_relationable)).to be_valid
|
|
end
|
|
|
|
it "does not allow empty relationables" do
|
|
expect(build(:related_content, parent_relationable: nil)).not_to be_valid
|
|
expect(build(:related_content, child_relationable: nil)).not_to be_valid
|
|
end
|
|
|
|
it "does not allow repeated related contents" do
|
|
related_content = create(:related_content, parent_relationable: parent_relationable, child_relationable: child_relationable, author: build(:user))
|
|
new_related_content = build(:related_content, parent_relationable: related_content.parent_relationable, child_relationable: related_content.child_relationable)
|
|
expect(new_related_content).not_to be_valid
|
|
end
|
|
|
|
describe "create_opposite_related_content" do
|
|
let(:parent_relationable) { create(:proposal) }
|
|
let(:child_relationable) { create(:debate) }
|
|
let(:related_content) { build(:related_content, parent_relationable: parent_relationable, child_relationable: child_relationable, author: build(:user)) }
|
|
|
|
it "creates an opposite related_content" do
|
|
expect { related_content.save }.to change { RelatedContent.count }.by(2)
|
|
expect(related_content.opposite_related_content.child_relationable_id).to eq(parent_relationable.id)
|
|
expect(related_content.opposite_related_content.child_relationable_type).to eq(parent_relationable.class.name)
|
|
expect(related_content.opposite_related_content.parent_relationable_id).to eq(child_relationable.id)
|
|
expect(related_content.opposite_related_content.parent_relationable_type).to eq(child_relationable.class.name)
|
|
expect(related_content.opposite_related_content.opposite_related_content.id).to eq(related_content.id)
|
|
end
|
|
end
|
|
|
|
describe "#relationed_contents" do
|
|
before do
|
|
related_content = create(:related_content, parent_relationable: parent_relationable, child_relationable: create(:proposal), author: build(:user))
|
|
create(:related_content, parent_relationable: parent_relationable, child_relationable: child_relationable, author: build(:user))
|
|
|
|
2.times do
|
|
related_content.send("score_positive", build(:user))
|
|
end
|
|
|
|
6.times do
|
|
related_content.send("score_negative", build(:user))
|
|
end
|
|
end
|
|
|
|
it "returns not hidden by reports related contents" do
|
|
expect(parent_relationable.relationed_contents).to eq [child_relationable]
|
|
end
|
|
end
|
|
end
|