dca95d608f
We had a validation rule for milestones which made sure either the status or the description was present. However, since the description is now translatable, the validation error wasn't being displayed in the admin form. Moving the validation rule to the translation object fixes the problem. However, the translation object needs to check an attribute in the milestone object in order to know whether the description is required or not. This is tricky because by default it loads the milestone object from the database, meaning it doesn't work with new records and it ignores params sent by the browser. The solution is to manually assign the globalized model before validating the object. It's a hack, but apparently Rails doesn't provide a better way to handle this case [1]. [1] https://github.com/rails/rails/issues/32024
34 lines
1.0 KiB
Ruby
34 lines
1.0 KiB
Ruby
class Milestone < ActiveRecord::Base
|
|
include Imageable
|
|
include Documentable
|
|
documentable max_documents_allowed: 3,
|
|
max_file_size: 3.megabytes,
|
|
accepted_content_types: [ "application/pdf" ]
|
|
|
|
translates :title, :description, touch: true
|
|
include Globalizable
|
|
|
|
belongs_to :milestoneable, polymorphic: true
|
|
belongs_to :status
|
|
|
|
validates :milestoneable, presence: true
|
|
validates :publication_date, presence: true
|
|
|
|
before_validation :assign_milestone_to_translations
|
|
validates_translation :description, presence: true, unless: -> { status_id.present? }
|
|
|
|
scope :order_by_publication_date, -> { order(publication_date: :asc, created_at: :asc) }
|
|
scope :published, -> { where("publication_date <= ?", Date.current) }
|
|
scope :with_status, -> { where("status_id IS NOT NULL") }
|
|
|
|
def self.title_max_length
|
|
80
|
|
end
|
|
|
|
private
|
|
|
|
def assign_milestone_to_translations
|
|
translations.each { |translation| translation.globalized_model = self }
|
|
end
|
|
end
|