Files
nairobi/app/controllers/admin/newsletters_controller.rb
Javi Martín 11832cc07d Make it easier to customize allowed parameters
When customizing CONSUL, one of the most common actions is adding a new
field to a form.

This requires modifying the permitted/allowed parameters. However, in
most cases, the method returning these parameters returned an instance
of `ActionController::Parameters`, so adding more parameters to it
wasn't easy.

So customizing the code required copying the method returning those
parameters and adding the new ones. For example:

```
def something_params
  params.require(:something).permit(
    :one_consul_attribute,
    :another_consul_attribute,
    :my_custom_attribute
  )
end
```

This meant that, if the `something_params` method changed in CONSUL, the
customization of this method had to be updated as well.

So we're extracting the logic returning the parameters to a method which
returns an array. Now this code can be customized without copying the
original method:

```
alias_method :consul_allowed_params, :allowed_params

def allowed_params
  consul_allowed_params + [:my_custom_attribute]
end
```
2022-04-07 19:35:40 +02:00

70 lines
1.5 KiB
Ruby

class Admin::NewslettersController < Admin::BaseController
def index
@newsletters = Newsletter.all
end
def show
@newsletter = Newsletter.find(params[:id])
end
def new
@newsletter = Newsletter.new
end
def create
@newsletter = Newsletter.new(newsletter_params)
if @newsletter.save
notice = t("admin.newsletters.create_success")
redirect_to [:admin, @newsletter], notice: notice
else
render :new
end
end
def edit
@newsletter = Newsletter.find(params[:id])
end
def update
@newsletter = Newsletter.find(params[:id])
if @newsletter.update(newsletter_params)
redirect_to [:admin, @newsletter], notice: t("admin.newsletters.update_success")
else
render :edit
end
end
def destroy
@newsletter = Newsletter.find(params[:id])
@newsletter.destroy!
redirect_to admin_newsletters_path, notice: t("admin.newsletters.delete_success")
end
def deliver
@newsletter = Newsletter.find(params[:id])
if @newsletter.valid?
@newsletter.delay.deliver
@newsletter.update!(sent_at: Time.current)
flash[:notice] = t("admin.newsletters.send_success")
else
flash[:error] = t("admin.segment_recipient.invalid_recipients_segment")
end
redirect_to [:admin, @newsletter]
end
private
def newsletter_params
params.require(:newsletter).permit(allowed_params)
end
def allowed_params
[:subject, :segment_recipient, :from, :body]
end
end