efacd0def3
Why: * As seen on preproduction and production environments on Madrid's fork. Budget::Result#calculate_winners is very costly when done to all headings for a given budget (as requested on Admin::BudgetsController#calculate_winners) but its not when done individually for only a heading (as requested on Budget::Investment#recalculate_heading_winners) How: * Removing `handle_asynchronously :calculate_winners` from bellow Budget::Result#calculate_winners definition, to avoid making any call delayed. And explicitly calling `.delay` only when needed (on Admin::BudgetsController#calculate_winners)
54 lines
1.4 KiB
Ruby
54 lines
1.4 KiB
Ruby
class Admin::BudgetsController < Admin::BaseController
|
|
include FeatureFlags
|
|
feature_flag :budgets
|
|
|
|
has_filters %w{current finished}, only: :index
|
|
|
|
load_and_authorize_resource
|
|
|
|
def index
|
|
@budgets = Budget.send(@current_filter).order(created_at: :desc).page(params[:page])
|
|
end
|
|
|
|
def show
|
|
@budget = Budget.includes(groups: :headings).find(params[:id])
|
|
end
|
|
|
|
def new; end
|
|
|
|
def edit; end
|
|
|
|
def calculate_winners
|
|
return unless @budget.balloting_process?
|
|
@budget.headings.each { |heading| Budget::Result.new(@budget, heading).delay.calculate_winners }
|
|
redirect_to admin_budget_budget_investments_path(budget_id: @budget.id, filter: 'winners'),
|
|
notice: I18n.t("admin.budgets.winners.calculated")
|
|
end
|
|
|
|
def update
|
|
if @budget.update(budget_params)
|
|
redirect_to admin_budget_path(@budget), notice: t('admin.budgets.update.notice')
|
|
else
|
|
render :edit
|
|
end
|
|
end
|
|
|
|
def create
|
|
@budget = Budget.new(budget_params)
|
|
if @budget.save
|
|
redirect_to admin_budget_path(@budget), notice: t('admin.budgets.create.notice')
|
|
else
|
|
render :new
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def budget_params
|
|
descriptions = Budget::PHASES.map{|p| "description_#{p}"}.map(&:to_sym)
|
|
valid_attributes = [:name, :phase, :currency_symbol] + descriptions
|
|
params.require(:budget).permit(*valid_attributes)
|
|
end
|
|
|
|
end
|