e2d9d0f2b4
We had a trait called `:admin_request` for actions that are requests to
administrators, but the default factories were also requests to
administrators.
The tests checking that the "Request" button is not present, which
shouldn't pass with the wrong default factories, were passing by
coincidence. The issue was that we weren't checking whether that the
request had finished before checking that the "Request" button wasn't
present. That meant that we were checking that the "Request" button
wasn't there right at the moment we pressed the link, before the request
was finished.
So we're now checking that the request is finished before checking that
the button isn't there.
On the other hand, the tests checking for the "Request resource" link
being present were checking a behavior that's no longer there since
commit 9d85b3935, when we changed the conditions affecting that link.
562 lines
21 KiB
Ruby
562 lines
21 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Proposal's dashboard" do
|
|
let(:proposal) { create(:proposal, :draft) }
|
|
before { login_as(proposal.author) }
|
|
|
|
scenario "Navigation" do
|
|
visit proposal_dashboard_path(proposal)
|
|
|
|
expect(page).to have_link("Edit my proposal")
|
|
expect(page).to have_link("Edit proposal")
|
|
expect(page).to have_link("Withdraw proposal")
|
|
expect(page).to have_link("Publish proposal")
|
|
expect(page).to have_link("Polls")
|
|
expect(page).to have_link("E-mail")
|
|
expect(page).to have_link("Poster")
|
|
end
|
|
|
|
scenario "Publish link dissapears after proposal's publication" do
|
|
visit proposal_dashboard_path(proposal)
|
|
click_link "Publish proposal"
|
|
|
|
expect(page).not_to have_link("Publish proposal")
|
|
end
|
|
|
|
scenario "Dashboard progress shows current goal" do
|
|
goal = create(:dashboard_action, :resource, :active,
|
|
required_supports: proposal.votes_for.size + 1_000)
|
|
future_goal = create(:dashboard_action, :resource, :active,
|
|
required_supports: proposal.votes_for.size + 2_000)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
within "div#goals-section" do
|
|
expect(page).to have_content(goal.title)
|
|
expect(page).not_to have_content(future_goal.title)
|
|
|
|
click_button "Check out the complete course"
|
|
|
|
expect(page).to have_content(goal.title)
|
|
expect(page).to have_content(future_goal.title)
|
|
|
|
click_button "Hide course"
|
|
|
|
expect(page).to have_content(goal.title)
|
|
expect(page).not_to have_content(future_goal.title)
|
|
end
|
|
end
|
|
|
|
scenario "Dashboard progress show proposed actions" do
|
|
action = create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
expect(page).to have_content(action.title)
|
|
end
|
|
|
|
scenario "Dashboard progress show proposed actions truncated description" do
|
|
action = create(:dashboard_action, :proposed_action, :active, description: "One short action")
|
|
action_long = create(:dashboard_action, :proposed_action, :active,
|
|
description: "This is a really very long description for a proposed " \
|
|
"action on progress dashboard section, so this description " \
|
|
"should be appear truncated and shows the show description " \
|
|
"link to show the complete description to the users.")
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
expect(page).to have_content(action.description)
|
|
expect(page).to have_content("This is a really very long description for a proposed")
|
|
expect(page).to have_css "#truncated_description_dashboard_action_#{action_long.id}"
|
|
expect(page).to have_button("Show description")
|
|
end
|
|
|
|
scenario "Dashboard progress do not display from the fourth proposed actions" do
|
|
create_list(:dashboard_action, 4, :proposed_action, :active)
|
|
action_5 = create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
expect(page).not_to have_content(action_5.title)
|
|
end
|
|
|
|
scenario "Dashboard progress display link to new page for proposed actions when
|
|
there are more than four proposed actions" do
|
|
create_list(:dashboard_action, 4, :proposed_action, :active)
|
|
create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
expect(page).to have_link("Go to recommended actions")
|
|
end
|
|
|
|
scenario "Dashboard progress do not display link to new page for proposed actions
|
|
when there are less than five proposed actions" do
|
|
create_list(:dashboard_action, 4, :proposed_action, :active)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
expect(page).not_to have_link("Check out recommended actions")
|
|
end
|
|
|
|
scenario "Dashboard progress display proposed_action pending on his section" do
|
|
action = create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
within "#proposed_actions_pending" do
|
|
expect(page).to have_content(action.title)
|
|
end
|
|
end
|
|
|
|
scenario "Dashboard progress display proposed_action done on his section" do
|
|
action = create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
find(:css, "#dashboard_action_#{action.id}_execute").click
|
|
|
|
within "#proposed_actions_done" do
|
|
expect(page).to have_content(action.title)
|
|
end
|
|
end
|
|
|
|
scenario "Dashboard progress can execute proposed action" do
|
|
action = create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
expect(page).to have_content(action.title)
|
|
|
|
find(:css, "#dashboard_action_#{action.id}_execute").click
|
|
expect(page).not_to have_css "#dashboard_action_#{action.id}_execute"
|
|
end
|
|
|
|
scenario "Dashboard progress can unexecute proposed action" do
|
|
action = create(:dashboard_action, :proposed_action, :active)
|
|
create(:dashboard_executed_action, proposal: proposal, action: action)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
expect(page).to have_content(action.title)
|
|
|
|
find(:css, "#dashboard_action_#{action.id}_unexecute").click
|
|
expect(page).to have_css "#dashboard_action_#{action.id}_execute"
|
|
end
|
|
|
|
scenario "Dashboard progress dont show proposed actions with published_proposal: true" do
|
|
action = create(:dashboard_action, :proposed_action, :active, published_proposal: true)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
expect(page).not_to have_content(action.title)
|
|
end
|
|
|
|
scenario "Dashboard progress show available resources for proposal draft" do
|
|
available = create(:dashboard_action, :resource, :active)
|
|
|
|
requested = create(:dashboard_action, :resource, :admin_request, :active)
|
|
executed_action = create(:dashboard_executed_action, action: requested,
|
|
proposal: proposal,
|
|
executed_at: Time.current)
|
|
_task = create(:dashboard_administrator_task, :pending, source: executed_action)
|
|
|
|
solved = create(:dashboard_action, :resource, :admin_request, :active)
|
|
executed_solved_action = create(:dashboard_executed_action, action: solved,
|
|
proposal: proposal,
|
|
executed_at: Time.current)
|
|
_solved_task = create(:dashboard_administrator_task, :done, source: executed_solved_action)
|
|
|
|
unavailable = create(:dashboard_action, :resource, :active,
|
|
required_supports: proposal.votes_for.size + 1_000)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
within "div#available-resources-section" do
|
|
expect(page).to have_content("Polls")
|
|
expect(page).to have_content("E-mail")
|
|
expect(page).to have_content("Poster")
|
|
expect(page).to have_content(available.title)
|
|
expect(page).to have_content(unavailable.title)
|
|
expect(page).to have_content(requested.title)
|
|
expect(page).to have_content(solved.title)
|
|
|
|
within "div#dashboard_action_#{available.id}" do
|
|
expect(page).to have_link "See resource"
|
|
end
|
|
|
|
within "div#dashboard_action_#{requested.id}" do
|
|
expect(page).to have_content("Resource already requested")
|
|
end
|
|
|
|
within "div#dashboard_action_#{unavailable.id}" do
|
|
expect(page).to have_content("1.000 supports required")
|
|
end
|
|
|
|
within "div#dashboard_action_#{solved.id}" do
|
|
expect(page).to have_link("See resource")
|
|
end
|
|
end
|
|
end
|
|
|
|
scenario "Dashboard progress show available resources for published proposal" do
|
|
proposal.update!(published_at: Date.current)
|
|
available = create(:dashboard_action, :resource, :active)
|
|
|
|
requested = create(:dashboard_action, :resource, :admin_request, :active)
|
|
executed_action = create(:dashboard_executed_action, action: requested,
|
|
proposal: proposal,
|
|
executed_at: Time.current)
|
|
_task = create(:dashboard_administrator_task, :pending, source: executed_action)
|
|
|
|
solved = create(:dashboard_action, :resource, :admin_request, :active)
|
|
executed_solved_action = create(:dashboard_executed_action, action: solved,
|
|
proposal: proposal,
|
|
executed_at: Time.current)
|
|
_solved_task = create(:dashboard_administrator_task, :done, source: executed_solved_action)
|
|
|
|
unavailable = create(:dashboard_action, :resource, :active,
|
|
required_supports: proposal.votes_for.size + 1_000)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
within "div#available-resources-section" do
|
|
expect(page).to have_content("Polls")
|
|
expect(page).to have_content("E-mail")
|
|
expect(page).to have_content("Poster")
|
|
expect(page).to have_content(available.title)
|
|
expect(page).to have_content(unavailable.title)
|
|
expect(page).to have_content(requested.title)
|
|
expect(page).to have_content(solved.title)
|
|
|
|
within "div#dashboard_action_#{available.id}" do
|
|
expect(page).to have_link "See resource"
|
|
end
|
|
|
|
within "div#dashboard_action_#{requested.id}" do
|
|
expect(page).to have_content("Resource already requested")
|
|
end
|
|
|
|
within "div#dashboard_action_#{unavailable.id}" do
|
|
expect(page).to have_content("1.000 supports required")
|
|
end
|
|
|
|
within "div#dashboard_action_#{solved.id}" do
|
|
expect(page).to have_link("See resource")
|
|
end
|
|
end
|
|
end
|
|
|
|
scenario "Dashboard progress dont show resources with published_proposal: true" do
|
|
available = create(:dashboard_action, :resource, :active, published_proposal: true)
|
|
unavailable = create(:dashboard_action, :resource, :active,
|
|
required_supports: proposal.votes_for.size + 1_000,
|
|
published_proposal: true)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
within "div#available-resources-section" do
|
|
expect(page).to have_content("Polls")
|
|
expect(page).to have_content("E-mail")
|
|
expect(page).to have_content("Poster")
|
|
expect(page).not_to have_content(available.title)
|
|
expect(page).not_to have_content(unavailable.title)
|
|
end
|
|
end
|
|
|
|
scenario "Dashboard has a link to resources on main menu" do
|
|
feature = create(:dashboard_action, :resource, :active)
|
|
|
|
visit proposal_dashboard_path(proposal)
|
|
expect(page).to have_link(feature.title)
|
|
end
|
|
|
|
scenario "Request resource with admin request" do
|
|
feature = create(:dashboard_action, :resource, :active, :admin_request)
|
|
|
|
visit proposal_dashboard_path(proposal)
|
|
click_link(feature.title)
|
|
|
|
click_button "Request"
|
|
expect(page).to have_content("The request has been successfully sent. We will contact you " \
|
|
"as soon as possible to inform you about it.")
|
|
end
|
|
|
|
scenario "Request already requested resource with admin request" do
|
|
feature = create(:dashboard_action, :resource, :active, :admin_request)
|
|
|
|
visit proposal_dashboard_path(proposal)
|
|
click_link(feature.title)
|
|
|
|
create(:dashboard_executed_action, action: feature, proposal: proposal)
|
|
|
|
click_button "Request"
|
|
expect(page).to have_content("Proposal has already been taken")
|
|
end
|
|
|
|
scenario "Resource requested show message instead of button" do
|
|
feature = create(:dashboard_action, :resource, :active, :admin_request)
|
|
|
|
visit proposal_dashboard_path(proposal)
|
|
within("#side_menu") do
|
|
click_link(feature.title)
|
|
end
|
|
click_button "Request"
|
|
|
|
expect(page).to have_content("The request has been successfully sent. We will contact you " \
|
|
"as soon as possible to inform you about it.")
|
|
end
|
|
|
|
scenario "Resource without admin request do not have a request link" do
|
|
feature = create(:dashboard_action, :resource, :active)
|
|
|
|
visit proposal_dashboard_path(proposal)
|
|
click_link(feature.title)
|
|
|
|
expect(page).to have_content feature.description
|
|
expect(page).not_to have_button "Request"
|
|
end
|
|
|
|
scenario "Resource admin request button do not appear on archived proposals" do
|
|
feature = create(:dashboard_action, :resource, :active)
|
|
archived = Setting.archived_proposals_date_limit
|
|
archived_proposal = create(:proposal, created_at: archived)
|
|
|
|
login_as(archived_proposal.author)
|
|
visit proposal_dashboard_path(archived_proposal)
|
|
|
|
within("#side_menu") do
|
|
click_link(feature.title)
|
|
end
|
|
|
|
expect(page).to have_content "This proposal is archived and can not request resources."
|
|
expect(page).not_to have_button "Request"
|
|
end
|
|
|
|
scenario "Dashboard has a link to dashboard community" do
|
|
visit proposal_dashboard_path(proposal)
|
|
|
|
expect(page).to have_link("Community")
|
|
click_link "Community"
|
|
|
|
expect(page).to have_content("Participants")
|
|
expect(page).to have_content("Debates")
|
|
expect(page).to have_content("Comments")
|
|
expect(page).to have_link("Access the community")
|
|
end
|
|
|
|
scenario "Dashboard has a link to recommended_actions if there is any" do
|
|
expect(page).not_to have_link("Recommended actions")
|
|
|
|
create_list(:dashboard_action, 3, :proposed_action, :active)
|
|
visit recommended_actions_proposal_dashboard_path(proposal.to_param)
|
|
|
|
expect(page).to have_link("Recommended actions")
|
|
expect(page).to have_css "h2", text: "Recommended actions"
|
|
expect(page).to have_content("Pending")
|
|
expect(page).to have_content("Done")
|
|
end
|
|
|
|
scenario "Dashboard has a link to messages" do
|
|
visit proposal_dashboard_path(proposal)
|
|
|
|
expect(page).to have_link("Message to users")
|
|
|
|
within("#side_menu") do
|
|
click_link "Message to users"
|
|
end
|
|
|
|
expect(page).to have_link("Send notification to proposal followers")
|
|
expect(page).to have_link("See previous notifications")
|
|
end
|
|
|
|
scenario "Dashboard has a link to send notification to proposal supporters" do
|
|
visit messages_proposal_dashboard_path(proposal)
|
|
click_link("Send notification to proposal followers")
|
|
|
|
fill_in "Title", with: "Thank you for supporting my proposal"
|
|
fill_in "Message", with: "Please share it with others!"
|
|
click_button "Send notification"
|
|
|
|
expect(page).to have_content "Your message has been sent correctly."
|
|
expect(page).to have_content "Thank you for supporting my proposal"
|
|
expect(page).to have_content "Please share it with others!"
|
|
end
|
|
|
|
scenario "Dashboard has a link to see previous notifications" do
|
|
visit messages_proposal_dashboard_path(proposal)
|
|
|
|
expect(page).to have_link("See previous notifications", href: proposal_path(proposal,
|
|
anchor: "tab-notifications"))
|
|
end
|
|
|
|
scenario "Dashboard has a related content section" do
|
|
related_debate = create(:debate)
|
|
related_proposal = create(:proposal)
|
|
|
|
create(:related_content, parent_relationable: proposal,
|
|
child_relationable: related_debate, author: build(:user))
|
|
|
|
create(:related_content, parent_relationable: proposal,
|
|
child_relationable: related_proposal, author: build(:user))
|
|
|
|
visit proposal_dashboard_path(proposal)
|
|
|
|
within("#side_menu") do
|
|
click_link "Related content"
|
|
end
|
|
|
|
expect(page).to have_button("Add related content")
|
|
|
|
within(".dashboard-related-content") do
|
|
expect(page).to have_content("Related content (2)")
|
|
expect(page).to have_css ".related-content-title", text: "PROPOSAL"
|
|
expect(page).to have_link related_proposal.title
|
|
expect(page).to have_css ".related-content-title", text: "DEBATE"
|
|
expect(page).to have_link related_debate.title
|
|
end
|
|
end
|
|
|
|
scenario "On recommended actions section display from the fourth proposed actions
|
|
when click see_proposed_actions_link" do
|
|
create_list(:dashboard_action, 4, :proposed_action, :active)
|
|
action_5 = create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit recommended_actions_proposal_dashboard_path(proposal.to_param)
|
|
click_button "Check out recommended actions"
|
|
|
|
expect(page).to have_content(action_5.title)
|
|
|
|
click_button "Hide recommended actions"
|
|
|
|
expect(page).not_to have_content(action_5.title)
|
|
end
|
|
|
|
scenario "On recommended actions section display four proposed actions" do
|
|
create_list(:dashboard_action, 4, :proposed_action, :active)
|
|
action_5 = create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit recommended_actions_proposal_dashboard_path(proposal.to_param)
|
|
|
|
expect(page).not_to have_content(action_5.title)
|
|
end
|
|
|
|
scenario "On recommended actions section display link for toggle when there are
|
|
more than four proposed actions" do
|
|
create_list(:dashboard_action, 4, :proposed_action, :active)
|
|
create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit recommended_actions_proposal_dashboard_path(proposal.to_param)
|
|
|
|
expect(page).to have_content("Check out recommended actions")
|
|
end
|
|
|
|
scenario "On recommended actions section do not display link for toggle when
|
|
there are less than five proposed actions" do
|
|
create_list(:dashboard_action, 4, :proposed_action, :active)
|
|
|
|
visit recommended_actions_proposal_dashboard_path(proposal.to_param)
|
|
|
|
expect(page).not_to have_link("Check out recommended actions")
|
|
end
|
|
|
|
scenario "On recommended actions section display proposed_action pending on his section" do
|
|
action = create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit recommended_actions_proposal_dashboard_path(proposal.to_param)
|
|
|
|
within "#proposed_actions_pending" do
|
|
expect(page).to have_content(action.title)
|
|
end
|
|
end
|
|
|
|
scenario "No recommended actions pending" do
|
|
visit recommended_actions_proposal_dashboard_path(proposal.to_param)
|
|
|
|
expect(page).to have_content("No recommended actions pending")
|
|
end
|
|
|
|
scenario "On recommended actions section display proposed_action done on his section" do
|
|
action = create(:dashboard_action, :proposed_action, :active)
|
|
|
|
visit recommended_actions_proposal_dashboard_path(proposal.to_param)
|
|
find(:css, "#dashboard_action_#{action.id}_execute").click
|
|
|
|
within "#proposed_actions_done" do
|
|
expect(page).to have_content(action.title)
|
|
end
|
|
end
|
|
|
|
scenario "No recommended actions pending or done" do
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
expect(page).not_to have_content("Recommended actions")
|
|
end
|
|
|
|
describe "detect_new_actions_after_last_login" do
|
|
before { proposal.author.update!(current_sign_in_at: 1.day.ago) }
|
|
|
|
scenario "Display tag 'new' on resouce when it is new for author since last login" do
|
|
resource = create(:dashboard_action, :resource, :active, day_offset: 0,
|
|
published_proposal: false)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
within "#dashboard_action_#{resource.id}" do
|
|
expect(page).to have_content("New")
|
|
end
|
|
end
|
|
|
|
scenario "Not display tag 'new' on resouce when there is not new resources since last login" do
|
|
resource = create(:dashboard_action, :resource, :active, day_offset: 0,
|
|
published_proposal: false)
|
|
proposal.author.update!(current_sign_in_at: Date.current)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
within "#dashboard_action_#{resource.id}" do
|
|
expect(page).not_to have_content("New")
|
|
end
|
|
end
|
|
|
|
scenario "Display tag 'new' on proposed_action when it is new for author since last login" do
|
|
proposed_action = create(:dashboard_action, :proposed_action, :active, day_offset: 0,
|
|
published_proposal: false)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
within "#dashboard_action_#{proposed_action.id}" do
|
|
expect(page).to have_content("New")
|
|
end
|
|
end
|
|
|
|
scenario "Not display tag 'new' on proposed_action when there is not new since last login" do
|
|
proposed_action = create(:dashboard_action, :proposed_action, :active, day_offset: 0,
|
|
published_proposal: false)
|
|
proposal.author.update!(current_sign_in_at: Date.current)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
within "#dashboard_action_#{proposed_action.id}" do
|
|
expect(page).not_to have_content("New")
|
|
end
|
|
end
|
|
|
|
scenario "Display tag 'new' on sidebar menu when there is a new resouce since last login" do
|
|
create(:dashboard_action, :resource, :active, day_offset: 0, published_proposal: false)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
within "#side_menu" do
|
|
expect(page).to have_content("New")
|
|
end
|
|
end
|
|
|
|
scenario "Not display tag 'new' on sidebar when there is not a new resouce since last login" do
|
|
create(:dashboard_action, :resource, :active, day_offset: 0, published_proposal: false)
|
|
proposal.author.update!(current_sign_in_at: Date.current)
|
|
|
|
visit progress_proposal_dashboard_path(proposal)
|
|
|
|
within "#side_menu" do
|
|
expect(page).not_to have_content("New")
|
|
end
|
|
end
|
|
end
|
|
end
|