Files
nairobi/spec/controllers/graphql_controller_spec.rb
Julian Herrero 6e88031537 Fix several rubocop warnings
Metrics/LineLength: Line is too long.
RSpec/InstanceVariable: Use let instead of an instance variable.
Layout/TrailingBlankLines: Final newline missing.
Style/StringLiterals: Prefer double-quoted strings.
2019-04-17 17:40:56 +02:00

94 lines
3.1 KiB
Ruby

require "rails_helper"
# Useful resource: http://graphql.org/learn/serving-over-http/
def parser_error_raised?(response)
data_is_empty = response["data"].nil?
error_is_present = (JSON.parse(response.body)["errors"].first["message"] =~ /^Parse error on/)
data_is_empty && error_is_present
end
describe GraphqlController, type: :request do
let(:proposal) { create(:proposal) }
describe "handles GET request" do
specify "with query string inside query params" do
get "/graphql", params: { query: "{ proposal(id: #{proposal.id}) { title } }" }
expect(response).to have_http_status(:ok)
expect(JSON.parse(response.body)["data"]["proposal"]["title"]).to eq(proposal.title)
end
specify "with malformed query string" do
get "/graphql", params: { query: "Malformed query string" }
expect(response).to have_http_status(:ok)
expect(parser_error_raised?(response)).to be_truthy
end
specify "without query string" do
get "/graphql"
expect(response).to have_http_status(:bad_request)
expect(JSON.parse(response.body)["message"]).to eq("Query string not present")
end
end
describe "handles POST request" do
let(:json_headers) { { "CONTENT_TYPE" => "application/json" } }
specify "with json-encoded query string inside body" do
post "/graphql", params: { query: "{ proposal(id: #{proposal.id}) { title } }" }.to_json,
headers: json_headers
expect(response).to have_http_status(:ok)
expect(JSON.parse(response.body)["data"]["proposal"]["title"]).to eq(proposal.title)
end
specify "with raw query string inside body" do
graphql_headers = { "CONTENT_TYPE" => "application/graphql" }
post "/graphql", params: "{ proposal(id: #{proposal.id}) { title } }",
headers: graphql_headers
expect(response).to have_http_status(:ok)
expect(JSON.parse(response.body)["data"]["proposal"]["title"]).to eq(proposal.title)
end
specify "with malformed query string" do
post "/graphql", params: { query: "Malformed query string" }.to_json, headers: json_headers
expect(response).to have_http_status(:ok)
expect(parser_error_raised?(response)).to be_truthy
end
it "without query string" do
post "/graphql", headers: json_headers
expect(response).to have_http_status(:bad_request)
expect(JSON.parse(response.body)["message"]).to eq("Query string not present")
end
end
describe "correctly parses query variables" do
let(:query_string) { "{ proposal(id: #{proposal.id}) { title } }" }
specify "when absent" do
get "/graphql", params: { query: query_string }
expect(response).to have_http_status(:ok)
end
specify "when specified as the 'null' string" do
get "/graphql", params: { query: query_string, variables: "null" }
expect(response).to have_http_status(:ok)
end
specify "when specified as an empty string" do
get "/graphql", params: { query: query_string, variables: "" }
expect(response).to have_http_status(:ok)
end
end
end