Files
nairobi/spec/system/admin/stats_spec.rb
Javi Martín 6e5ef9795e Track ahoy visits on the server side
In commit 96ae69fe9, we stopped using cookies to track Ahoy visits and
started using a combination of the IP and the browser agent instead.

However, since we're still using the legacy logic from Ahoy 1.x to track
visits (which we had to add in commit b5220effd), this way of tracking
visits doesn't work and counts every page visited by a user as an
independent visit.

Maybe we could migrate existing data, which uses the `visitor_id` column
so it uses the new `visit_token` and `visitor_token` columns, but
there's no mention in the Ahoy documentation regarding how to do so.

While deciding what to do about this, we found something interesting.

For two years, we've been seeing random failures in the
`system/admin/tenants_spec.rb` tests, with messages like:

```
1) Tenants Create Tenant with subdomain
     Failure/Error:
       raise TenantNotFound, <<~EXCEPTION_MESSAGE
         Could not set search path to schemas, they may be invalid:
           "#{tenant}" #{full_search_path}.
         Original error: #{exception.class}: #{exception}
       EXCEPTION_MESSAGE

     Apartment::TenantNotFound:
       Could not set search path to schemas, they may be invalid:
         "earth" "public", "shared_extensions".
       Original error:
         ActiveRecord::StatementInvalid: Could not find schema earth
```

And we've found one of the causes: the AJAX requests done by Ahoy to
track visits. Sometimes a test that creates or updates a tenant finishes
but the Ahoy AJAX request to, say, `earth.lvh.me/ahoy/visits`, is
handled by the next test, when the `earth` schema no longer exists, thus
raising an `Apartment::TenantNotFound` exception.

So by disabling these AJAX requests and tracking the visits in the
server instead, we're killing two birds in one stone: we're fixing the
bug regarding the visits count and we're reducing the flakiness in our
test suite. It looks like we're also removing the "phantom ahoy cookie"
we were getting since the mentioned commit b5220effd: an ahoy cookie was
quickly set and unset in the browser.

Note that, even though we aren't migrating any data, we're still adding
the new fields, because some tests started to fail because, when
tracking visits in the server without cookies, Ahoy expects the Visit
model to have a `visit_token` field.
2024-11-07 12:04:46 +01:00

442 lines
12 KiB
Ruby

require "rails_helper"
describe "Stats", :admin do
context "Summary" do
scenario "General" do
create(:debate)
2.times { create(:proposal) }
3.times { create(:comment, commentable: Debate.first) }
4.times { create(:visit) }
visit admin_stats_path
expect(page).to have_content "DEBATES\n1"
expect(page).to have_content "PROPOSALS\n2"
expect(page).to have_content "COMMENTS\n3"
expect(page).to have_content "VISITS\n5"
end
scenario "Visits" do
visit admin_stats_path
refresh
expect(page).to have_content "VISITS\n1"
allow_any_instance_of(ActionDispatch::Request).to receive(:user_agent).and_return("Different")
in_browser(:different) do
visit root_path
click_link "Debates"
expect(page).to have_link "Start a debate"
click_link "Proposals"
expect(page).to have_link "Create a proposal"
end
allow_any_instance_of(ActionDispatch::Request).to receive(:user_agent).and_call_original
refresh
expect(page).to have_content "VISITS\n2"
end
scenario "Votes" do
create(:debate, voters: Array.new(1) { create(:user) })
create(:proposal, voters: Array.new(2) { create(:user) })
create(:comment, voters: Array.new(3) { create(:user) })
visit admin_stats_path
expect(page).to have_content "DEBATE VOTES\n1"
expect(page).to have_content "PROPOSAL VOTES\n2"
expect(page).to have_content "COMMENT VOTES\n3"
expect(page).to have_content "TOTAL VOTES\n6"
end
end
context "Users" do
scenario "Summary" do
1.times { create(:user, :level_three) }
2.times { create(:user, :level_two) }
3.times { create(:user) }
visit admin_stats_path
expect(page).to have_content "LEVEL THREE USERS\n1"
expect(page).to have_content "LEVEL TWO USERS\n2"
expect(page).to have_content "VERIFIED USERS\n3"
expect(page).to have_content "UNVERIFIED USERS\n4"
expect(page).to have_content "TOTAL USERS\n7"
end
scenario "Do not count erased users" do
1.times { create(:user, :level_three, erased_at: Time.current) }
2.times { create(:user, :level_two, erased_at: Time.current) }
3.times { create(:user, erased_at: Time.current) }
visit admin_stats_path
expect(page).to have_content "LEVEL THREE USERS\n0"
expect(page).to have_content "LEVEL TWO USERS\n0"
expect(page).to have_content "VERIFIED USERS\n0"
expect(page).to have_content "UNVERIFIED USERS\n1"
expect(page).to have_content "TOTAL USERS\n1"
end
scenario "Do not count hidden users" do
1.times { create(:user, :hidden, :level_three) }
2.times { create(:user, :hidden, :level_two) }
3.times { create(:user, :hidden) }
visit admin_stats_path
expect(page).to have_content "LEVEL THREE USERS\n0"
expect(page).to have_content "LEVEL TWO USERS\n0"
expect(page).to have_content "VERIFIED USERS\n0"
expect(page).to have_content "UNVERIFIED USERS\n1"
expect(page).to have_content "TOTAL USERS\n1"
end
end
describe "Budget investments" do
context "Supporting phase" do
let!(:budget) { create(:budget) }
let(:heading_all_city) { create(:budget_heading, budget: budget) }
scenario "Number of users and supports in investment projects" do
group_2 = create(:budget_group, budget: budget)
investment1 = create(:budget_investment, heading: create(:budget_heading, group: group_2))
investment2 = create(:budget_investment, heading: heading_all_city)
create(:user, :level_two, votables: [investment1, investment2])
create(:user, :level_two, votables: [investment1])
create(:user, :level_two)
visit admin_stats_path
click_link "Participatory Budgets"
within("#budget_#{budget.id}") do
click_link "Supporting phase"
end
expect(page).to have_content "VOTES\n3"
expect(page).to have_content "PARTICIPANTS\n2"
expect(page).to have_link "Go back", count: 1
end
scenario "Don't use the cache for supports", :with_cache do
budget.update!(phase: :selecting)
investment = create(:budget_investment, heading: heading_all_city)
create(:user, :level_two, votables: [investment])
supporter = create(:user, :level_two)
visit budget_supporting_admin_stats_path(budget_id: budget)
expect(page).to have_content "VOTES\n1"
expect(page).to have_content "PARTICIPANTS\n1"
in_browser(:supporter) do
login_as(supporter)
visit budget_investment_path(budget, investment)
click_button "Support"
expect(page).to have_button "Remove your support"
end
refresh
expect(page).to have_content "VOTES\n2"
expect(page).to have_content "PARTICIPANTS\n2"
end
scenario "hide final voting link" do
visit admin_stats_path
click_link "Participatory Budgets"
within("#budget_#{budget.id}") do
expect(page).not_to have_link "Final voting"
end
end
scenario "show message when accessing final voting stats" do
visit budget_balloting_admin_stats_path(budget_id: budget.id)
expect(page).to have_content "There isn't any data to show before the balloting phase."
end
end
context "Balloting phase" do
let(:budget) { create(:budget, :balloting) }
let(:heading) { create(:budget_heading, budget: budget) }
let(:investment) { create(:budget_investment, :feasible, :selected, heading: heading) }
scenario "Number of votes in investment projects" do
investment_2 = create(:budget_investment, :feasible, :selected, budget: budget)
create(:user, ballot_lines: [investment, investment_2])
create(:user, ballot_lines: [investment_2])
visit admin_stats_path
click_link "Participatory Budgets"
within("#budget_#{budget.id}") do
click_link "Final voting"
end
expect(page).to have_content "VOTES\n3"
expect(page).to have_content "PARTICIPANTS\n2"
end
scenario "Don't use the cache for votes", :with_cache do
budget.update!(phase: :balloting)
create(:user, ballot_lines: [investment])
balloter = create(:user, :level_two)
visit budget_balloting_admin_stats_path(budget_id: budget.id)
expect(page).to have_content "VOTES\n1"
expect(page).to have_content "PARTICIPANTS\n1"
in_browser(:balloter) do
login_as(balloter)
visit budget_investment_path(budget, investment)
click_button "Vote"
expect(page).to have_button "Remove vote"
end
refresh
expect(page).to have_content "VOTES\n2"
expect(page).to have_content "PARTICIPANTS\n2"
end
end
end
describe "graphs", :with_frozen_time do
scenario "event graphs" do
create(:debate)
visit admin_stats_path
within("#stats") do
click_link "Debates created"
end
expect(page).to have_content "Debates created (1)"
within("#graph") do
expect(page).to have_content Date.current.strftime("%Y-%m-%d")
end
end
scenario "Level 3 user Graph" do
create(:user, :level_three)
visit admin_stats_path
click_link "Level 3 users verified"
expect(page).to have_content "Level 3 users verified (1)"
within("#graph") do
expect(page).to have_content Date.current.strftime("%Y-%m-%d")
end
end
end
context "Proposal notifications" do
scenario "Summary stats" do
proposal = create(:proposal)
create(:proposal_notification, proposal: proposal)
create(:proposal_notification, proposal: proposal)
create(:proposal_notification)
visit admin_stats_path
click_link "Proposal notifications"
expect(page).to have_link "Go back", href: admin_stats_path
within("#proposal_notifications_count") do
expect(page).to have_content "3"
end
within("#proposals_with_notifications_count") do
expect(page).to have_content "2"
end
end
scenario "Index" do
proposal_notifications = 3.times.map { create(:proposal_notification) }
visit admin_stats_path
click_link "Proposal notifications"
expect(page).to have_css(".proposal_notification", count: 3)
proposal_notifications.each do |proposal_notification|
expect(page).to have_content proposal_notification.title
expect(page).to have_content proposal_notification.body
end
end
scenario "Deleted proposals" do
proposal_notification = create(:proposal_notification)
proposal_notification.proposal.destroy!
visit admin_stats_path
click_link "Proposal notifications"
expect(page).to have_css(".proposal_notification", count: 1)
expect(page).to have_content proposal_notification.title
expect(page).to have_content proposal_notification.body
expect(page).to have_content "Proposal not available"
end
end
context "Direct messages" do
scenario "Summary stats" do
sender = create(:user, :level_two)
create(:direct_message, sender: sender)
create(:direct_message, sender: sender)
create(:direct_message)
visit admin_stats_path
click_link "Direct messages"
expect(page).to have_link "Go back", href: admin_stats_path
within("#direct_messages_count") do
expect(page).to have_content "3"
end
within("#users_who_have_sent_message_count") do
expect(page).to have_content "2"
end
end
end
context "Polls" do
scenario "Total participants by origin" do
create(:poll_officer_assignment)
3.times { create(:poll_voter, origin: "web") }
visit admin_stats_path
within(".stats") do
click_link "Polls"
end
expect(page).to have_link "Go back", href: admin_stats_path
within("#web_participants") do
expect(page).to have_content "3"
end
end
scenario "Total participants" do
user = create(:user, :level_two)
3.times { create(:poll_voter, user: user) }
create(:poll_voter)
visit admin_stats_path
within(".stats") do
click_link "Polls"
end
within("#participants") do
expect(page).to have_content "2"
end
end
scenario "Participants by poll" do
poll1 = create(:poll)
poll2 = create(:poll)
1.times { create(:poll_voter, poll: poll1, origin: "web") }
2.times { create(:poll_voter, poll: poll2, origin: "web") }
visit admin_stats_path
within(".stats") do
click_link "Polls"
end
within("#polls") do
within("#poll_#{poll1.id}") do
expect(page).to have_content "1"
end
within("#poll_#{poll2.id}") do
expect(page).to have_content "2"
end
end
end
scenario "Participants by poll question" do
user1 = create(:user, :level_two)
user2 = create(:user, :level_two)
poll = create(:poll)
question1 = create(:poll_question, :yes_no, poll: poll)
question2 = create(:poll_question, :yes_no, poll: poll)
create(:poll_answer, question: question1, author: user1)
create(:poll_answer, question: question2, author: user1)
create(:poll_answer, question: question2, author: user2)
visit admin_stats_path
within(".stats") do
click_link "Polls"
end
within("#poll_question_#{question1.id}") do
expect(page).to have_content "1"
end
within("#poll_question_#{question2.id}") do
expect(page).to have_content "2"
end
within("#poll_#{poll.id}_questions_total") do
expect(page).to have_content "2"
end
end
end
context "SDG" do
scenario "Shows SDG stats link when SDG feature is enabled" do
Setting["feature.sdg"] = true
visit admin_stats_path
expect(page).to have_link "SDG", href: sdg_admin_stats_path
end
scenario "Does not show SDG stats link when SDG feature is disbled" do
Setting["feature.sdg"] = false
visit admin_stats_path
expect(page).not_to have_link "SDG"
end
scenario "Renders all goals stats" do
goals_count = SDG::Goal.count
visit sdg_admin_stats_path
expect(page).to have_css "h3", count: goals_count
expect(page).to have_css ".sdg-goal-stats", count: goals_count
end
end
end