View questions now is View results and redirects to results in public view. Fixed flaky spec that was making the tests fail. Added missing specs for polls feature as well as poll model.
253 lines
8.4 KiB
Ruby
253 lines
8.4 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe Poll do
|
|
|
|
let(:poll) { build(:poll) }
|
|
|
|
describe "Concerns" do
|
|
it_behaves_like "notifiable"
|
|
end
|
|
|
|
describe "validations" do
|
|
it "is valid" do
|
|
expect(poll).to be_valid
|
|
end
|
|
|
|
it "is not valid without a name" do
|
|
poll.name = nil
|
|
expect(poll).not_to be_valid
|
|
end
|
|
|
|
it "is not valid without a start date" do
|
|
poll.starts_at = nil
|
|
expect(poll).not_to be_valid
|
|
end
|
|
|
|
it "is not valid without an end date" do
|
|
poll.ends_at = nil
|
|
expect(poll).not_to be_valid
|
|
end
|
|
|
|
it "is not valid without a proper start/end date range" do
|
|
poll.starts_at = 1.week.ago
|
|
poll.ends_at = 2.months.ago
|
|
expect(poll).not_to be_valid
|
|
end
|
|
|
|
it 'no overlapping polls for proposal polls are allowed' do
|
|
end
|
|
end
|
|
|
|
describe 'proposal polls specific validations' do
|
|
let(:proposal) { create(:proposal) }
|
|
let(:poll) { build(:poll, related: proposal) }
|
|
|
|
it 'is valid when overlapping but different proposals' do
|
|
other_proposal = create(:proposal)
|
|
_other_poll = create(:poll, related: other_proposal, starts_at: poll.starts_at, ends_at: poll.ends_at)
|
|
|
|
expect(poll).to be_valid
|
|
end
|
|
|
|
it 'is valid when same proposal but not overlapping' do
|
|
_other_poll = create(:poll, related: proposal, starts_at: poll.ends_at + 1.day, ends_at: poll.ends_at + 8.days)
|
|
expect(poll).to be_valid
|
|
end
|
|
|
|
it 'is not valid when overlaps from the beginning' do
|
|
_other_poll = create(:poll, related: proposal, starts_at: poll.starts_at - 8.days, ends_at: poll.starts_at)
|
|
expect(poll).not_to be_valid
|
|
end
|
|
|
|
it 'is not valid when overlaps from the end' do
|
|
_other_poll = create(:poll, related: proposal, starts_at: poll.ends_at, ends_at: poll.ends_at + 8.days)
|
|
expect(poll).not_to be_valid
|
|
end
|
|
|
|
it 'is not valid when overlaps with same interval' do
|
|
_other_poll = create(:poll, related: proposal, starts_at: poll.starts_at, ends_at: poll.ends_at)
|
|
expect(poll).not_to be_valid
|
|
end
|
|
|
|
it 'is not valid when overlaps with interval contained' do
|
|
_other_poll = create(:poll, related: proposal, starts_at: poll.starts_at + 1.day, ends_at: poll.ends_at - 1.day)
|
|
expect(poll).not_to be_valid
|
|
end
|
|
|
|
it 'is not valid when overlaps with interval containing' do
|
|
_other_poll = create(:poll, related: proposal, starts_at: poll.starts_at - 8.days, ends_at: poll.ends_at + 8.days)
|
|
expect(poll).not_to be_valid
|
|
end
|
|
end
|
|
|
|
describe "#opened?" do
|
|
it "returns true only when it isn't too early or too late" do
|
|
expect(create(:poll, :incoming)).not_to be_current
|
|
expect(create(:poll, :expired)).not_to be_current
|
|
expect(create(:poll)).to be_current
|
|
end
|
|
end
|
|
|
|
describe "#incoming?" do
|
|
it "returns true only when it is too early" do
|
|
expect(create(:poll, :incoming)).to be_incoming
|
|
expect(create(:poll, :expired)).not_to be_incoming
|
|
expect(create(:poll)).not_to be_incoming
|
|
end
|
|
end
|
|
|
|
describe "#expired?" do
|
|
it "returns true only when it is too late" do
|
|
expect(create(:poll, :incoming)).not_to be_expired
|
|
expect(create(:poll, :expired)).to be_expired
|
|
expect(create(:poll)).not_to be_expired
|
|
end
|
|
end
|
|
|
|
describe "#published?" do
|
|
it "returns true only when published is true" do
|
|
expect(create(:poll)).not_to be_published
|
|
expect(create(:poll, :published)).to be_published
|
|
end
|
|
end
|
|
|
|
describe "#current_or_incoming" do
|
|
it "returns current or incoming polls" do
|
|
current = create(:poll, :current)
|
|
incoming = create(:poll, :incoming)
|
|
expired = create(:poll, :expired)
|
|
|
|
current_or_incoming = described_class.current_or_incoming
|
|
|
|
expect(current_or_incoming).to include(current)
|
|
expect(current_or_incoming).to include(incoming)
|
|
expect(current_or_incoming).not_to include(expired)
|
|
end
|
|
end
|
|
|
|
describe "#recounting" do
|
|
it "returns polls in recount & scrutiny phase" do
|
|
current = create(:poll, :current)
|
|
incoming = create(:poll, :incoming)
|
|
expired = create(:poll, :expired)
|
|
recounting = create(:poll, :recounting)
|
|
|
|
recounting_polls = described_class.recounting
|
|
|
|
expect(recounting_polls).not_to include(current)
|
|
expect(recounting_polls).not_to include(incoming)
|
|
expect(recounting_polls).not_to include(expired)
|
|
expect(recounting_polls).to include(recounting)
|
|
end
|
|
end
|
|
|
|
describe "#current_or_recounting_or_incoming" do
|
|
it "returns current or recounting or incoming polls" do
|
|
current = create(:poll, :current)
|
|
incoming = create(:poll, :incoming)
|
|
expired = create(:poll, :expired)
|
|
recounting = create(:poll, :recounting)
|
|
|
|
current_or_recounting_or_incoming = described_class.current_or_recounting_or_incoming
|
|
|
|
expect(current_or_recounting_or_incoming).to include(current)
|
|
expect(current_or_recounting_or_incoming).to include(recounting)
|
|
expect(current_or_recounting_or_incoming).to include(incoming)
|
|
expect(current_or_recounting_or_incoming).not_to include(expired)
|
|
end
|
|
end
|
|
|
|
describe "answerable_by" do
|
|
let(:geozone) {create(:geozone) }
|
|
|
|
let!(:current_poll) { create(:poll) }
|
|
let!(:expired_poll) { create(:poll, :expired) }
|
|
let!(:incoming_poll) { create(:poll, :incoming) }
|
|
let!(:current_restricted_poll) { create(:poll, geozone_restricted: true, geozones: [geozone]) }
|
|
let!(:expired_restricted_poll) { create(:poll, :expired, geozone_restricted: true, geozones: [geozone]) }
|
|
let!(:incoming_restricted_poll) { create(:poll, :incoming, geozone_restricted: true, geozones: [geozone]) }
|
|
let!(:all_polls) { [current_poll, expired_poll, incoming_poll, current_poll, expired_restricted_poll, incoming_restricted_poll] }
|
|
let(:non_current_polls) { [expired_poll, incoming_poll, expired_restricted_poll, incoming_restricted_poll] }
|
|
|
|
let(:non_user) { nil }
|
|
let(:level1) { create(:user) }
|
|
let(:level2) { create(:user, :level_two) }
|
|
let(:level2_from_geozone) { create(:user, :level_two, geozone: geozone) }
|
|
let(:all_users) { [non_user, level1, level2, level2_from_geozone] }
|
|
|
|
describe 'instance method' do
|
|
it "rejects non-users and level 1 users" do
|
|
all_polls.each do |poll|
|
|
expect(poll).not_to be_answerable_by(non_user)
|
|
expect(poll).not_to be_answerable_by(level1)
|
|
end
|
|
end
|
|
|
|
it "rejects everyone when not current" do
|
|
non_current_polls.each do |poll|
|
|
all_users.each do |user|
|
|
expect(poll).not_to be_answerable_by(user)
|
|
end
|
|
end
|
|
end
|
|
|
|
it "accepts level 2 users when unrestricted and current" do
|
|
expect(current_poll).to be_answerable_by(level2)
|
|
expect(current_poll).to be_answerable_by(level2_from_geozone)
|
|
end
|
|
|
|
it "accepts level 2 users only from the same geozone when restricted by geozone" do
|
|
expect(current_restricted_poll).not_to be_answerable_by(level2)
|
|
expect(current_restricted_poll).to be_answerable_by(level2_from_geozone)
|
|
end
|
|
end
|
|
|
|
describe 'class method' do
|
|
it "returns no polls for non-users and level 1 users" do
|
|
expect(described_class.answerable_by(nil)).to be_empty
|
|
expect(described_class.answerable_by(level1)).to be_empty
|
|
end
|
|
|
|
it "returns unrestricted polls for level 2 users" do
|
|
expect(described_class.answerable_by(level2).to_a).to eq([current_poll])
|
|
end
|
|
|
|
it "returns restricted & unrestricted polls for level 2 users of the correct geozone" do
|
|
list = described_class.answerable_by(level2_from_geozone)
|
|
.order(:geozone_restricted)
|
|
expect(list.to_a).to eq([current_poll, current_restricted_poll])
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#voted_in_booth?" do
|
|
|
|
it "returns true if the user has already voted in booth" do
|
|
user = create(:user, :level_two)
|
|
poll = create(:poll)
|
|
|
|
create(:poll_voter, poll: poll, user: user, origin: "booth")
|
|
|
|
expect(poll.voted_in_booth?(user)).to be
|
|
end
|
|
|
|
it "returns false if the user has not already voted in a booth" do
|
|
user = create(:user, :level_two)
|
|
poll = create(:poll)
|
|
|
|
expect(poll.voted_in_booth?(user)).not_to be
|
|
end
|
|
|
|
it "returns false if the user has voted in web" do
|
|
user = create(:user, :level_two)
|
|
poll = create(:poll)
|
|
|
|
create(:poll_voter, poll: poll, user: user, origin: "web")
|
|
|
|
expect(poll.voted_in_booth?(user)).not_to be
|
|
end
|
|
|
|
end
|
|
|
|
end
|