consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
a0942f66bfdd8f46646ab06c7b03bab76dad9c60
nairobi/app/models
History
Javi Martín a0942f66bf Fix crash destroying budgets with admins/valuators 
We don't allow deleting a budget with associated investments. However,
we allow deleting a budget with associated administrators and valuators.
This results in a foreign key violation error:

PG::ForeignKeyViolation: ERROR:  update or delete on table "budgets"
violates foreign key constraint "fk_rails_c847a52b1d" on table
"budget_administrators"

Using the `dependent: :destroy` option when defining the relationship,
we remove the association records when removing the budget.

As a bonus, we reduce the number of Rubocop offenses regarding the
`Rails/HasManyOrHasOneDependent` rule. Only 72 to go! :)
2021-06-02 17:07:04 +02:00
..
abilities
Allow users to delete their own comments
2021-04-13 20:04:04 +02:00
ahoy
Add and apply Layout/ExtraSpacing rubocop rule
2019-10-24 18:11:58 +02:00
banner
Replace occurrences of ActiveRecord::Base on new models
2019-04-17 17:40:56 +02:00
budget
Improve styles for budgets voting phase
2021-03-24 15:50:25 +01:00
ckeditor
Replace occurrences of ActiveRecord::Base on new models
2019-04-17 17:40:56 +02:00
concerns
Add SDG goals/targets to legislation proposals
2021-02-24 20:42:53 +01:00
custom
Rename method and placeholder
2021-03-02 13:15:15 +01:00
dashboard
Apply Rails/InverseOf rubocop rule
2019-10-25 19:29:12 +02:00
legislation
Validate process dates depending on enabled phases
2021-05-29 14:13:48 +02:00
local_census_records
Apply Rails/SaveBang rubocop rule
2019-10-23 14:39:31 +02:00
milestone
Replace occurrences of ActiveRecord::Base on new models
2019-04-17 17:40:56 +02:00
officing
Rename method and placeholder
2021-03-02 13:15:15 +01:00
poll
Mark safe SQL with Arel.sql
2020-10-15 14:57:42 +02:00
sdg
Fix legislation proposal crash with SDG enabled
2021-01-31 14:44:53 +01:00
site_customization
Make widget cards polymorphic
2021-01-14 17:37:58 +01:00
verification
Add and apply Style/AccessorGrouping rubocop rule
2020-10-23 12:01:39 +02:00
widget
Make widget cards polymorphic
2021-01-14 17:37:58 +01:00
.keep
…
ability.rb
Add cancancan to SDG content
2020-12-16 11:43:17 +01:00
active_poll.rb
Replace occurrences of ActiveRecord::Base on new models
2019-04-17 17:40:56 +02:00
activity.rb
Apply rubocop rules to freeze constants
2019-10-26 13:21:36 +02:00
admin_notification.rb
Fix admin notification with relative URLs
2021-03-31 14:03:26 +02:00
administrator.rb
Add description field to administrator users like evaluators description
2019-06-05 16:18:12 +02:00
application_record.rb
Mark safe SQL with Arel.sql
2020-10-15 14:57:42 +02:00
audit.rb
Use a different controller for investment audits
2019-11-05 13:03:45 +01:00
banner.rb
Adding consistency in banner scopes
2021-04-08 17:23:30 +02:00
budget_administrator.rb
Apply Layout/LeadingBlankLines rubocop rule
2019-10-26 13:03:48 +02:00
budget_valuator.rb
Add historic fields to participatory budget
2019-06-12 18:03:53 +02:00
budget.rb
Fix crash destroying budgets with admins/valuators
2021-06-02 17:07:04 +02:00
campaign.rb
models inherits from ApplicationRecord
2019-04-17 17:40:56 +02:00
comment_notifier.rb
Add and apply EmptyLineAfterGuardClause rule
2019-10-24 17:56:03 +02:00
comment.rb
Mark safe SQL with Arel.sql
2020-10-15 14:57:42 +02:00
community.rb
Use hash conditions instead of SQL's IN
2020-07-08 18:34:58 +02:00
dashboard.rb
Fix more hound warnings
2019-03-27 15:22:14 +01:00
debate.rb
Add relations between relatable models and SDGs
2020-12-04 18:27:49 +01:00
direct_message.rb
Use Date#all_day in DirectMessage.today
2020-04-27 19:26:37 +02:00
direct_upload.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
document.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
evaluation_comment_notifier.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
failed_census_call.rb
models inherits from ApplicationRecord
2019-04-17 17:40:56 +02:00
flag.rb
Add and apply EmptyLineAfterGuardClause rule
2019-10-24 17:56:03 +02:00
follow.rb
Avoid a brakeman security warning
2021-04-13 13:52:18 +02:00
geozone.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
geozones_poll.rb
Apply Rails/HasAndBelongsToMany rubocop rule
2019-10-25 19:29:12 +02:00
i18n_content_translation.rb
Replace occurrences of ActiveRecord::Base on new models
2019-04-17 17:40:56 +02:00
i18n_content.rb
Cache I18nContent translations
2020-12-15 11:57:09 +01:00
identity.rb
Apply Rails/SaveBang rubocop rule
2019-10-23 14:39:31 +02:00
image.rb
Remove empty lines around if and when body
2019-10-24 17:56:03 +02:00
legislation.rb
Use double quotes in models
2019-03-14 17:25:43 +01:00
link.rb
Use Rails 5 conventions in Dashboard
2019-04-29 13:08:43 -05:00
local_census_record.rb
Validate inclusion of document type in allowed document types
2019-11-07 16:26:19 +01:00
lock.rb
Add and apply EmptyLineAfterGuardClause rule
2019-10-24 17:56:03 +02:00
manager.rb
models inherits from ApplicationRecord
2019-04-17 17:40:56 +02:00
map_location.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
milestone.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
moderator.rb
models inherits from ApplicationRecord
2019-04-17 17:40:56 +02:00
newsletter.rb
Avoid a format validation security warning
2019-11-13 01:50:08 +01:00
notification.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
organization.rb
Apply Style/ClassVars rubocop rule
2019-10-26 13:03:49 +02:00
poll.rb
Add search method to polls
2020-12-21 18:04:48 +01:00
progress_bar.rb
Apply rubocop rules to freeze constants
2019-10-26 13:21:36 +02:00
proposal_notification.rb
Remove unnecessary foreign_key options
2019-10-25 19:03:10 +02:00
proposal.rb
Add relations between relatable models and SDGs
2020-12-04 18:27:49 +01:00
related_content_score.rb
Replace all occurrences of ActiveRecord::Base with ApplicationRecord
2019-04-17 17:40:56 +02:00
related_content.rb
Use self.name for same-table relations
2019-10-25 19:03:14 +02:00
remote_translation.rb
Check remote translations locales at runtime
2020-04-28 15:45:32 +02:00
report.rb
Apply rubocop rules to freeze constants
2019-10-26 13:21:36 +02:00
sdg.rb
Add SDG goal model
2020-12-02 12:13:02 +01:00
setting.rb
Make it easier for admins to enable SDG processes
2021-04-21 18:37:54 +02:00
signature_sheet.rb
Changes following PR review
2020-04-09 07:11:53 +10:00
signature.rb
Apply Style/CollectionMethods rubocop rule
2019-10-26 13:03:49 +02:00
site_customization.rb
Use double quotes in models
2019-03-14 17:25:43 +01:00
stats_version.rb
Add table to store stats versions
2019-05-21 13:50:19 +02:00
tag_cloud.rb
Rename columns with a slash in their names
2020-07-08 18:34:58 +02:00
tag.rb
Add models tag spec with 160 chars
2019-02-05 17:41:00 +01:00
tagging.rb
Use acts_as_taggable for investment valuation tags
2019-11-01 17:12:31 +01:00
topic.rb
Apply Rails/InverseOf rubocop rule
2019-10-25 19:29:12 +02:00
user.rb
Merge pull request #4442 from consul/user_search
2021-04-13 18:31:34 +02:00
valuator_group.rb
Replace all occurrences of ActiveRecord::Base with ApplicationRecord
2019-04-17 17:40:56 +02:00
valuator.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
verified_user.rb
models inherits from ApplicationRecord
2019-04-17 17:40:56 +02:00
visit.rb
models inherits from ApplicationRecord
2019-04-17 17:40:56 +02:00
vote.rb
…
web_section.rb
Add sdg management header controller
2021-02-26 16:16:51 +01:00
widget.rb
Simplify widget table prefix
2021-01-12 14:50:37 +01:00