1290e2ecd3
In order to migrate existing files from Paperclip to ActiveStorage, we need Paperclip to find out the files associated to existing database records. So we can't simply replace Paperclip with ActiveStorage. That's why it's usually recommended [1] to first run the migration and then replace Paperclip with ActiveStorage using two consecutive deployments. However, in our case we can't rely on two consecutive deployments because we have to make an easy process so existing CONSUL installations don't run into any issues. We can't just release version 1.4.0 and 1.5.0 and day and ask everyone to upgrade twice on the same day. Instead, we're following a different plan: * We're going to provide a Rake task (which will require Paperclip) to migrate existing files * We still use Paperclip to generate link and image tags * New files are handled using both Paperclip and ActiveStorage; that way, when we make the switch, we won't have to migrate them, and in the meantime they'll be accessible thanks to Paperclip * After we make the switch, we'll update the `name` column in the active storage attachments tables in order to remove the `storage_` prefix Regarding our handling of new files, the exception are cached attachments. Since those attachments are temporary files used while submitting a form and we have to delete them afterwards, we're only handling them with Paperclip. We'll handle these ones in version 1.5.0. Note the task creating the dev seeds was failing after these changes with an `ActiveStorage::IntegrityError` exception because we were opening some files without closing them. If the same file was attached twice, it failed the second time. We're solving it by closing the files with `File.open` and a block. Even though we didn't get any errors, we're doing the same thing in the `Attachable` concern because it's a good practice to close files after we're done with them. Also note we have to change the CKEditor Active Storage code so it's compatible with Paperclip. In this case, I haven't been able to write a test to confirm the attachment exists; I was getting the same `ActiveStorage::IntegrityError` mentioned above. Finally, we're updating the site customization image controller to use `update` so the image and the attachment are updated within the same transaction. This is also what we do in most controllers. [1] https://www.youtube.com/watch?v=tZ_WNUytO9o
77 lines
2.5 KiB
Ruby
77 lines
2.5 KiB
Ruby
module Attachable
|
|
include HasAttachment
|
|
extend ActiveSupport::Concern
|
|
|
|
included do
|
|
attr_accessor :cached_attachment
|
|
|
|
# Disable paperclip security validation due to polymorphic configuration
|
|
# Paperclip do not allow to use Procs on valiations definition
|
|
do_not_validate_attachment_file_type :attachment
|
|
validate :attachment_presence
|
|
validate :validate_attachment_content_type, if: -> { attachment.present? }
|
|
validate :validate_attachment_size, if: -> { attachment.present? }
|
|
|
|
before_save :set_attachment_from_cached_attachment, if: -> { cached_attachment.present? }
|
|
|
|
Paperclip.interpolates :prefix do |attachment, style|
|
|
attachment.instance.prefix(attachment, style)
|
|
end
|
|
end
|
|
|
|
def association_class
|
|
type = send("#{association_name}_type")
|
|
|
|
type.constantize if type.present?
|
|
end
|
|
|
|
def set_cached_attachment_from_attachment
|
|
self.cached_attachment = if Paperclip::Attachment.default_options[:storage] == :filesystem
|
|
attachment.path
|
|
else
|
|
attachment.url
|
|
end
|
|
end
|
|
|
|
def set_attachment_from_cached_attachment
|
|
if Paperclip::Attachment.default_options[:storage] == :filesystem
|
|
File.open(cached_attachment) { |file| self.attachment = file }
|
|
else
|
|
self.attachment = URI.parse(cached_attachment)
|
|
end
|
|
end
|
|
|
|
def prefix(attachment, _style)
|
|
if attachment.instance.persisted?
|
|
":attachment/:id_partition"
|
|
else
|
|
"cached_attachments/user/#{attachment.instance.user_id}"
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def validate_attachment_size
|
|
if association_class && attachment_file_size > max_file_size.megabytes
|
|
errors.add(:attachment, I18n.t("#{model_name.plural}.errors.messages.in_between",
|
|
min: "0 Bytes",
|
|
max: "#{max_file_size} MB"))
|
|
end
|
|
end
|
|
|
|
def validate_attachment_content_type
|
|
if association_class && !accepted_content_types.include?(attachment_content_type)
|
|
message = I18n.t("#{model_name.plural}.errors.messages.wrong_content_type",
|
|
content_type: attachment_content_type,
|
|
accepted_content_types: self.class.humanized_accepted_content_types)
|
|
errors.add(:attachment, message)
|
|
end
|
|
end
|
|
|
|
def attachment_presence
|
|
if attachment.blank? && cached_attachment.blank?
|
|
errors.add(:attachment, I18n.t("errors.messages.blank"))
|
|
end
|
|
end
|
|
end
|