This way it's more clear what the user experience is during the process. Note this did not result in flaky tests, since the tests continue by clicking links, that are only present after the request has finished. However, we're adding expectations so we don't have to think whether the tests could be flaky and because this way we're also testing the user experience; it would be strange for a user if they were redirected to a page without a flash message.
84 lines
2.1 KiB
Ruby
84 lines
2.1 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "SMS Verification" do
|
|
scenario "Verify" do
|
|
user = create(:user, residence_verified_at: Time.current)
|
|
login_as(user)
|
|
|
|
visit new_sms_path
|
|
|
|
fill_in "sms_phone", with: "611111111"
|
|
click_button "Send"
|
|
|
|
expect(page).to have_content "Security code confirmation"
|
|
|
|
user = user.reload
|
|
fill_in "sms_confirmation_code", with: user.sms_confirmation_code
|
|
click_button "Send"
|
|
|
|
expect(page).to have_content "Code correct"
|
|
end
|
|
|
|
scenario "Errors on phone number" do
|
|
user = create(:user, residence_verified_at: Time.current)
|
|
login_as(user)
|
|
|
|
visit new_sms_path
|
|
|
|
click_button "Send"
|
|
|
|
expect(page).to have_content error_message("phone")
|
|
end
|
|
|
|
scenario "Errors on verification code" do
|
|
user = create(:user, residence_verified_at: Time.current)
|
|
login_as(user)
|
|
|
|
visit new_sms_path
|
|
|
|
fill_in "sms_phone", with: "611111111"
|
|
click_button "Send"
|
|
|
|
expect(page).to have_content "Security code confirmation"
|
|
|
|
click_button "Send"
|
|
|
|
expect(page).to have_content "Incorrect confirmation code"
|
|
end
|
|
|
|
scenario "Deny access unless residency verified" do
|
|
user = create(:user)
|
|
login_as(user)
|
|
|
|
visit new_sms_path
|
|
|
|
expect(page).to have_content "You have not yet confirmed your residency"
|
|
expect(page).to have_current_path(new_residence_path)
|
|
end
|
|
|
|
scenario "5 tries allowed" do
|
|
user = create(:user, residence_verified_at: Time.current)
|
|
login_as(user)
|
|
|
|
visit new_sms_path
|
|
|
|
5.times do
|
|
fill_in "sms_phone", with: "611111111"
|
|
click_button "Send"
|
|
|
|
expect(page).to have_content "Enter the confirmation code sent to you by text message"
|
|
|
|
click_link "Click here to send it again"
|
|
|
|
expect(page).not_to have_content "Enter the confirmation code sent to you by text message"
|
|
end
|
|
|
|
expect(page).to have_content "You have reached the maximum number of attempts. Please try again later."
|
|
expect(page).to have_current_path(account_path)
|
|
|
|
visit new_sms_path
|
|
expect(page).to have_content "You have reached the maximum number of attempts. Please try again later."
|
|
expect(page).to have_current_path(account_path)
|
|
end
|
|
end
|