We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
50 lines
1.2 KiB
Ruby
50 lines
1.2 KiB
Ruby
require "rails_helper"
|
|
|
|
describe PagesController do
|
|
describe "Static pages" do
|
|
it "includes a privacy page" do
|
|
get :show, params: { id: :privacy }
|
|
expect(response).to be_ok
|
|
end
|
|
|
|
it "includes a conditions page" do
|
|
get :show, params: { id: :conditions }
|
|
expect(response).to be_ok
|
|
end
|
|
|
|
it "includes a accessibility page" do
|
|
get :show, params: { id: :accessibility }
|
|
expect(response).to be_ok
|
|
end
|
|
end
|
|
|
|
describe "More info pages" do
|
|
it "includes a more info page" do
|
|
get :show, params: { id: "help/index" }
|
|
expect(response).to be_ok
|
|
end
|
|
|
|
it "includes a how_to_use page" do
|
|
get :show, params: { id: "help/how_to_use/index" }
|
|
expect(response).to be_ok
|
|
end
|
|
|
|
it "includes a faq page" do
|
|
get :show, params: { id: :faq }
|
|
expect(response).to be_ok
|
|
end
|
|
end
|
|
|
|
describe "Not found pages" do
|
|
it "returns a 404 message" do
|
|
get :show, params: { id: "nonExistentPage" }
|
|
expect(response).to be_missing
|
|
end
|
|
|
|
it "returns a 404 message for a JavaScript request" do
|
|
get :show, params: { id: "nonExistentJavaScript.js" }
|
|
expect(response).to be_missing
|
|
end
|
|
end
|
|
end
|