1b8a079727
As mentioned in commits likea586ba806,a7664ad81,006128da5,b41fbfa52andc480cdd91, accessing the database after starting the browser with the `visit` method sometimes results in database corruption and failing tests on our CI due to the process running the test accessing the database after the process running the browser has started. For example, one of these tests has recently failed on our CI: ``` 3) Users Create a level 3 user with email from scratch Failure/Error: expect(user.reload).to be_confirmed expected `#<User id: 2060, email: "pepe@gmail.com", created_at: "2025-03-12 19:51:03.688867000 +0100", updated_...d_debates: true, recommended_proposals: true, subscriptions_token: nil, registering_from_web: false>.confirmed?` to be truthy, got false ``` IMHO this is also a bad practice for system tests, since these tests should be checking what users experience. So we're modifying the tests to check the results of users interaction from the point of view of the users. For example, instead of checking that a user is now level 3 verified in the database, we're checking that the user interface states that the user is level 3 verified. Note we're adding an offset when editing the map marker by clicking on `map-location` with `.click(x: 30, y: 30)`. This way we make sure that both the latitude and longitude change from the original values; we used to clicking in the middle (no offset), which didn't change the longitude and changed the latitude just by coincidence. Also note we aren't changing tests with the `:no_js` tag, since these tests don't run a real browser in a separate process. In the future, we should also change most of these tests so they don't access the database and they use a real browser.
310 lines
10 KiB
Ruby
310 lines
10 KiB
Ruby
shared_examples "mappable" do |mappable_factory_name, mappable_association_name,
|
|
mappable_new_path, mappable_edit_path, mappable_show_path,
|
|
mappable_path_arguments: {},
|
|
management: false|
|
|
let!(:user) { create(:user, :level_two) }
|
|
let!(:arguments) { {} }
|
|
let!(:mappable) { create(mappable_factory_name.to_s.to_sym) }
|
|
let(:management) { management }
|
|
let!(:map_location) do
|
|
create(:map_location, :"#{mappable_factory_name}_map_location", "#{mappable_association_name}": mappable)
|
|
end
|
|
|
|
before do
|
|
Setting["feature.map"] = true
|
|
end
|
|
|
|
describe "At #{mappable_new_path}" do
|
|
before { set_arguments(arguments, mappable, mappable_path_arguments) }
|
|
|
|
scenario "Should not show marker by default on create #{mappable_factory_name}" do
|
|
do_login_for user, management: management
|
|
visit send(mappable_new_path, arguments)
|
|
|
|
send("fill_in_#{mappable_factory_name}_form")
|
|
|
|
within ".map-location" do
|
|
expect(page).not_to have_css(".map-icon")
|
|
end
|
|
end
|
|
|
|
scenario "Should show marker on create #{mappable_factory_name} when click on map" do
|
|
do_login_for user, management: management
|
|
visit send(mappable_new_path, arguments)
|
|
|
|
send("fill_in_#{mappable_factory_name}_form")
|
|
find("#new_map_location").click
|
|
|
|
within ".map-location" do
|
|
expect(page).to have_css(".map-icon")
|
|
end
|
|
end
|
|
|
|
scenario "Should create #{mappable_factory_name} with map" do
|
|
do_login_for user, management: management
|
|
visit send(mappable_new_path, arguments)
|
|
|
|
send("fill_in_#{mappable_factory_name}_form")
|
|
find("#new_map_location").click
|
|
send("submit_#{mappable_factory_name}_form")
|
|
|
|
within ".map-location" do
|
|
expect(page).to have_css(".map-icon")
|
|
end
|
|
end
|
|
|
|
scenario "Can not display map on #{mappable_factory_name} when not fill marker on map" do
|
|
do_login_for user, management: management
|
|
visit send(mappable_new_path, arguments)
|
|
|
|
send("fill_in_#{mappable_factory_name}_form")
|
|
expect(page).to have_css ".map-location"
|
|
send("submit_#{mappable_factory_name}_form")
|
|
|
|
expect(page).not_to have_css(".map-location")
|
|
end
|
|
|
|
scenario "Can not display map on #{mappable_factory_name} when feature.map is disabled" do
|
|
Setting["feature.map"] = false
|
|
do_login_for user, management: management
|
|
visit send(mappable_new_path, arguments)
|
|
|
|
send("fill_in_#{mappable_factory_name}_form")
|
|
expect(page).not_to have_css ".map-location"
|
|
send("submit_#{mappable_factory_name}_form")
|
|
|
|
expect(page).not_to have_css(".map-location")
|
|
end
|
|
|
|
describe "When restoring the page from browser history" do
|
|
before { Setting["org_name"] = "CONSUL" }
|
|
|
|
scenario "map should not be duplicated" do
|
|
do_login_for user, management: management
|
|
visit send(mappable_new_path, arguments)
|
|
|
|
if management
|
|
click_link "Select user"
|
|
|
|
expect(page).to have_content "User management"
|
|
else
|
|
click_link "CONSUL"
|
|
|
|
expect(page).to have_content "Most active proposals"
|
|
end
|
|
|
|
go_back
|
|
|
|
within ".map-location" do
|
|
expect(page).to have_css(".leaflet-map-pane", count: 1)
|
|
end
|
|
end
|
|
|
|
scenario "keeps marker and zoom defined by the user" do
|
|
do_login_for user, management: management
|
|
visit send(mappable_new_path, arguments)
|
|
|
|
within ".map-location" do
|
|
expect(page).not_to have_css(".map-icon")
|
|
end
|
|
expect(page.execute_script("return App.Map.maps[0].getZoom();")).to eq(10)
|
|
|
|
map_zoom_in
|
|
find("#new_map_location").click
|
|
|
|
within ".map-location" do
|
|
expect(page).to have_css(".map-icon")
|
|
end
|
|
|
|
if management
|
|
click_link "Select user"
|
|
|
|
expect(page).to have_content "User management"
|
|
else
|
|
click_link "CONSUL"
|
|
|
|
expect(page).to have_content "Most active proposals"
|
|
end
|
|
|
|
go_back
|
|
|
|
within ".map-location" do
|
|
expect(page).to have_css(".map-icon")
|
|
expect(page.execute_script("return App.Map.maps[0].getZoom();")).to eq(11)
|
|
end
|
|
end
|
|
|
|
scenario "shows marker at map center" do
|
|
do_login_for user, management: management
|
|
visit send(mappable_new_path, arguments)
|
|
|
|
within ".map-location" do
|
|
expect(page).not_to have_css(".map-icon")
|
|
end
|
|
|
|
place_map_at(-68.592487, -62.391357)
|
|
find("#new_map_location").click
|
|
|
|
within ".map-location" do
|
|
expect(page).to have_css(".map-icon")
|
|
end
|
|
|
|
if management
|
|
click_link "Select user"
|
|
|
|
expect(page).to have_content "User management"
|
|
else
|
|
click_link "CONSUL"
|
|
|
|
expect(page).to have_content "Most active proposals"
|
|
end
|
|
|
|
go_back
|
|
|
|
within ".map-location" do
|
|
expect(page).to have_css(".map-icon")
|
|
end
|
|
end
|
|
end
|
|
|
|
scenario "Skip map" do
|
|
do_login_for user, management: management
|
|
visit send(mappable_new_path, arguments)
|
|
|
|
send("fill_in_#{mappable_factory_name}_form")
|
|
send("submit_#{mappable_factory_name}_form")
|
|
|
|
expect(page).not_to have_content "Map location can't be blank"
|
|
end
|
|
end
|
|
|
|
describe "At #{mappable_edit_path}", if: mappable_edit_path.present? do
|
|
scenario "Should edit map on #{mappable_factory_name} and contain default values" do
|
|
mappable.map_location.update!(latitude: 51.48, longitude: 0.0)
|
|
do_login_for mappable.author, management: management
|
|
|
|
visit send(mappable_edit_path, id: mappable.id)
|
|
|
|
expect(page).to have_content "Navigate the map to the location and place the marker."
|
|
expect(page).to have_field "#{mappable_factory_name}_map_location_attributes_latitude", type: :hidden,
|
|
with: "51.48"
|
|
expect(page).to have_field "#{mappable_factory_name}_map_location_attributes_longitude", type: :hidden,
|
|
with: "0.0"
|
|
end
|
|
|
|
scenario "Should edit default values from map on #{mappable_factory_name} edit page" do
|
|
original_longitude = map_location.longitude
|
|
original_latitude = map_location.latitude
|
|
|
|
do_login_for mappable.author, management: management
|
|
|
|
visit send(mappable_edit_path, id: mappable.id)
|
|
find(".map-location").click(x: 30, y: 30)
|
|
|
|
new_latitude = find_field(
|
|
"#{mappable_factory_name}_map_location_attributes_latitude", type: :hidden
|
|
).value
|
|
new_longitude = find_field(
|
|
"#{mappable_factory_name}_map_location_attributes_longitude", type: :hidden
|
|
).value
|
|
|
|
click_button "Save changes"
|
|
|
|
expect(page).not_to have_button "Save changes"
|
|
expect(page).to have_css ".map-location"
|
|
expect(page).to have_css ".map-location[data-marker-latitude='#{new_latitude}']"
|
|
expect(page).to have_css ".map-location[data-marker-longitude='#{new_longitude}']"
|
|
expect(page).not_to have_css ".map-location[data-marker-latitude='#{original_latitude}']"
|
|
expect(page).not_to have_css ".map-location[data-marker-longitude='#{original_longitude}']"
|
|
end
|
|
|
|
scenario "Should edit mappable on #{mappable_factory_name} without change map" do
|
|
original_longitude = map_location.longitude
|
|
original_latitude = map_location.latitude
|
|
|
|
do_login_for mappable.author, management: management
|
|
|
|
visit send(mappable_edit_path, id: mappable.id)
|
|
fill_in "#{mappable_factory_name.camelize} title", with: "New title"
|
|
click_button "Save changes"
|
|
|
|
expect(page).not_to have_button "Save changes"
|
|
expect(page).to have_css ".map-location"
|
|
expect(page).to have_css ".map-location[data-marker-latitude='#{original_latitude}']"
|
|
expect(page).to have_css ".map-location[data-marker-longitude='#{original_longitude}']"
|
|
end
|
|
|
|
scenario "Can not display map on #{mappable_factory_name} edit when remove map marker" do
|
|
do_login_for mappable.author, management: management
|
|
|
|
visit send(mappable_edit_path, id: mappable.id)
|
|
click_button "Remove map marker"
|
|
click_button "Save changes"
|
|
|
|
expect(page).not_to have_button "Save changes"
|
|
expect(page).not_to have_css ".map-location"
|
|
end
|
|
|
|
scenario "Can not display map on #{mappable_factory_name} edit when feature.map is disabled" do
|
|
Setting["feature.map"] = false
|
|
do_login_for mappable.author, management: management
|
|
|
|
visit send(mappable_edit_path, id: mappable.id)
|
|
fill_in "#{mappable_factory_name.camelize} title", with: "New title"
|
|
click_button "Save changes"
|
|
|
|
expect(page).not_to have_button "Save changes"
|
|
expect(page).not_to have_css ".map-location"
|
|
end
|
|
|
|
scenario "No need to skip map on update" do
|
|
do_login_for mappable.author, management: management
|
|
|
|
visit send(mappable_edit_path, id: mappable.id)
|
|
click_button "Remove map marker"
|
|
click_button "Save changes"
|
|
|
|
expect(page).not_to have_button "Save changes"
|
|
expect(page).not_to have_content "Map location can't be blank"
|
|
end
|
|
end
|
|
|
|
describe "At #{mappable_show_path}" do
|
|
before do
|
|
set_arguments(arguments, mappable, mappable_path_arguments)
|
|
end
|
|
|
|
scenario "Should display map and marker on #{mappable_factory_name} show page" do
|
|
arguments[:id] = mappable.id
|
|
|
|
do_login_for user, management: management if management
|
|
visit send(mappable_show_path, arguments)
|
|
|
|
within ".map-location" do
|
|
expect(page).to have_css(".map-icon")
|
|
end
|
|
end
|
|
|
|
scenario "Should not display map on #{mappable_factory_name} show when marker is not defined" do
|
|
mappable_without_map = create(mappable_factory_name.to_s.to_sym)
|
|
set_arguments(arguments, mappable_without_map, mappable_path_arguments)
|
|
arguments[:id] = mappable_without_map.id
|
|
|
|
do_login_for user, management: management if management
|
|
visit send(mappable_show_path, arguments)
|
|
|
|
expect(page).not_to have_css(".map-location")
|
|
end
|
|
|
|
scenario "Should not display map on #{mappable_factory_name} show page when feature.map is disable" do
|
|
Setting["feature.map"] = false
|
|
arguments[:id] = mappable.id
|
|
|
|
do_login_for user, management: management if management
|
|
visit send(mappable_show_path, arguments)
|
|
|
|
expect(page).not_to have_css(".map-location")
|
|
end
|
|
end
|
|
end
|