consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
8f20ee1a33a1a8751678239b6dae1824e1283a7b
nairobi/spec/models
History
Javi Martín 8f20ee1a33 Move related content validation to the model 
We were manually checking validation rules (like both relationable
objects are present, or they're both the same object) in the controller
and then using the `save!` method.

However, we usually use the `save` method (which checks all validations)
in a condition, and proceed depending on the result.

Now we're taking the same approach here. This means introducing a new
validation rule in the model to check whether both relationable objects
are the same, which is more robust than checking a condition in the
controller.
2021-06-23 23:13:58 +02:00
..
abilities
Allow users to remove their support on investments
2021-06-14 14:46:54 +02:00
ahoy
Apply explict RSpec/DescribedClass rubocop rule
2019-09-23 16:51:00 +02:00
budget
Hide group name only on budgets with one group
2021-06-11 14:43:18 +02:00
concerns
Add main link to each phase of the budget
2021-06-09 21:51:39 +02:00
custom
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
dashboard
Add and apply RSpec/ContextMethod rubocop rule
2020-10-25 14:23:53 +01:00
legislation
Validate process dates depending on enabled phases
2021-05-29 14:13:48 +02:00
local_census_records
Add and apply RSpec/ContextMethod rubocop rule
2020-10-25 14:23:53 +01:00
milestone
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
officing
Mock remote census responses in tests using XML
2020-11-02 11:42:39 +01:00
poll
Don't assign IDs to assignment records in tests
2021-06-17 01:46:48 +02:00
sdg
Add SDG goals/targets to legislation proposals
2021-02-24 20:42:53 +01:00
site_customization
Add globalizable tests for all translatable models
2019-09-23 18:01:44 +02:00
verification
Extract block to configure remote census in tests
2020-11-02 11:42:39 +01:00
widget
Fix header card factory
2021-05-29 14:18:31 +02:00
activity_spec.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
admin_notification_spec.rb
Fix admin notification with relative URLs
2021-03-31 14:03:26 +02:00
administrator_spec.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
banner_spec.rb
Adding consistency in banner scopes
2021-04-08 17:23:30 +02:00
budget_spec.rb
Add type to budget index table
2021-06-11 00:51:52 +02:00
comment_spec.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
community_spec.rb
Use hash conditions instead of SQL's IN
2020-07-08 18:34:58 +02:00
debate_spec.rb
Improve test checking order by relevance
2020-07-14 14:49:39 +02:00
direct_message_spec.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
direct_upload_spec.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
document_spec.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
flag_spec.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
follow_spec.rb
Avoid a brakeman security warning
2021-04-13 13:52:18 +02:00
geozone_spec.rb
Delete spending proposals
2019-05-31 18:22:59 +02:00
i18n_content_spec.rb
Cache I18nContent translations
2020-12-15 11:57:09 +01:00
identity_spec.rb
Change single quotes to double quotes
2019-02-15 11:40:39 +01:00
image_spec.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
link_spec.rb
Fix more hound warnings
2019-03-27 15:22:14 +01:00
local_census_record_spec.rb
Validate inclusion of document type in allowed document types
2019-11-07 16:26:19 +01:00
lock_spec.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
map_location_spec.rb
Add and apply RSpec/ContextMethod rubocop rule
2020-10-25 14:23:53 +01:00
milestone_spec.rb
Fix milestone publication date comparison
2019-10-10 02:35:20 +02:00
newsletter_spec.rb
Apply rubocop Rails/FindBy rule everywhere
2019-11-08 19:15:04 +01:00
notification_spec.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
organization_spec.rb
Add and apply RSpec/EmptyLineAfterExample rule
2020-10-25 14:23:53 +01:00
progress_bar_spec.rb
Apply Rails/SaveBang rubocop rule
2019-10-23 14:39:31 +02:00
proposal_notification_spec.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
proposal_spec.rb
Bump acts-as-taggable-on to 6.0.0
2020-04-23 18:49:43 +02:00
related_content_score_spec.rb
Added relation score specs
2019-10-20 15:03:05 +02:00
related_content_spec.rb
Move related content validation to the model
2021-06-23 23:13:58 +02:00
remote_translation_spec.rb
Allow remote translation tests to be run offline
2020-04-28 15:45:50 +02:00
setting_spec.rb
Include new type 'sdg' on settings
2020-12-03 18:00:10 +01:00
signature_sheet_spec.rb
Mock remote census responses in tests using XML
2020-11-02 11:42:39 +01:00
signature_spec.rb
Mock remote census responses in tests using XML
2020-11-02 11:42:39 +01:00
statisticable_spec.rb
Add and apply ConstantDefinitionInBlock rule
2020-10-23 12:04:22 +02:00
stats_version_spec.rb
Add table to store stats versions
2019-05-21 13:50:19 +02:00
tag_cloud_spec.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
tag_spec.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
topic_spec.rb
Add and appy RSpec/RepeatedExampleGroupBody rule
2020-10-25 14:23:53 +01:00
user_spec.rb
Merge pull request #4442 from consul/user_search
2021-04-13 18:31:34 +02:00
valuator_group_spec.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
valuator_spec.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
vote_spec.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00