e7f6e39679
Note: The parser error message format changed in GraphQL 2.2.0 due to the introduction of a new optimized lexer and a hand-written parser (PR 4718). This commit updates the `parser_error_raised?` method in the GraphqlController tests to correctly detect errors using the new message format. The previous pattern was checking for "Parse error on", but with the new version, the error message now contains "Expected one of". This change ensures that the tests for malformed queries continue to pass as expected. Bumps [graphql](https://github.com/rmosolgo/graphql-ruby) from 2.0.31 to 2.3.18. - [Release notes](https://github.com/rmosolgo/graphql-ruby/releases) - [Changelog](https://github.com/rmosolgo/graphql-ruby/blob/master/CHANGELOG.md) - [Commits](https://github.com/rmosolgo/graphql-ruby/compare/v2.0.31...v2.3.18) --- updated-dependencies: - dependency-name: graphql dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
99 lines
3.2 KiB
Ruby
99 lines
3.2 KiB
Ruby
require "rails_helper"
|
|
|
|
# Useful resource: http://graphql.org/learn/serving-over-http/
|
|
|
|
describe GraphqlController, type: :request do
|
|
let(:proposal) { create(:proposal) }
|
|
|
|
describe "handles GET request" do
|
|
specify "with query string inside query params" do
|
|
get "/graphql", params: { query: "{ proposal(id: #{proposal.id}) { title } }" }
|
|
|
|
expect(response).to have_http_status(:ok)
|
|
expect(response.parsed_body["data"]["proposal"]["title"]).to eq(proposal.title)
|
|
end
|
|
|
|
specify "with malformed query string" do
|
|
get "/graphql", params: { query: "Malformed query string" }
|
|
|
|
expect(response).to have_http_status(:ok)
|
|
expect(response.parsed_body["data"]).to be nil
|
|
expect(response.parsed_body["errors"]).to be_present
|
|
end
|
|
|
|
specify "without query string" do
|
|
get "/graphql"
|
|
|
|
expect(response).to have_http_status(:bad_request)
|
|
expect(response.parsed_body["message"]).to eq("Query string not present")
|
|
end
|
|
end
|
|
|
|
describe "handles POST request" do
|
|
let(:json_headers) { { "CONTENT_TYPE" => "application/json" } }
|
|
|
|
specify "with json-encoded query string inside body" do
|
|
post "/graphql", params: { query: "{ proposal(id: #{proposal.id}) { title } }" }.to_json,
|
|
headers: json_headers
|
|
|
|
expect(response).to have_http_status(:ok)
|
|
expect(response.parsed_body["data"]["proposal"]["title"]).to eq(proposal.title)
|
|
end
|
|
|
|
specify "with raw query string inside body" do
|
|
graphql_headers = { "CONTENT_TYPE" => "application/graphql" }
|
|
post "/graphql", params: "{ proposal(id: #{proposal.id}) { title } }",
|
|
headers: graphql_headers
|
|
|
|
expect(response).to have_http_status(:ok)
|
|
expect(response.parsed_body["data"]["proposal"]["title"]).to eq(proposal.title)
|
|
end
|
|
|
|
specify "with malformed query string" do
|
|
post "/graphql", params: { query: "Malformed query string" }.to_json, headers: json_headers
|
|
|
|
expect(response).to have_http_status(:ok)
|
|
expect(response.parsed_body["data"]).to be nil
|
|
expect(response.parsed_body["errors"]).to be_present
|
|
end
|
|
|
|
it "without query string" do
|
|
post "/graphql", headers: json_headers
|
|
|
|
expect(response).to have_http_status(:bad_request)
|
|
expect(response.parsed_body["message"]).to eq("Query string not present")
|
|
end
|
|
end
|
|
|
|
describe "correctly parses query variables" do
|
|
let(:query_string) { "{ proposal(id: #{proposal.id}) { title } }" }
|
|
|
|
specify "when absent" do
|
|
get "/graphql", params: { query: query_string }
|
|
|
|
expect(response).to have_http_status(:ok)
|
|
end
|
|
|
|
specify "when specified as the 'null' string" do
|
|
get "/graphql", params: { query: query_string, variables: "null" }
|
|
|
|
expect(response).to have_http_status(:ok)
|
|
end
|
|
|
|
specify "when specified as an empty string" do
|
|
get "/graphql", params: { query: query_string, variables: "" }
|
|
|
|
expect(response).to have_http_status(:ok)
|
|
end
|
|
end
|
|
|
|
context "feature flag is set to false" do
|
|
before { Setting["feature.graphql_api"] = false }
|
|
|
|
it "is disabled" do
|
|
expect { get "/graphql" }.to raise_exception(FeatureFlags::FeatureDisabled)
|
|
expect { post "/graphql" }.to raise_exception(FeatureFlags::FeatureDisabled)
|
|
end
|
|
end
|
|
end
|