8b13daad95
For the HashAlignment rule, we're using the default `key` style (keys are aligned and values aren't) instead of the `table` style (both keys and values are aligned) because, even if we used both in the application, we used the `key` style a lot more. Furthermore, the `table` style looks strange in places where there are both very long and very short keys and sometimes we weren't even consistent with the `table` style, aligning some keys without aligning other keys. Ideally we could align hashes to "either key or table", so developers can decide whether keeping the symmetry of the code is worth it in a case-per-case basis, but Rubocop doesn't allow this option.
186 lines
6.9 KiB
Ruby
186 lines
6.9 KiB
Ruby
require "rails_helper"
|
|
|
|
describe Legislation::AnnotationsController do
|
|
describe "GET show" do
|
|
it "finds the annotation when it belongs to the draft version" do
|
|
version = create(:legislation_draft_version)
|
|
annotation = create(:legislation_annotation, draft_version: version)
|
|
|
|
get :show, params: { process_id: version.process, draft_version_id: version, id: annotation }
|
|
|
|
expect(response).to be_ok
|
|
end
|
|
|
|
it "returns a 404 when the annotation belongs to a different draft version" do
|
|
version = create(:legislation_draft_version)
|
|
annotation = create(:legislation_annotation, draft_version: version)
|
|
other_version = create(:legislation_draft_version, process: version.process)
|
|
|
|
expect do
|
|
get :show, params: { process_id: version.process, draft_version_id: other_version, id: annotation }
|
|
end.to raise_error ActiveRecord::RecordNotFound
|
|
end
|
|
end
|
|
|
|
describe "POST create" do
|
|
let(:legal_process) do
|
|
create(:legislation_process, allegations_start_date: Date.current - 3.days,
|
|
allegations_end_date: Date.current + 2.days)
|
|
end
|
|
let(:draft_version) do
|
|
create(:legislation_draft_version, :published, process: legal_process, title: "Version 1")
|
|
end
|
|
let(:final_version) do
|
|
create(:legislation_draft_version, :published, :final_version,
|
|
process: legal_process, title: "Final version")
|
|
end
|
|
let(:user) { create(:user, :level_two) }
|
|
|
|
it "creates an ahoy event" do
|
|
sign_in user
|
|
|
|
post :create, params: {
|
|
process_id: legal_process.id,
|
|
draft_version_id: draft_version.id,
|
|
legislation_annotation: {
|
|
"quote" => "ipsum",
|
|
"ranges" => [{
|
|
"start" => "/p[1]",
|
|
"startOffset" => 6,
|
|
"end" => "/p[1]",
|
|
"endOffset" => 11
|
|
}],
|
|
"text" => "una anotacion"
|
|
}
|
|
}
|
|
expect(Ahoy::Event.where(name: :legislation_annotation_created).count).to eq 1
|
|
expect(Ahoy::Event.last.properties["legislation_annotation_id"]).to eq Legislation::Annotation.last.id
|
|
end
|
|
|
|
it "does not create an annotation if the draft version is a final version" do
|
|
sign_in user
|
|
|
|
post :create, params: {
|
|
process_id: legal_process.id,
|
|
draft_version_id: final_version.id,
|
|
legislation_annotation: {
|
|
"quote" => "ipsum",
|
|
"ranges" => [{
|
|
"start" => "/p[1]",
|
|
"startOffset" => 6,
|
|
"end" => "/p[1]",
|
|
"endOffset" => 11
|
|
}],
|
|
"text" => "una anotacion"
|
|
}
|
|
}
|
|
|
|
expect(response).to have_http_status(:not_found)
|
|
end
|
|
|
|
it "creates an annotation if the process allegations phase is open" do
|
|
sign_in user
|
|
|
|
expect do
|
|
post :create, xhr: true,
|
|
params: {
|
|
process_id: legal_process.id,
|
|
draft_version_id: draft_version.id,
|
|
legislation_annotation: {
|
|
"quote" => "ipsum",
|
|
"ranges" => [{
|
|
"start" => "/p[1]",
|
|
"startOffset" => 6,
|
|
"end" => "/p[1]",
|
|
"endOffset" => 11
|
|
}],
|
|
"text" => "una anotacion"
|
|
}
|
|
}
|
|
end.to change { draft_version.annotations.count }.by(1)
|
|
end
|
|
|
|
it "does not create an annotation if the process allegations phase is not open" do
|
|
sign_in user
|
|
legal_process.update!(allegations_end_date: Date.current - 1.day)
|
|
|
|
expect do
|
|
post :create, xhr: true,
|
|
params: {
|
|
process_id: legal_process.id,
|
|
draft_version_id: draft_version.id,
|
|
legislation_annotation: {
|
|
"quote" => "ipsum",
|
|
"ranges" => [{
|
|
"start" => "/p[1]",
|
|
"startOffset" => 6,
|
|
"end" => "/p[1]",
|
|
"endOffset" => 11
|
|
}],
|
|
"text" => "una anotacion"
|
|
}
|
|
}
|
|
end.not_to change { draft_version.annotations.count }
|
|
end
|
|
|
|
it "creates an annotation by parsing parameters in JSON" do
|
|
sign_in user
|
|
|
|
expect do
|
|
post :create, xhr: true,
|
|
params: {
|
|
process_id: legal_process.id,
|
|
draft_version_id: draft_version.id,
|
|
legislation_annotation: {
|
|
"quote" => "ipsum",
|
|
"ranges" => [{
|
|
"start" => "/p[1]",
|
|
"startOffset" => 6,
|
|
"end" => "/p[1]",
|
|
"endOffset" => 11
|
|
}].to_json,
|
|
"text" => "una anotacion"
|
|
}
|
|
}
|
|
end.to change { draft_version.annotations.count }.by(1)
|
|
end
|
|
|
|
it "creates a new comment on an existing annotation when range is the same" do
|
|
annotation = create(:legislation_annotation, draft_version: draft_version,
|
|
text: "my annotation",
|
|
ranges: [{
|
|
"start" => "/p[1]",
|
|
"startOffset" => 6,
|
|
"end" => "/p[1]",
|
|
"endOffset" => 11
|
|
}],
|
|
range_start: "/p[1]",
|
|
range_start_offset: 6,
|
|
range_end: "/p[1]",
|
|
range_end_offset: 11)
|
|
sign_in user
|
|
|
|
expect do
|
|
post :create, xhr: true,
|
|
params: {
|
|
process_id: legal_process.id,
|
|
draft_version_id: draft_version.id,
|
|
legislation_annotation: {
|
|
"quote" => "ipsum",
|
|
"ranges" => [{
|
|
"start" => "/p[1]",
|
|
"startOffset" => 6,
|
|
"end" => "/p[1]",
|
|
"endOffset" => 11
|
|
}],
|
|
"text" => "una anotacion"
|
|
}
|
|
}
|
|
end.not_to change { draft_version.annotations.count }
|
|
|
|
expect(annotation.reload.comments_count).to eq(2)
|
|
expect(annotation.comments.last.body).to eq("una anotacion")
|
|
end
|
|
end
|
|
end
|