We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
40 lines
1.5 KiB
Ruby
40 lines
1.5 KiB
Ruby
require "rails_helper"
|
|
|
|
RSpec.describe "welcome#index" do
|
|
it "Display images on orbit carrousel when we have defined image_default" do
|
|
debate = create(:debate)
|
|
|
|
render template: "welcome/_recommended_carousel.html.erb",
|
|
locals: { key: "debates",
|
|
recommendeds: [debate],
|
|
image_field: nil,
|
|
image_version: nil,
|
|
image_default: "https://dummyimage.com/600x400/000/fff",
|
|
carousel_size: "medium-6 large-6 medium-centered large-centered",
|
|
btn_text_link: t("welcome.recommended.debates.btn_text_link"),
|
|
btn_path_link: debates_path(order: "recommendations") }
|
|
|
|
within 'li[data-slide="0"] .card' do
|
|
expect(page).to have_selector("img")
|
|
end
|
|
end
|
|
|
|
it "Not display images on orbit carrousel when we have not defined image_default" do
|
|
debate = create(:debate)
|
|
|
|
render template: "welcome/_recommended_carousel.html.erb",
|
|
locals: { key: "debates",
|
|
recommendeds: [debate],
|
|
image_field: nil,
|
|
image_version: nil,
|
|
image_default: nil,
|
|
carousel_size: "medium-6 large-6 medium-centered large-centered",
|
|
btn_text_link: t("welcome.recommended.debates.btn_text_link"),
|
|
btn_path_link: debates_path(order: "recommendations") }
|
|
|
|
within 'li[data-slide="0"] .card' do
|
|
expect(page).not_to have_selector("img")
|
|
end
|
|
end
|
|
end
|