This rule was added in rubocop 1.44.0. It's useful to avoid accidental `unless !condition` clauses. Note we aren't replacing `unless zero?` with `if nonzero?` because we never use `nonzero?`; using it sounds like `if !zero?`. Replacing `unless any?` with `if none?` is only consistent if we also replace `unless present?` with `if blank?`, so we're also adding this case. For consistency, we're also replacing `unless blank?` with `if present?`. We're also simplifying code dealing with `> 0` conditions in order to make the code (hopefully) easier to understand. Also for consistency, we're enabling the `Style/InverseMethods` rule, which follows a similar idea.
79 lines
2.0 KiB
Ruby
79 lines
2.0 KiB
Ruby
class SiteCustomization::Image < ApplicationRecord
|
|
VALID_IMAGES = {
|
|
"logo_header" => [260, 80],
|
|
"social_media_icon" => [470, 246],
|
|
"social_media_icon_twitter" => [246, 246],
|
|
"apple-touch-icon-200" => [200, 200],
|
|
"auth_bg" => [1280, 1500],
|
|
"budget_execution_no_image" => [800, 600],
|
|
"budget_investment_no_image" => [800, 600],
|
|
"favicon" => [16, 16],
|
|
"map" => [420, 500],
|
|
"logo_email" => [400, 80],
|
|
"welcome_process" => [370, 185]
|
|
}.freeze
|
|
|
|
VALID_MIME_TYPES = %w[
|
|
image/jpeg
|
|
image/png
|
|
image/vnd.microsoft.icon
|
|
image/x-icon
|
|
].freeze
|
|
|
|
has_one_attached :image
|
|
|
|
validates :name, presence: true, uniqueness: true, inclusion: { in: ->(*) { VALID_IMAGES.keys }}
|
|
validates :image, file_content_type: { allow: ->(*) { VALID_MIME_TYPES }, if: -> { image.attached? }}
|
|
validate :check_image
|
|
|
|
def self.all_images
|
|
VALID_IMAGES.keys.map do |image_name|
|
|
find_by(name: image_name) || create!(name: image_name.to_s)
|
|
end
|
|
end
|
|
|
|
def self.image_for(filename)
|
|
image_name = filename.split(".").first
|
|
|
|
find_by(name: image_name)&.persisted_image
|
|
end
|
|
|
|
def required_width
|
|
VALID_IMAGES[name]&.first
|
|
end
|
|
|
|
def required_height
|
|
VALID_IMAGES[name]&.second
|
|
end
|
|
|
|
def persisted_image
|
|
image if persisted_attachment?
|
|
end
|
|
|
|
def persisted_attachment?
|
|
image.attachment&.persisted?
|
|
end
|
|
|
|
private
|
|
|
|
def check_image
|
|
return unless image.attached?
|
|
|
|
unless image.analyzed?
|
|
attachment_changes["image"].upload
|
|
image.analyze
|
|
end
|
|
|
|
width = image.metadata[:width]
|
|
height = image.metadata[:height]
|
|
|
|
if name == "logo_header"
|
|
errors.add(:image, :image_width, required_width: required_width) if width > required_width
|
|
else
|
|
errors.add(:image, :image_width, required_width: required_width) unless width == required_width
|
|
end
|
|
|
|
errors.add(:image, :image_height, required_height: required_height) unless height == required_height
|
|
end
|
|
end
|