28aafbd4bc
This rule was added in rubocop 1.44.0. It's useful to avoid accidental `unless !condition` clauses. Note we aren't replacing `unless zero?` with `if nonzero?` because we never use `nonzero?`; using it sounds like `if !zero?`. Replacing `unless any?` with `if none?` is only consistent if we also replace `unless present?` with `if blank?`, so we're also adding this case. For consistency, we're also replacing `unless blank?` with `if present?`. We're also simplifying code dealing with `> 0` conditions in order to make the code (hopefully) easier to understand. Also for consistency, we're enabling the `Style/InverseMethods` rule, which follows a similar idea.
8 lines
144 B
Ruby
8 lines
144 B
Ruby
module Conflictable
|
|
extend ActiveSupport::Concern
|
|
|
|
def conflictive?
|
|
flags_count > 0 && cached_votes_up / flags_count.to_f < 5
|
|
end
|
|
end
|