7ca55c44e0
Having exceptions is better than having silent bugs.
There are a few methods I've kept the same way they were.
The `RelatedContentScore#score_with_opposite` method is a bit peculiar:
it creates scores for both itself and the opposite related content,
which means the opposite related content will try to create the same
scores as well.
We've already got a test to check `Budget::Ballot#add_investment` when
creating a line fails ("Edge case voting a non-elegible investment").
Finally, the method `User#send_oauth_confirmation_instructions` doesn't
update the record when the email address isn't already present, leading
to the test "Try to register with the email of an already existing user,
when an unconfirmed email was provided by oauth" fo fail if we raise an
exception for an invalid user. That's because updating a user's email
doesn't update the database automatically, but instead a confirmation
email is sent.
There are also a few false positives for classes which don't have bang
methods (like the GraphQL classes) or destroying attachments.
For these reasons, I'm adding the rule with a "Refactor" severity,
meaning it's a rule we can break if necessary.
248 lines
9.3 KiB
Ruby
248 lines
9.3 KiB
Ruby
shared_examples_for "verifiable" do
|
|
let(:model) { described_class }
|
|
|
|
describe "#scopes" do
|
|
describe "#level_three_verified" do
|
|
it "returns level three verified users" do
|
|
user1 = create(:user, verified_at: Time.current)
|
|
user2 = create(:user, verified_at: nil)
|
|
|
|
expect(model.level_three_verified).to eq [user1]
|
|
expect(model.level_three_verified).not_to include(user2)
|
|
end
|
|
end
|
|
|
|
describe "#level_two_verified" do
|
|
it "returns level two verified users" do
|
|
user1 = create(:user, confirmed_phone: "123456789", residence_verified_at: Time.current)
|
|
user2 = create(:user, confirmed_phone: "123456789", residence_verified_at: nil)
|
|
user3 = create(:user, confirmed_phone: nil, residence_verified_at: Time.current)
|
|
user4 = create(:user, level_two_verified_at: Time.current)
|
|
|
|
expect(model.level_two_verified).to match_array [user1, user4]
|
|
expect(model.level_two_verified).not_to include(user2)
|
|
expect(model.level_two_verified).not_to include(user3)
|
|
end
|
|
end
|
|
|
|
describe "#level_two_or_three_verified" do
|
|
it "returns level two or three verified users" do
|
|
user1 = create(:user, confirmed_phone: "123456789", residence_verified_at: Time.current)
|
|
user2 = create(:user, verified_at: Time.current)
|
|
user3 = create(:user, confirmed_phone: "123456789", residence_verified_at: nil)
|
|
user4 = create(:user, confirmed_phone: nil, residence_verified_at: Time.current)
|
|
user5 = create(:user, level_two_verified_at: Time.current)
|
|
|
|
expect(model.level_two_or_three_verified).to match_array [user1, user2, user5]
|
|
expect(model.level_two_or_three_verified).not_to include(user3)
|
|
expect(model.level_two_or_three_verified).not_to include(user4)
|
|
end
|
|
end
|
|
|
|
describe "#unverified" do
|
|
it "returns unverified users" do
|
|
user1 = create(:user, verified_at: nil, confirmed_phone: nil)
|
|
user2 = create(:user, verified_at: nil, residence_verified_at: nil,
|
|
confirmed_phone: "123456789")
|
|
user3 = create(:user, verified_at: nil, residence_verified_at: Time.current,
|
|
confirmed_phone: nil)
|
|
user4 = create(:user, verified_at: Time.current, residence_verified_at: Time.current,
|
|
confirmed_phone: "123456789")
|
|
user5 = create(:user, level_two_verified_at: Time.current)
|
|
|
|
expect(model.unverified).to match_array [user1, user2, user3]
|
|
expect(model.unverified).not_to include(user4)
|
|
expect(model.unverified).not_to include(user5)
|
|
end
|
|
end
|
|
|
|
describe "#incomplete_verification" do
|
|
it "returns users with incomplete verifications" do
|
|
user1 = create(:user, verified_at: nil, confirmed_phone: nil)
|
|
create(:failed_census_call, user: user1)
|
|
|
|
user2 = create(:user, verified_at: nil, residence_verified_at: Time.current,
|
|
unconfirmed_phone: nil)
|
|
user3 = create(:user, verified_at: nil, confirmed_phone: nil)
|
|
user4 = create(:user, verified_at: Time.current, residence_verified_at: Time.current,
|
|
unconfirmed_phone: "123456789", confirmed_phone: "123456789")
|
|
|
|
expect(model.incomplete_verification).to match_array [user1, user2]
|
|
expect(model.incomplete_verification).not_to include(user3)
|
|
expect(model.incomplete_verification).not_to include(user4)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#methods" do
|
|
it "residence_verified? is true only if residence_verified_at" do
|
|
user = create(:user, residence_verified_at: Time.current)
|
|
expect(user.residence_verified?).to eq(true)
|
|
|
|
user = create(:user, residence_verified_at: nil)
|
|
expect(user.residence_verified?).to eq(false)
|
|
end
|
|
end
|
|
|
|
describe "#sms_verified?" do
|
|
it "is true only if confirmed_phone" do
|
|
user = create(:user, confirmed_phone: "123456789")
|
|
expect(user.sms_verified?).to eq(true)
|
|
|
|
user = create(:user, confirmed_phone: nil)
|
|
expect(user.sms_verified?).to eq(false)
|
|
end
|
|
end
|
|
|
|
describe "#level_two_verified?" do
|
|
it "is true if manually set, or if residence_verified_at and confirmed_phone" do
|
|
user = create(:user, level_two_verified_at: Time.current)
|
|
expect(user.level_two_verified?).to eq(true)
|
|
|
|
user = create(:user, confirmed_phone: "123456789", residence_verified_at: Time.current)
|
|
expect(user.level_two_verified?).to eq(true)
|
|
|
|
user = create(:user, confirmed_phone: nil, residence_verified_at: Time.current)
|
|
expect(user.level_two_verified?).to eq(false)
|
|
|
|
user = create(:user, confirmed_phone: "123456789", residence_verified_at: nil)
|
|
expect(user.level_two_verified?).to eq(false)
|
|
end
|
|
end
|
|
|
|
describe "#level_three_verified?" do
|
|
it "is true only if verified_at" do
|
|
user = create(:user, verified_at: Time.current)
|
|
expect(user.level_three_verified?).to eq(true)
|
|
|
|
user = create(:user, verified_at: nil)
|
|
expect(user.level_three_verified?).to eq(false)
|
|
end
|
|
end
|
|
|
|
describe "#unverified?" do
|
|
it "is true only if not level_three_verified and not level_two_verified" do
|
|
user = create(:user, verified_at: nil, confirmed_phone: nil)
|
|
expect(user.unverified?).to eq(true)
|
|
|
|
user = create(:user, verified_at: Time.current, confirmed_phone: "123456789",
|
|
residence_verified_at: Time.current)
|
|
expect(user.unverified?).to eq(false)
|
|
end
|
|
end
|
|
|
|
describe "#verification_email_sent?" do
|
|
it "is true only if user has email_verification_token" do
|
|
user = create(:user, email_verification_token: "xxxxxxx")
|
|
expect(user.verification_email_sent?).to eq(true)
|
|
|
|
user = create(:user, email_verification_token: nil)
|
|
expect(user.verification_email_sent?).to eq(false)
|
|
end
|
|
end
|
|
|
|
describe "#verification_sms_sent?" do
|
|
it "is true if user has unconfirmed_phone & sms_confirmation_code" do
|
|
user = create(:user, unconfirmed_phone: "666666666", sms_confirmation_code: "666")
|
|
expect(user.verification_sms_sent?).to eq(true)
|
|
|
|
user = create(:user, unconfirmed_phone: nil, sms_confirmation_code: "666")
|
|
expect(user.verification_sms_sent?).to eq(false)
|
|
|
|
user = create(:user, unconfirmed_phone: "666666666", sms_confirmation_code: nil)
|
|
expect(user.verification_sms_sent?).to eq(false)
|
|
|
|
user = create(:user, unconfirmed_phone: nil, sms_confirmation_code: nil)
|
|
expect(user.verification_sms_sent?).to eq(false)
|
|
end
|
|
end
|
|
|
|
describe "#verification_letter_sent?" do
|
|
it "is true if user has letter_requested_at & letter_verification_code" do
|
|
user = create(:user, letter_requested_at: Time.current, letter_verification_code: "666")
|
|
expect(user.verification_letter_sent?).to eq(true)
|
|
|
|
user = create(:user, letter_requested_at: nil, letter_verification_code: "666")
|
|
expect(user.verification_letter_sent?).to eq(false)
|
|
|
|
user = create(:user, letter_requested_at: Time.current, letter_verification_code: nil)
|
|
expect(user.verification_letter_sent?).to eq(false)
|
|
|
|
user = create(:user, letter_requested_at: nil, letter_verification_code: nil)
|
|
expect(user.verification_letter_sent?).to eq(false)
|
|
end
|
|
end
|
|
|
|
describe "methods modified by Setting user.skip_verification" do
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
before do
|
|
Setting["feature.user.skip_verification"] = "true"
|
|
end
|
|
|
|
describe "#residence_verified?" do
|
|
it "is true if skipped" do
|
|
expect(user.residence_verified?).to eq(true)
|
|
end
|
|
end
|
|
|
|
describe "#sms_verified?" do
|
|
it "is true if skipped" do
|
|
expect(user.sms_verified?).to eq(true)
|
|
end
|
|
end
|
|
|
|
describe "#level_two_verified?" do
|
|
it "is true if skipped" do
|
|
expect(user.level_two_verified?).to eq(true)
|
|
|
|
user.update!(residence_verified_at: Time.current)
|
|
expect(user.level_two_verified?).to eq(true)
|
|
|
|
user.update!(confirmed_phone: "123456789", residence_verified_at: false)
|
|
expect(user.level_two_verified?).to eq(true)
|
|
end
|
|
end
|
|
|
|
describe "#level_three_verified?" do
|
|
it "is true if skipped" do
|
|
expect(user.level_three_verified?).to eq(true)
|
|
end
|
|
end
|
|
|
|
describe "#verification_email_sent?" do
|
|
it "is true if skipped" do
|
|
expect(user.verification_email_sent?).to eq(true)
|
|
end
|
|
end
|
|
|
|
describe "#verification_sms_sent?" do
|
|
it "is true if skipped" do
|
|
user.update!(unconfirmed_phone: nil, sms_confirmation_code: "666")
|
|
expect(user.verification_sms_sent?).to eq(true)
|
|
|
|
user.update!(unconfirmed_phone: "666666666", sms_confirmation_code: nil)
|
|
expect(user.verification_sms_sent?).to eq(true)
|
|
|
|
user.update!(unconfirmed_phone: nil, sms_confirmation_code: nil)
|
|
expect(user.verification_sms_sent?).to eq(true)
|
|
end
|
|
end
|
|
|
|
describe "#verification_letter_sent?" do
|
|
it "is true if skipped" do
|
|
user.update!(letter_requested_at: nil, letter_verification_code: "666")
|
|
expect(user.verification_letter_sent?).to eq(true)
|
|
|
|
user.update!(letter_requested_at: Time.current, letter_verification_code: nil)
|
|
expect(user.verification_letter_sent?).to eq(true)
|
|
|
|
user.update!(letter_requested_at: nil, letter_verification_code: nil)
|
|
expect(user.verification_letter_sent?).to eq(true)
|
|
end
|
|
end
|
|
end
|
|
|
|
end
|