7ca55c44e0
Having exceptions is better than having silent bugs.
There are a few methods I've kept the same way they were.
The `RelatedContentScore#score_with_opposite` method is a bit peculiar:
it creates scores for both itself and the opposite related content,
which means the opposite related content will try to create the same
scores as well.
We've already got a test to check `Budget::Ballot#add_investment` when
creating a line fails ("Edge case voting a non-elegible investment").
Finally, the method `User#send_oauth_confirmation_instructions` doesn't
update the record when the email address isn't already present, leading
to the test "Try to register with the email of an already existing user,
when an unconfirmed email was provided by oauth" fo fail if we raise an
exception for an invalid user. That's because updating a user's email
doesn't update the database automatically, but instead a confirmation
email is sent.
There are also a few false positives for classes which don't have bang
methods (like the GraphQL classes) or destroying attachments.
For these reasons, I'm adding the rule with a "Refactor" severity,
meaning it's a rule we can break if necessary.
368 lines
9.8 KiB
Ruby
368 lines
9.8 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Votes" do
|
|
let!(:verified) { create(:user, verified_at: Time.current) }
|
|
let!(:unverified) { create(:user) }
|
|
|
|
before do
|
|
end
|
|
|
|
describe "Debates" do
|
|
before { login_as(verified) }
|
|
|
|
scenario "Index shows user votes on debates" do
|
|
|
|
debate1 = create(:debate)
|
|
debate2 = create(:debate)
|
|
debate3 = create(:debate)
|
|
create(:vote, voter: verified, votable: debate1, vote_flag: true)
|
|
create(:vote, voter: verified, votable: debate3, vote_flag: false)
|
|
|
|
visit debates_path
|
|
|
|
within("#debates") do
|
|
within("#debate_#{debate1.id}_votes") do
|
|
within(".in-favor") do
|
|
expect(page).to have_css("a.voted")
|
|
expect(page).not_to have_css("a.no-voted")
|
|
end
|
|
|
|
within(".against") do
|
|
expect(page).to have_css("a.no-voted")
|
|
expect(page).not_to have_css("a.voted")
|
|
end
|
|
end
|
|
|
|
within("#debate_#{debate2.id}_votes") do
|
|
within(".in-favor") do
|
|
expect(page).not_to have_css("a.voted")
|
|
expect(page).not_to have_css("a.no-voted")
|
|
end
|
|
|
|
within(".against") do
|
|
expect(page).not_to have_css("a.no-voted")
|
|
expect(page).not_to have_css("a.voted")
|
|
end
|
|
end
|
|
|
|
within("#debate_#{debate3.id}_votes") do
|
|
within(".in-favor") do
|
|
expect(page).to have_css("a.no-voted")
|
|
expect(page).not_to have_css("a.voted")
|
|
end
|
|
|
|
within(".against") do
|
|
expect(page).to have_css("a.voted")
|
|
expect(page).not_to have_css("a.no-voted")
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "Single debate" do
|
|
|
|
scenario "Show no votes" do
|
|
visit debate_path(create(:debate))
|
|
|
|
expect(page).to have_content "No votes"
|
|
|
|
within(".in-favor") do
|
|
expect(page).to have_content "0%"
|
|
expect(page).not_to have_css("a.voted")
|
|
expect(page).not_to have_css("a.no-voted")
|
|
end
|
|
|
|
within(".against") do
|
|
expect(page).to have_content "0%"
|
|
expect(page).not_to have_css("a.voted")
|
|
expect(page).not_to have_css("a.no-voted")
|
|
end
|
|
end
|
|
|
|
scenario "Update", :js do
|
|
visit debate_path(create(:debate))
|
|
|
|
find(".in-favor a").click
|
|
|
|
within(".in-favor") do
|
|
expect(page).to have_content "100%"
|
|
expect(page).to have_css("a.voted")
|
|
end
|
|
|
|
find(".against a").click
|
|
|
|
within(".in-favor") do
|
|
expect(page).to have_content "0%"
|
|
expect(page).to have_css("a.no-voted")
|
|
end
|
|
|
|
within(".against") do
|
|
expect(page).to have_content "100%"
|
|
expect(page).to have_css("a.voted")
|
|
end
|
|
|
|
expect(page).to have_content "1 vote"
|
|
end
|
|
|
|
scenario "Trying to vote multiple times", :js do
|
|
visit debate_path(create(:debate))
|
|
|
|
find(".in-favor a").click
|
|
expect(page).to have_content "1 vote"
|
|
find(".in-favor a").click
|
|
expect(page).not_to have_content "2 votes"
|
|
|
|
within(".in-favor") do
|
|
expect(page).to have_content "100%"
|
|
end
|
|
|
|
within(".against") do
|
|
expect(page).to have_content "0%"
|
|
end
|
|
end
|
|
|
|
scenario "Show" do
|
|
debate = create(:debate)
|
|
create(:vote, voter: verified, votable: debate, vote_flag: true)
|
|
create(:vote, voter: unverified, votable: debate, vote_flag: false)
|
|
|
|
visit debate_path(debate)
|
|
|
|
expect(page).to have_content "No votes"
|
|
|
|
within(".in-favor") do
|
|
expect(page).to have_content "50%"
|
|
expect(page).to have_css("a.voted")
|
|
end
|
|
|
|
within(".against") do
|
|
expect(page).to have_content "50%"
|
|
expect(page).to have_css("a.no-voted")
|
|
end
|
|
end
|
|
|
|
scenario "Create from debate show", :js do
|
|
visit debate_path(create(:debate))
|
|
|
|
find(".in-favor a").click
|
|
|
|
within(".in-favor") do
|
|
expect(page).to have_content "100%"
|
|
expect(page).to have_css("a.voted")
|
|
end
|
|
|
|
within(".against") do
|
|
expect(page).to have_content "0%"
|
|
expect(page).to have_css("a.no-voted")
|
|
end
|
|
|
|
expect(page).to have_content "1 vote"
|
|
end
|
|
|
|
scenario "Create in index", :js do
|
|
create(:debate)
|
|
visit debates_path
|
|
|
|
within("#debates") do
|
|
|
|
find(".in-favor a").click
|
|
|
|
within(".in-favor") do
|
|
expect(page).to have_content "100%"
|
|
expect(page).to have_css("a.voted")
|
|
end
|
|
|
|
within(".against") do
|
|
expect(page).to have_content "0%"
|
|
expect(page).to have_css("a.no-voted")
|
|
end
|
|
|
|
expect(page).to have_content "1 vote"
|
|
end
|
|
expect(page).to have_current_path(debates_path)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "Proposals" do
|
|
before { login_as(verified) }
|
|
|
|
scenario "Index shows user votes on proposals" do
|
|
proposal1 = create(:proposal, voters: [verified])
|
|
proposal2 = create(:proposal)
|
|
proposal3 = create(:proposal)
|
|
|
|
visit proposals_path
|
|
|
|
within("#proposals") do
|
|
within("#proposal_#{proposal1.id}_votes") do
|
|
expect(page).to have_content "You have already supported this proposal. Share it!"
|
|
end
|
|
|
|
within("#proposal_#{proposal2.id}_votes") do
|
|
expect(page).not_to have_content "You have already supported this proposal. Share it!"
|
|
end
|
|
|
|
within("#proposal_#{proposal3.id}_votes") do
|
|
expect(page).not_to have_content "You have already supported this proposal. Share it!"
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "Single proposal" do
|
|
let!(:proposal) { create(:proposal) }
|
|
|
|
scenario "Show no votes" do
|
|
visit proposal_path(proposal)
|
|
expect(page).to have_content "No supports"
|
|
end
|
|
|
|
scenario "Trying to vote multiple times", :js do
|
|
visit proposal_path(proposal)
|
|
|
|
within(".supports") do
|
|
find(".in-favor a").click
|
|
expect(page).to have_content "1 support"
|
|
|
|
expect(page).not_to have_selector ".in-favor a"
|
|
end
|
|
end
|
|
|
|
scenario "Show" do
|
|
create(:vote, voter: verified, votable: proposal, vote_flag: true)
|
|
create(:vote, voter: unverified, votable: proposal, vote_flag: true)
|
|
|
|
visit proposal_path(proposal)
|
|
|
|
within(".supports") do
|
|
expect(page).to have_content "2 supports"
|
|
end
|
|
end
|
|
|
|
scenario "Create from proposal show", :js do
|
|
visit proposal_path(proposal)
|
|
|
|
within(".supports") do
|
|
find(".in-favor a").click
|
|
|
|
expect(page).to have_content "1 support"
|
|
expect(page).to have_content "You have already supported this proposal. Share it!"
|
|
end
|
|
end
|
|
|
|
scenario "Create in listed proposal in index", :js do
|
|
visit proposals_path
|
|
|
|
within("#proposal_#{proposal.id}") do
|
|
find(".in-favor a").click
|
|
|
|
expect(page).to have_content "1 support"
|
|
expect(page).to have_content "You have already supported this proposal. Share it!"
|
|
end
|
|
expect(page).to have_current_path(proposals_path)
|
|
end
|
|
|
|
scenario "Create in featured proposal in index", :js do
|
|
visit proposals_path
|
|
|
|
within("#proposal_#{proposal.id}") do
|
|
find(".in-favor a").click
|
|
|
|
expect(page).to have_content "You have already supported this proposal. Share it!"
|
|
end
|
|
expect(page).to have_current_path(proposals_path)
|
|
end
|
|
end
|
|
end
|
|
|
|
scenario "Not logged user trying to vote debates", :js do
|
|
debate = create(:debate)
|
|
|
|
visit debates_path
|
|
within("#debate_#{debate.id}") do
|
|
find("div.votes").hover
|
|
expect_message_you_need_to_sign_in
|
|
end
|
|
end
|
|
|
|
scenario "Not logged user trying to vote proposals", :js do
|
|
proposal = create(:proposal)
|
|
|
|
visit proposals_path
|
|
within("#proposal_#{proposal.id}") do
|
|
find("div.supports").hover
|
|
expect_message_you_need_to_sign_in
|
|
end
|
|
|
|
visit proposal_path(proposal)
|
|
within("#proposal_#{proposal.id}") do
|
|
find("div.supports").hover
|
|
expect_message_you_need_to_sign_in
|
|
end
|
|
end
|
|
|
|
scenario "Not logged user trying to vote comments in debates", :js do
|
|
debate = create(:debate)
|
|
comment = create(:comment, commentable: debate)
|
|
|
|
visit comment_path(comment)
|
|
within("#comment_#{comment.id}") do
|
|
find("div.votes").hover
|
|
expect_message_you_need_to_sign_in_to_vote_comments
|
|
end
|
|
end
|
|
|
|
scenario "Not logged user trying to vote comments in proposals", :js do
|
|
proposal = create(:proposal)
|
|
comment = create(:comment, commentable: proposal)
|
|
|
|
visit comment_path(comment)
|
|
within("#comment_#{comment.id}_reply") do
|
|
find("div.votes").hover
|
|
expect_message_you_need_to_sign_in_to_vote_comments
|
|
end
|
|
end
|
|
|
|
scenario "Anonymous user trying to vote debates", :js do
|
|
user = create(:user)
|
|
debate = create(:debate)
|
|
|
|
Setting["max_ratio_anon_votes_on_debates"] = 50
|
|
debate.update!(cached_anonymous_votes_total: 520, cached_votes_total: 1000)
|
|
|
|
login_as(user)
|
|
|
|
visit debates_path
|
|
within("#debate_#{debate.id}") do
|
|
find("div.votes").hover
|
|
expect_message_to_many_anonymous_votes
|
|
end
|
|
|
|
visit debate_path(debate)
|
|
within("#debate_#{debate.id}") do
|
|
find("div.votes").hover
|
|
expect_message_to_many_anonymous_votes
|
|
end
|
|
end
|
|
|
|
scenario "Anonymous user trying to vote proposals", :js do
|
|
user = create(:user)
|
|
proposal = create(:proposal)
|
|
|
|
login_as(user)
|
|
visit proposals_path
|
|
|
|
within("#proposal_#{proposal.id}") do
|
|
find("div.supports").hover
|
|
expect_message_only_verified_can_vote_proposals
|
|
end
|
|
|
|
visit proposal_path(proposal)
|
|
within("#proposal_#{proposal.id}") do
|
|
find("div.supports").hover
|
|
expect_message_only_verified_can_vote_proposals
|
|
end
|
|
end
|
|
|
|
end
|