7ca55c44e0
Having exceptions is better than having silent bugs.
There are a few methods I've kept the same way they were.
The `RelatedContentScore#score_with_opposite` method is a bit peculiar:
it creates scores for both itself and the opposite related content,
which means the opposite related content will try to create the same
scores as well.
We've already got a test to check `Budget::Ballot#add_investment` when
creating a line fails ("Edge case voting a non-elegible investment").
Finally, the method `User#send_oauth_confirmation_instructions` doesn't
update the record when the email address isn't already present, leading
to the test "Try to register with the email of an already existing user,
when an unconfirmed email was provided by oauth" fo fail if we raise an
exception for an invalid user. That's because updating a user's email
doesn't update the database automatically, but instead a confirmation
email is sent.
There are also a few false positives for classes which don't have bang
methods (like the GraphQL classes) or destroying attachments.
For these reasons, I'm adding the rule with a "Refactor" severity,
meaning it's a rule we can break if necessary.
503 lines
15 KiB
Ruby
503 lines
15 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Polls" do
|
|
|
|
context "Concerns" do
|
|
it_behaves_like "notifiable in-app", :poll
|
|
end
|
|
|
|
context "#index" do
|
|
|
|
scenario "Shows description for open polls" do
|
|
visit polls_path
|
|
expect(page).not_to have_content "Description for open polls"
|
|
|
|
create(:active_poll, description: "Description for open polls")
|
|
|
|
visit polls_path
|
|
expect(page).to have_content "Description for open polls"
|
|
|
|
click_link "Expired"
|
|
expect(page).not_to have_content "Description for open polls"
|
|
end
|
|
|
|
scenario "Polls can be listed" do
|
|
visit polls_path
|
|
expect(page).to have_content("There are no open votings")
|
|
|
|
polls = create_list(:poll, 3, :with_image)
|
|
|
|
visit polls_path
|
|
|
|
polls.each do |poll|
|
|
expect(page).to have_content(poll.name)
|
|
expect(page).to have_css("img[alt='#{poll.image.title}']")
|
|
expect(page).to have_link("Participate in this poll")
|
|
end
|
|
end
|
|
|
|
scenario "Proposal polls won't be listed" do
|
|
proposal = create(:proposal)
|
|
_poll = create(:poll, related: proposal)
|
|
|
|
visit polls_path
|
|
expect(page).to have_content("There are no open votings")
|
|
end
|
|
|
|
scenario "Filtering polls" do
|
|
create(:poll, name: "Current poll")
|
|
create(:poll, :expired, name: "Expired poll")
|
|
|
|
visit polls_path
|
|
expect(page).to have_content("Current poll")
|
|
expect(page).to have_link("Participate in this poll")
|
|
expect(page).not_to have_content("Expired poll")
|
|
|
|
visit polls_path(filter: "expired")
|
|
expect(page).not_to have_content("Current poll")
|
|
expect(page).to have_content("Expired poll")
|
|
expect(page).to have_link("Poll ended")
|
|
end
|
|
|
|
scenario "Current filter is properly highlighted" do
|
|
visit polls_path
|
|
expect(page).not_to have_link("Open")
|
|
expect(page).to have_link("Expired")
|
|
|
|
visit polls_path(filter: "expired")
|
|
expect(page).to have_link("Open")
|
|
expect(page).not_to have_link("Expired")
|
|
end
|
|
|
|
scenario "Displays icon correctly", :js do
|
|
create_list(:poll, 3)
|
|
|
|
visit polls_path
|
|
|
|
expect(page).to have_css(".not-logged-in", count: 3)
|
|
expect(page).to have_content("You must sign in or sign up to participate")
|
|
|
|
user = create(:user)
|
|
login_as(user)
|
|
|
|
visit polls_path
|
|
|
|
expect(page).to have_css(".unverified", count: 3)
|
|
expect(page).to have_content("You must verify your account to participate")
|
|
end
|
|
|
|
scenario "Geozone poll" do
|
|
create(:poll, geozone_restricted: true)
|
|
|
|
login_as(create(:user, :level_two))
|
|
visit polls_path
|
|
|
|
expect(page).to have_css(".cant-answer", count: 1)
|
|
expect(page).to have_content("This poll is not available on your geozone")
|
|
end
|
|
|
|
scenario "Already participated in a poll", :js do
|
|
poll_with_question = create(:poll)
|
|
question = create(:poll_question, :yes_no, poll: poll_with_question)
|
|
|
|
login_as(create(:user, :level_two))
|
|
visit polls_path
|
|
|
|
vote_for_poll_via_web(poll_with_question, question, "Yes")
|
|
|
|
visit polls_path
|
|
|
|
expect(page).to have_css(".already-answer", count: 1)
|
|
expect(page).to have_content("You already have participated in this poll")
|
|
end
|
|
|
|
scenario "Poll title link to stats if enabled" do
|
|
poll = create(:poll, name: "Poll with stats", stats_enabled: true)
|
|
|
|
visit polls_path
|
|
|
|
expect(page).to have_link("Poll with stats", href: stats_poll_path(poll.slug))
|
|
end
|
|
|
|
scenario "Poll title link to results if enabled" do
|
|
poll = create(:poll, name: "Poll with results", stats_enabled: true, results_enabled: true)
|
|
|
|
visit polls_path
|
|
|
|
expect(page).to have_link("Poll with results", href: results_poll_path(poll.slug))
|
|
end
|
|
end
|
|
|
|
context "Show" do
|
|
let(:geozone) { create(:geozone) }
|
|
let(:poll) { create(:poll, summary: "Summary", description: "Description") }
|
|
|
|
scenario "Visit path with id" do
|
|
visit poll_path(poll.id)
|
|
expect(page).to have_current_path(poll_path(poll.id))
|
|
end
|
|
|
|
scenario "Visit path with slug" do
|
|
visit poll_path(poll.slug)
|
|
expect(page).to have_current_path(poll_path(poll.slug))
|
|
end
|
|
|
|
scenario "Show answers with videos" do
|
|
create(:poll_answer_video, poll: poll, title: "Awesome video", url: "youtube.com/watch?v=123")
|
|
|
|
visit poll_path(poll)
|
|
|
|
expect(page).to have_link("Awesome video", href: "youtube.com/watch?v=123")
|
|
end
|
|
|
|
scenario "Lists questions from proposals as well as regular ones" do
|
|
normal_question = create(:poll_question, poll: poll)
|
|
proposal_question = create(:poll_question, poll: poll, proposal: create(:proposal))
|
|
|
|
visit poll_path(poll)
|
|
expect(page).to have_content(poll.name)
|
|
expect(page).to have_content(poll.summary)
|
|
expect(page).to have_content(poll.description)
|
|
|
|
expect(page).to have_content(normal_question.title)
|
|
expect(page).to have_content(proposal_question.title)
|
|
end
|
|
|
|
scenario "Question answers appear in the given order" do
|
|
question = create(:poll_question, poll: poll)
|
|
answer1 = create(:poll_question_answer, title: "First", question: question, given_order: 2)
|
|
answer2 = create(:poll_question_answer, title: "Second", question: question, given_order: 1)
|
|
|
|
visit poll_path(poll)
|
|
|
|
within("div#poll_question_#{question.id}") do
|
|
expect(answer2.title).to appear_before(answer1.title)
|
|
end
|
|
end
|
|
|
|
scenario "More info answers appear in the given order" do
|
|
question = create(:poll_question, poll: poll)
|
|
answer1 = create(:poll_question_answer, title: "First", question: question, given_order: 2)
|
|
answer2 = create(:poll_question_answer, title: "Second", question: question, given_order: 1)
|
|
|
|
visit poll_path(poll)
|
|
|
|
within("div.poll-more-info-answers") do
|
|
expect(answer2.title).to appear_before(answer1.title)
|
|
end
|
|
end
|
|
|
|
scenario "Non-logged in users" do
|
|
create(:poll_question, :yes_no, poll: poll)
|
|
|
|
visit poll_path(poll)
|
|
|
|
expect(page).to have_content("You must sign in or sign up to participate")
|
|
expect(page).to have_link("Yes", href: new_user_session_path)
|
|
expect(page).to have_link("No", href: new_user_session_path)
|
|
end
|
|
|
|
scenario "Level 1 users" do
|
|
visit polls_path
|
|
expect(page).not_to have_selector(".already-answer")
|
|
|
|
poll.update!(geozone_restricted: true)
|
|
poll.geozones << geozone
|
|
|
|
create(:poll_question, :yes_no, poll: poll)
|
|
|
|
login_as(create(:user, geozone: geozone))
|
|
visit poll_path(poll)
|
|
|
|
expect(page).to have_content("You must verify your account in order to answer")
|
|
|
|
expect(page).to have_link("Yes", href: verification_path)
|
|
expect(page).to have_link("No", href: verification_path)
|
|
end
|
|
|
|
scenario "Level 2 users in an expired poll" do
|
|
expired_poll = create(:poll, :expired, geozone_restricted: true)
|
|
expired_poll.geozones << geozone
|
|
|
|
question = create(:poll_question, :yes_no, poll: expired_poll)
|
|
|
|
login_as(create(:user, :level_two, geozone: geozone))
|
|
|
|
visit poll_path(expired_poll)
|
|
|
|
within("#poll_question_#{question.id}_answers") do
|
|
expect(page).to have_content("Yes")
|
|
expect(page).to have_content("No")
|
|
expect(page).not_to have_link("Yes")
|
|
expect(page).not_to have_link("No")
|
|
end
|
|
expect(page).to have_content("This poll has finished")
|
|
end
|
|
|
|
scenario "Level 2 users in a poll with questions for a geozone which is not theirs" do
|
|
poll.update!(geozone_restricted: true)
|
|
poll.geozones << create(:geozone)
|
|
|
|
question = create(:poll_question, :yes_no, poll: poll)
|
|
|
|
login_as(create(:user, :level_two))
|
|
|
|
visit poll_path(poll)
|
|
|
|
within("#poll_question_#{question.id}_answers") do
|
|
expect(page).to have_content("Yes")
|
|
expect(page).to have_content("No")
|
|
expect(page).not_to have_link("Yes")
|
|
expect(page).not_to have_link("No")
|
|
end
|
|
end
|
|
|
|
scenario "Level 2 users reading a same-geozone poll" do
|
|
poll.update!(geozone_restricted: true)
|
|
poll.geozones << geozone
|
|
|
|
question = create(:poll_question, :yes_no, poll: poll)
|
|
|
|
login_as(create(:user, :level_two, geozone: geozone))
|
|
visit poll_path(poll)
|
|
|
|
within("#poll_question_#{question.id}_answers") do
|
|
expect(page).to have_link("Yes")
|
|
expect(page).to have_link("No")
|
|
end
|
|
end
|
|
|
|
scenario "Level 2 users reading a all-geozones poll" do
|
|
question = create(:poll_question, :yes_no, poll: poll)
|
|
|
|
login_as(create(:user, :level_two))
|
|
visit poll_path(poll)
|
|
|
|
within("#poll_question_#{question.id}_answers") do
|
|
expect(page).to have_link("Yes")
|
|
expect(page).to have_link("No")
|
|
end
|
|
end
|
|
|
|
scenario "Level 2 users who have already answered" do
|
|
question = create(:poll_question, :yes_no, poll: poll)
|
|
user = create(:user, :level_two)
|
|
create(:poll_answer, question: question, author: user, answer: "No")
|
|
|
|
login_as user
|
|
visit poll_path(poll)
|
|
|
|
within("#poll_question_#{question.id}_answers") do
|
|
expect(page).to have_link("Yes")
|
|
expect(page).to have_link("No")
|
|
end
|
|
end
|
|
|
|
scenario "Level 2 users answering", :js do
|
|
poll.update!(geozone_restricted: true)
|
|
poll.geozones << geozone
|
|
|
|
question = create(:poll_question, :yes_no, poll: poll)
|
|
user = create(:user, :level_two, geozone: geozone)
|
|
|
|
login_as user
|
|
visit poll_path(poll)
|
|
|
|
within("#poll_question_#{question.id}_answers") do
|
|
click_link "Yes"
|
|
|
|
expect(page).not_to have_link("Yes")
|
|
expect(page).to have_link("No")
|
|
end
|
|
end
|
|
|
|
scenario "Level 2 users changing answer", :js do
|
|
poll.update!(geozone_restricted: true)
|
|
poll.geozones << geozone
|
|
|
|
question = create(:poll_question, :yes_no, poll: poll)
|
|
user = create(:user, :level_two, geozone: geozone)
|
|
|
|
login_as user
|
|
visit poll_path(poll)
|
|
|
|
within("#poll_question_#{question.id}_answers") do
|
|
click_link "Yes"
|
|
|
|
expect(page).not_to have_link("Yes")
|
|
expect(page).to have_link("No")
|
|
|
|
click_link "No"
|
|
|
|
expect(page).not_to have_link("No")
|
|
expect(page).to have_link("Yes")
|
|
end
|
|
end
|
|
|
|
scenario "Level 2 votes, signs out, signs in, votes again", :js do
|
|
poll.update!(geozone_restricted: true)
|
|
poll.geozones << geozone
|
|
|
|
question = create(:poll_question, :yes_no, poll: poll)
|
|
user = create(:user, :level_two, geozone: geozone)
|
|
|
|
login_as user
|
|
visit poll_path(poll)
|
|
|
|
within("#poll_question_#{question.id}_answers") do
|
|
click_link "Yes"
|
|
|
|
expect(page).not_to have_link("Yes")
|
|
expect(page).to have_link("No")
|
|
end
|
|
|
|
click_link "Sign out"
|
|
login_as user
|
|
visit poll_path(poll)
|
|
within("#poll_question_#{question.id}_answers") do
|
|
click_link "Yes"
|
|
|
|
expect(page).not_to have_link("Yes")
|
|
expect(page).to have_link("No")
|
|
end
|
|
|
|
click_link "Sign out"
|
|
login_as user
|
|
visit poll_path(poll)
|
|
within("#poll_question_#{question.id}_answers") do
|
|
click_link "No"
|
|
|
|
expect(page).not_to have_link("No")
|
|
expect(page).to have_link("Yes")
|
|
end
|
|
end
|
|
end
|
|
|
|
context "Booth & Website", :with_frozen_time do
|
|
|
|
let(:poll) { create(:poll, summary: "Summary", description: "Description") }
|
|
let(:booth) { create(:poll_booth) }
|
|
let(:officer) { create(:poll_officer) }
|
|
|
|
scenario "Already voted on booth cannot vote on website", :js do
|
|
create(:poll_shift, officer: officer, booth: booth, date: Date.current, task: :vote_collection)
|
|
create(:poll_officer_assignment, officer: officer, poll: poll, booth: booth, date: Date.current)
|
|
question = create(:poll_question, :yes_no, poll: poll)
|
|
user = create(:user, :level_two, :in_census)
|
|
|
|
login_as(officer.user)
|
|
visit new_officing_residence_path
|
|
officing_verify_residence
|
|
click_button "Confirm vote"
|
|
|
|
expect(page).to have_content "Vote introduced!"
|
|
|
|
visit new_officing_residence_path
|
|
click_link "Sign out"
|
|
login_as user
|
|
visit poll_path(poll)
|
|
|
|
expect(page).to have_content "You have already participated in a physical booth. You can not participate again."
|
|
|
|
within("#poll_question_#{question.id}_answers") do
|
|
expect(page).to have_content("Yes")
|
|
expect(page).to have_content("No")
|
|
|
|
expect(page).not_to have_link("Yes")
|
|
expect(page).not_to have_link("No")
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
context "Results and stats" do
|
|
scenario "Show poll results and stats if enabled and poll expired" do
|
|
poll = create(:poll, :expired, results_enabled: true, stats_enabled: true)
|
|
user = create(:user)
|
|
|
|
login_as user
|
|
visit poll_path(poll)
|
|
|
|
expect(page).to have_content("Poll results")
|
|
expect(page).to have_content("Participation statistics")
|
|
|
|
visit results_poll_path(poll)
|
|
expect(page).to have_content("Questions")
|
|
|
|
visit stats_poll_path(poll)
|
|
|
|
expect(page).to have_content("Participation data")
|
|
expect(page).not_to have_content "Advanced statistics"
|
|
end
|
|
|
|
scenario "Advanced stats enabled" do
|
|
poll = create(:poll, :expired, stats_enabled: true, advanced_stats_enabled: true)
|
|
|
|
visit stats_poll_path(poll)
|
|
|
|
expect(page).to have_content "Participation data"
|
|
expect(page).to have_content "Advanced statistics"
|
|
end
|
|
|
|
scenario "Don't show poll results and stats if not enabled" do
|
|
poll = create(:poll, :expired, results_enabled: false, stats_enabled: false)
|
|
user = create(:user)
|
|
|
|
login_as user
|
|
visit poll_path(poll)
|
|
|
|
expect(page).not_to have_content("Poll results")
|
|
expect(page).not_to have_content("Participation statistics")
|
|
|
|
visit results_poll_path(poll)
|
|
expect(page).to have_content("You do not have permission to carry out the action 'results' on poll.")
|
|
|
|
visit stats_poll_path(poll)
|
|
expect(page).to have_content("You do not have permission to carry out the action 'stats' on poll.")
|
|
end
|
|
|
|
scenario "Do not show poll results or stats to admins if disabled" do
|
|
poll = create(:poll, :expired, results_enabled: false, stats_enabled: false)
|
|
admin = create(:administrator).user
|
|
|
|
login_as admin
|
|
visit poll_path(poll)
|
|
|
|
expect(page).not_to have_content("Poll results")
|
|
expect(page).not_to have_content("Participation statistics")
|
|
end
|
|
|
|
scenario "Don't show poll results and stats if is not expired" do
|
|
poll = create(:poll, :current, results_enabled: true, stats_enabled: true)
|
|
user = create(:user)
|
|
|
|
login_as user
|
|
visit poll_path(poll)
|
|
|
|
expect(page).not_to have_content("Poll results")
|
|
expect(page).not_to have_content("Participation statistics")
|
|
|
|
visit results_poll_path(poll)
|
|
expect(page).to have_content("You do not have permission to carry out the action 'results' on poll.")
|
|
|
|
visit stats_poll_path(poll)
|
|
expect(page).to have_content("You do not have permission to carry out the action 'stats' on poll.")
|
|
end
|
|
|
|
scenario "Generates navigation links for polls without a slug" do
|
|
poll = create(:poll, :expired, results_enabled: true, stats_enabled: true)
|
|
poll.update_column(:slug, nil)
|
|
|
|
visit poll_path(poll)
|
|
|
|
expect(page).to have_link "Participation statistics"
|
|
expect(page).to have_link "Poll results"
|
|
|
|
click_link "Poll results"
|
|
|
|
expect(page).to have_link "Information"
|
|
end
|
|
|
|
end
|
|
end
|