7ca55c44e0
Having exceptions is better than having silent bugs.
There are a few methods I've kept the same way they were.
The `RelatedContentScore#score_with_opposite` method is a bit peculiar:
it creates scores for both itself and the opposite related content,
which means the opposite related content will try to create the same
scores as well.
We've already got a test to check `Budget::Ballot#add_investment` when
creating a line fails ("Edge case voting a non-elegible investment").
Finally, the method `User#send_oauth_confirmation_instructions` doesn't
update the record when the email address isn't already present, leading
to the test "Try to register with the email of an already existing user,
when an unconfirmed email was provided by oauth" fo fail if we raise an
exception for an invalid user. That's because updating a user's email
doesn't update the database automatically, but instead a confirmation
email is sent.
There are also a few false positives for classes which don't have bang
methods (like the GraphQL classes) or destroying attachments.
For these reasons, I'm adding the rule with a "Refactor" severity,
meaning it's a rule we can break if necessary.
202 lines
7.4 KiB
Ruby
202 lines
7.4 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Votes" do
|
|
|
|
describe "Investments" do
|
|
let(:manuela) { create(:user, verified_at: Time.current) }
|
|
let(:budget) { create(:budget, :selecting) }
|
|
let(:group) { create(:budget_group, budget: budget) }
|
|
let(:heading) { create(:budget_heading, group: group) }
|
|
|
|
before { login_as(manuela) }
|
|
|
|
describe "Index" do
|
|
|
|
scenario "Index shows user votes on proposals" do
|
|
investment1 = create(:budget_investment, heading: heading, voters: [manuela])
|
|
investment2 = create(:budget_investment, heading: heading)
|
|
investment3 = create(:budget_investment, heading: heading)
|
|
|
|
visit budget_investments_path(budget, heading_id: heading.id)
|
|
|
|
within("#budget-investments") do
|
|
within("#budget_investment_#{investment1.id}_votes") do
|
|
expect(page).to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
|
|
within("#budget_investment_#{investment2.id}_votes") do
|
|
expect(page).not_to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
|
|
within("#budget_investment_#{investment3.id}_votes") do
|
|
expect(page).not_to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
end
|
|
end
|
|
|
|
scenario "Create from investments' index", :js do
|
|
create(:budget_investment, heading: heading)
|
|
|
|
visit budget_investments_path(budget, heading_id: heading.id)
|
|
|
|
within(".supports") do
|
|
find(".in-favor a").click
|
|
|
|
expect(page).to have_content "1 support"
|
|
expect(page).to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "Single investment" do
|
|
let(:investment) { create(:budget_investment, heading: heading) }
|
|
|
|
scenario "Show no votes" do
|
|
visit budget_investment_path(budget, investment)
|
|
expect(page).to have_content "No supports"
|
|
end
|
|
|
|
scenario "Trying to vote multiple times", :js do
|
|
visit budget_investment_path(budget, investment)
|
|
|
|
within(".supports") do
|
|
find(".in-favor a").click
|
|
expect(page).to have_content "1 support"
|
|
|
|
expect(page).not_to have_selector ".in-favor a"
|
|
end
|
|
end
|
|
|
|
scenario "Create from investment show", :js do
|
|
visit budget_investment_path(budget, investment)
|
|
|
|
within(".supports") do
|
|
find(".in-favor a").click
|
|
|
|
expect(page).to have_content "1 support"
|
|
expect(page).to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
end
|
|
end
|
|
|
|
scenario "Disable voting on investments", :js do
|
|
budget.update!(phase: "reviewing")
|
|
investment = create(:budget_investment, heading: heading)
|
|
|
|
manuela = create(:user, verified_at: Time.current)
|
|
login_as(manuela)
|
|
|
|
visit budget_investments_path(budget, heading_id: heading.id)
|
|
|
|
within("#budget_investment_#{investment.id}") do
|
|
expect(page).not_to have_css("budget_investment_#{investment.id}_votes")
|
|
end
|
|
|
|
visit budget_investment_path(budget, investment)
|
|
|
|
within("#budget_investment_#{investment.id}") do
|
|
expect(page).not_to have_css("budget_investment_#{investment.id}_votes")
|
|
end
|
|
end
|
|
|
|
context "Voting in multiple headings of a single group" do
|
|
|
|
let(:new_york) { heading }
|
|
let(:san_francisco) { create(:budget_heading, group: group) }
|
|
let(:third_heading) { create(:budget_heading, group: group) }
|
|
|
|
let!(:new_york_investment) { create(:budget_investment, heading: new_york) }
|
|
let!(:san_francisco_investment) { create(:budget_investment, heading: san_francisco) }
|
|
let!(:third_heading_investment) { create(:budget_investment, heading: third_heading) }
|
|
|
|
before do
|
|
group.update(max_votable_headings: 2)
|
|
end
|
|
|
|
scenario "From Index", :js do
|
|
visit budget_investments_path(budget, heading_id: new_york.id)
|
|
|
|
within("#budget_investment_#{new_york_investment.id}") do
|
|
accept_confirm { find(".in-favor a").click }
|
|
|
|
expect(page).to have_content "1 support"
|
|
expect(page).to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
|
|
visit budget_investments_path(budget, heading_id: san_francisco.id)
|
|
|
|
within("#budget_investment_#{san_francisco_investment.id}") do
|
|
find(".in-favor a").click
|
|
|
|
expect(page).to have_content "1 support"
|
|
expect(page).to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
|
|
visit budget_investments_path(budget, heading_id: third_heading.id)
|
|
|
|
within("#budget_investment_#{third_heading_investment.id}") do
|
|
find(".in-favor a").click
|
|
|
|
expect(page).to have_content "You can only support investment projects in 2 districts. "\
|
|
"You have already supported investments in"
|
|
|
|
participation = find(".participation-not-allowed")
|
|
headings = participation.text
|
|
.match(/You have already supported investments in (.+) and (.+)\./)&.captures
|
|
|
|
expect(headings).to match_array [new_york.name, san_francisco.name]
|
|
|
|
expect(page).not_to have_content "1 support"
|
|
expect(page).not_to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
end
|
|
|
|
scenario "From show", :js do
|
|
visit budget_investment_path(budget, new_york_investment)
|
|
|
|
accept_confirm { find(".in-favor a").click }
|
|
expect(page).to have_content "1 support"
|
|
expect(page).to have_content "You have already supported this investment project. Share it!"
|
|
|
|
visit budget_investment_path(budget, san_francisco_investment)
|
|
|
|
find(".in-favor a").click
|
|
expect(page).to have_content "1 support"
|
|
expect(page).to have_content "You have already supported this investment project. Share it!"
|
|
|
|
visit budget_investment_path(budget, third_heading_investment)
|
|
|
|
find(".in-favor a").click
|
|
expect(page).to have_content "You can only support investment projects in 2 districts. "\
|
|
"You have already supported investments in"
|
|
|
|
participation = find(".participation-not-allowed")
|
|
headings = participation.text
|
|
.match(/You have already supported investments in (.+) and (.+)\./)&.captures
|
|
|
|
expect(headings).to match_array [new_york.name, san_francisco.name]
|
|
|
|
expect(page).not_to have_content "1 support"
|
|
expect(page).not_to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
|
|
scenario "Confirm message shows the right text", :js do
|
|
visit budget_investments_path(budget, heading_id: new_york.id)
|
|
find(".in-favor a").click
|
|
|
|
expect(page.driver.send(:find_modal).text).to match "You can only support investments in 2 districts."
|
|
end
|
|
|
|
end
|
|
end
|
|
end
|