7ca55c44e0
Having exceptions is better than having silent bugs.
There are a few methods I've kept the same way they were.
The `RelatedContentScore#score_with_opposite` method is a bit peculiar:
it creates scores for both itself and the opposite related content,
which means the opposite related content will try to create the same
scores as well.
We've already got a test to check `Budget::Ballot#add_investment` when
creating a line fails ("Edge case voting a non-elegible investment").
Finally, the method `User#send_oauth_confirmation_instructions` doesn't
update the record when the email address isn't already present, leading
to the test "Try to register with the email of an already existing user,
when an unconfirmed email was provided by oauth" fo fail if we raise an
exception for an invalid user. That's because updating a user's email
doesn't update the database automatically, but instead a confirmation
email is sent.
There are also a few false positives for classes which don't have bang
methods (like the GraphQL classes) or destroying attachments.
For these reasons, I'm adding the rule with a "Refactor" severity,
meaning it's a rule we can break if necessary.
50 lines
1.2 KiB
Ruby
50 lines
1.2 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Stats" do
|
|
|
|
let(:budget) { create(:budget, :finished) }
|
|
let(:heading) { create(:budget_heading, budget: budget, price: 1000) }
|
|
|
|
context "Load" do
|
|
|
|
before { budget.update(slug: "budget_slug") }
|
|
|
|
scenario "finds budget by slug" do
|
|
visit budget_stats_path("budget_slug")
|
|
|
|
expect(page).to have_content budget.name
|
|
end
|
|
|
|
scenario "raises an error if budget slug is not found" do
|
|
expect do
|
|
visit budget_stats_path("wrong_budget")
|
|
end.to raise_error ActiveRecord::RecordNotFound
|
|
end
|
|
|
|
scenario "raises an error if budget id is not found" do
|
|
expect do
|
|
visit budget_stats_path(0)
|
|
end.to raise_error ActiveRecord::RecordNotFound
|
|
end
|
|
|
|
end
|
|
|
|
describe "Show" do
|
|
describe "advanced stats" do
|
|
scenario "advanced stats enabled" do
|
|
budget.update!(advanced_stats_enabled: true)
|
|
|
|
visit budget_stats_path(budget)
|
|
|
|
expect(page).to have_content "Advanced statistics"
|
|
end
|
|
|
|
scenario "advanced stats disabled" do
|
|
visit budget_stats_path(budget)
|
|
|
|
expect(page).not_to have_content "Advanced statistics"
|
|
end
|
|
end
|
|
end
|
|
end
|