7ca55c44e0
Having exceptions is better than having silent bugs.
There are a few methods I've kept the same way they were.
The `RelatedContentScore#score_with_opposite` method is a bit peculiar:
it creates scores for both itself and the opposite related content,
which means the opposite related content will try to create the same
scores as well.
We've already got a test to check `Budget::Ballot#add_investment` when
creating a line fails ("Edge case voting a non-elegible investment").
Finally, the method `User#send_oauth_confirmation_instructions` doesn't
update the record when the email address isn't already present, leading
to the test "Try to register with the email of an already existing user,
when an unconfirmed email was provided by oauth" fo fail if we raise an
exception for an invalid user. That's because updating a user's email
doesn't update the database automatically, but instead a confirmation
email is sent.
There are also a few false positives for classes which don't have bang
methods (like the GraphQL classes) or destroying attachments.
For these reasons, I'm adding the rule with a "Refactor" severity,
meaning it's a rule we can break if necessary.
124 lines
3.4 KiB
Ruby
124 lines
3.4 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Valuator groups" do
|
|
|
|
let(:admin) { create(:administrator).user }
|
|
|
|
before do
|
|
login_as(admin)
|
|
end
|
|
|
|
scenario "Index" do
|
|
group1 = create(:valuator_group)
|
|
group2 = create(:valuator_group)
|
|
3.times { create(:valuator, valuator_group: group1) }
|
|
|
|
visit admin_valuator_groups_path
|
|
|
|
within("#valuator_group_#{group1.id}") do
|
|
expect(page).to have_content group1.name
|
|
expect(page).to have_content 3
|
|
end
|
|
|
|
within("#valuator_group_#{group2.id}") do
|
|
expect(page).to have_content group2.name
|
|
expect(page).to have_content 0
|
|
end
|
|
end
|
|
|
|
scenario "Show" do
|
|
group = create(:valuator_group)
|
|
valuator1 = create(:valuator, valuator_group: group)
|
|
valuator2 = create(:valuator, valuator_group: group)
|
|
valuator3 = create(:valuator, valuator_group: nil)
|
|
|
|
visit admin_valuator_group_path(group)
|
|
|
|
expect(page).to have_content group.name
|
|
|
|
within("#valuators") do
|
|
expect(page).to have_link(valuator1.email, href: admin_valuator_path(valuator1))
|
|
expect(page).to have_link(valuator2.email, href: admin_valuator_path(valuator2))
|
|
expect(page).not_to have_link(valuator3.email)
|
|
end
|
|
end
|
|
|
|
scenario "Create" do
|
|
visit admin_valuators_path
|
|
|
|
click_link "Valuator Groups"
|
|
click_link "Create valuators group"
|
|
|
|
fill_in "valuator_group_name", with: "Health"
|
|
click_button "Create valuators group"
|
|
|
|
expect(page).to have_content "Valuator group created successfully"
|
|
expect(page).to have_content "There is 1 valuator group"
|
|
expect(page).to have_content "Health"
|
|
end
|
|
|
|
scenario "Update" do
|
|
create(:valuator_group, name: "Health")
|
|
|
|
visit admin_valuator_groups_path
|
|
click_link "Edit"
|
|
|
|
fill_in "valuator_group_name", with: "Health and Sports"
|
|
click_button "Save valuators group"
|
|
|
|
expect(page).to have_content "Valuator group updated successfully"
|
|
expect(page).to have_content "Health and Sports"
|
|
end
|
|
|
|
scenario "Delete" do
|
|
create(:valuator_group)
|
|
|
|
visit admin_valuator_groups_path
|
|
click_link "Delete"
|
|
|
|
expect(page).to have_content "Valuator group deleted successfully"
|
|
expect(page).to have_content "There are no valuator groups"
|
|
end
|
|
|
|
context "Assign valuators to groups" do
|
|
let(:valuator) { create(:valuator) }
|
|
|
|
scenario "Add a valuator to a group" do
|
|
create(:valuator_group, name: "Health")
|
|
|
|
visit edit_admin_valuator_path(valuator)
|
|
|
|
select "Health", from: "valuator_valuator_group_id"
|
|
click_button "Update Valuator"
|
|
|
|
expect(page).to have_content "Valuator updated successfully"
|
|
expect(page).to have_content "Health"
|
|
end
|
|
|
|
scenario "Update a valuator's group" do
|
|
valuator.update!(valuator_group: create(:valuator_group, name: "Economy"))
|
|
create(:valuator_group, name: "Health")
|
|
|
|
visit edit_admin_valuator_path(valuator)
|
|
select "Economy", from: "valuator_valuator_group_id"
|
|
click_button "Update Valuator"
|
|
|
|
expect(page).to have_content "Valuator updated successfully"
|
|
expect(page).to have_content "Economy"
|
|
end
|
|
|
|
scenario "Remove a valuator from a group" do
|
|
valuator.update!(valuator_group: create(:valuator_group, name: "Health"))
|
|
|
|
visit edit_admin_valuator_path(valuator)
|
|
select "", from: "valuator_valuator_group_id"
|
|
click_button "Update Valuator"
|
|
|
|
expect(page).to have_content "Valuator updated successfully"
|
|
expect(page).not_to have_content "Health"
|
|
end
|
|
|
|
end
|
|
|
|
end
|