7ca55c44e0
Having exceptions is better than having silent bugs.
There are a few methods I've kept the same way they were.
The `RelatedContentScore#score_with_opposite` method is a bit peculiar:
it creates scores for both itself and the opposite related content,
which means the opposite related content will try to create the same
scores as well.
We've already got a test to check `Budget::Ballot#add_investment` when
creating a line fails ("Edge case voting a non-elegible investment").
Finally, the method `User#send_oauth_confirmation_instructions` doesn't
update the record when the email address isn't already present, leading
to the test "Try to register with the email of an already existing user,
when an unconfirmed email was provided by oauth" fo fail if we raise an
exception for an invalid user. That's because updating a user's email
doesn't update the database automatically, but instead a confirmation
email is sent.
There are also a few false positives for classes which don't have bang
methods (like the GraphQL classes) or destroying attachments.
For these reasons, I'm adding the rule with a "Refactor" severity,
meaning it's a rule we can break if necessary.
149 lines
4.2 KiB
Ruby
149 lines
4.2 KiB
Ruby
class Admin::BudgetInvestmentsController < Admin::BaseController
|
|
include FeatureFlags
|
|
include CommentableActions
|
|
include DownloadSettingsHelper
|
|
include ChangeLogHelper
|
|
include Translatable
|
|
|
|
feature_flag :budgets
|
|
|
|
has_orders %w[oldest], only: [:show, :edit]
|
|
has_filters %w[all], only: [:index, :toggle_selection]
|
|
|
|
before_action :load_budget, except: :show_investment_log
|
|
before_action :load_investment, only: [:show, :edit, :update, :toggle_selection]
|
|
before_action :load_ballot, only: [:show, :index]
|
|
before_action :parse_valuation_filters
|
|
before_action :load_investments, only: [:index, :toggle_selection]
|
|
before_action :load_change_log, only: [:show]
|
|
|
|
def index
|
|
load_tags
|
|
respond_to do |format|
|
|
format.html
|
|
format.js
|
|
format.csv do
|
|
send_data to_csv(@investments, Budget::Investment),
|
|
type: "text/csv",
|
|
disposition: "attachment",
|
|
filename: "budget_investments.csv"
|
|
end
|
|
end
|
|
end
|
|
|
|
def show
|
|
load_comments
|
|
end
|
|
|
|
def edit
|
|
load_admins
|
|
load_valuators
|
|
load_valuator_groups
|
|
load_trackers
|
|
load_tags
|
|
end
|
|
|
|
def update
|
|
authorize! :admin_update, @investment
|
|
if @investment.update(budget_investment_params)
|
|
redirect_to admin_budget_budget_investment_path(@budget,
|
|
@investment,
|
|
Budget::Investment.filter_params(params).to_h),
|
|
notice: t("flash.actions.update.budget_investment")
|
|
else
|
|
load_admins
|
|
load_valuators
|
|
load_valuator_groups
|
|
load_trackers
|
|
load_tags
|
|
render :edit
|
|
end
|
|
end
|
|
|
|
def toggle_selection
|
|
@investment.toggle :selected
|
|
@investment.save!
|
|
load_investments
|
|
end
|
|
|
|
private
|
|
|
|
def load_comments
|
|
@commentable = @investment
|
|
@comment_tree = CommentTree.new(@commentable, params[:page], @current_order, valuations: true)
|
|
set_comment_flags(@comment_tree.comments)
|
|
end
|
|
|
|
def resource_model
|
|
Budget::Investment
|
|
end
|
|
|
|
def resource_name
|
|
resource_model.parameterize(separator: "_")
|
|
end
|
|
|
|
def load_investments
|
|
@investments = Budget::Investment.scoped_filter(params, @current_filter).order_filter(params)
|
|
@investments = Kaminari.paginate_array(@investments) if @investments.kind_of?(Array)
|
|
@investments = @investments.page(params[:page]) unless request.format.csv?
|
|
end
|
|
|
|
def budget_investment_params
|
|
attributes = [:external_url, :heading_id, :administrator_id, :tag_list,
|
|
:valuation_tag_list, :incompatible, :visible_to_valuators, :selected,
|
|
:milestone_tag_list, tracker_ids: [], valuator_ids: [], valuator_group_ids: []]
|
|
params.require(:budget_investment).permit(attributes, translation_params(Budget::Investment))
|
|
end
|
|
|
|
def load_budget
|
|
@budget = Budget.find_by_slug_or_id! params[:budget_id]
|
|
end
|
|
|
|
def load_investment
|
|
@investment = @budget.investments.find(params[:id])
|
|
end
|
|
|
|
def load_admins
|
|
@admins = @budget.administrators.includes(:user).all
|
|
end
|
|
|
|
def load_trackers
|
|
@trackers = @budget.trackers.includes(:user).all.order(description: :asc)
|
|
.order("users.email ASC")
|
|
end
|
|
|
|
def load_valuators
|
|
@valuators = @budget.valuators.includes(:user).all.order(description: :asc)
|
|
.order("users.email ASC")
|
|
end
|
|
|
|
def load_valuator_groups
|
|
@valuator_groups = ValuatorGroup.all.order(name: :asc)
|
|
end
|
|
|
|
def load_tags
|
|
@tags = Budget::Investment.tags_on(:valuation).order(:name).distinct
|
|
end
|
|
|
|
def load_ballot
|
|
query = Budget::Ballot.where(user: current_user, budget: @budget)
|
|
@ballot = @budget.balloting? ? query.first_or_create! : query.first_or_initialize
|
|
end
|
|
|
|
def parse_valuation_filters
|
|
if params[:valuator_or_group_id]
|
|
model, id = params[:valuator_or_group_id].split("_")
|
|
|
|
if model == "group"
|
|
params[:valuator_group_id] = id
|
|
else
|
|
params[:valuator_id] = id
|
|
end
|
|
end
|
|
end
|
|
|
|
def load_change_log
|
|
@logs = Budget::Investment::ChangeLog.by_investment(@investment.id)
|
|
end
|
|
end
|