17f442c723
In Ruby 5.2, we get a warning when using the "RANDOM()" function: DEPRECATION WARNING: Dangerous query method (method whose arguments are used as raw SQL) called with non-attribute argument(s): "RANDOM()". Non-attribute arguments will be disallowed in Rails 6.0. This method should not be called with user-provided values, such as request parameters or model attributes. Known-safe values can be passed by wrapping them in Arel.sql(). This warning doesn't make much sense, though, since RANDOM() is a common function which is not dangerous at all. However, since the warning is annoying, we'll probably have to find a way to deal with it. So I'm extracting all our RANDOM() usages into a method. This way we'll only have to change one method to avoid this warning. I've chosen `sample` because it's similar to Ruby's Array#sample, and because `order_by_random` would be confusing if we consider we already have a method called `sort_by_random`.
26 lines
735 B
Ruby
26 lines
735 B
Ruby
section "Flagging Debates & Comments" do
|
|
40.times do
|
|
debate = Debate.all.sample
|
|
flagger = User.where(["users.id <> ?", debate.author_id]).all.sample
|
|
Flag.flag(flagger, debate)
|
|
end
|
|
|
|
40.times do
|
|
comment = Comment.all.sample
|
|
flagger = User.where(["users.id <> ?", comment.user_id]).all.sample
|
|
Flag.flag(flagger, comment)
|
|
end
|
|
|
|
40.times do
|
|
proposal = Proposal.all.sample
|
|
flagger = User.where(["users.id <> ?", proposal.author_id]).all.sample
|
|
Flag.flag(flagger, proposal)
|
|
end
|
|
end
|
|
|
|
section "Ignoring flags in Debates, comments & proposals" do
|
|
Debate.flagged.sample(10).each(&:ignore_flag)
|
|
Comment.flagged.sample(30).each(&:ignore_flag)
|
|
Proposal.flagged.sample(10).each(&:ignore_flag)
|
|
end
|