abec716308
Defining a behavior on hover means making it different for people using a keyboard or a touchscreen (most of the population, nowadays). In this case, we had an accessibility issue where the message wouldn't disappear once it appeared. That meant that, after tabbing through all the links and buttons in, for instance, the debates index, the page would be filled with "participation not allowed" messages, and in order to see the information about how many people have voted, reloading the page was required. For touchscreen users the behavior was similar to what we get on hover, although we've found some inconsistencies when trying to support several elements on the same page. We think in proposals it makes sense to hide the "support" button when users click on it, and the same applies to the buttonsto support and vote investment projects. However, we aren't hiding the buttons to agree/disagree with a debate in order to keep the information about the current number of people agreeing and disagreeing visible. Note we're removing some support spec methods because after these changes the duplication isn't as obvious as it was in the past.
44 lines
1.5 KiB
Ruby
44 lines
1.5 KiB
Ruby
require "rails_helper"
|
|
|
|
describe Debates::VotesComponent do
|
|
let(:debate) { create(:debate, title: "What about the 2030 agenda?") }
|
|
let(:component) { Debates::VotesComponent.new(debate) }
|
|
|
|
describe "Agree and disagree buttons" do
|
|
it "is shown to anonymous users alongside a reminder to sign in" do
|
|
render_inline component
|
|
|
|
expect(page).to have_button "I agree"
|
|
expect(page).to have_button "I disagree"
|
|
expect(page).to have_content "You must sign in or sign up to continue."
|
|
end
|
|
|
|
it "is shown to identified users" do
|
|
sign_in(create(:user))
|
|
|
|
render_inline component
|
|
|
|
expect(page).to have_button count: 2
|
|
expect(page).to have_button "I agree", title: "I agree"
|
|
expect(page).to have_button "I agree with What about the 2030 agenda?"
|
|
expect(page).to have_button "I disagree", title: "I disagree"
|
|
expect(page).to have_button "I don't agree with What about the 2030 agenda?"
|
|
expect(page).not_to have_content "You must sign in or sign up to continue."
|
|
end
|
|
|
|
it "does not include result percentages" do
|
|
create(:vote, votable: debate)
|
|
sign_in(create(:user))
|
|
|
|
render_inline component
|
|
|
|
expect(page).to have_button count: 2
|
|
expect(page).to have_button "I agree"
|
|
expect(page).to have_button "I disagree"
|
|
expect(page).not_to have_button text: "%"
|
|
expect(page).not_to have_button text: "100"
|
|
expect(page).not_to have_button text: "0"
|
|
end
|
|
end
|
|
end
|